Page MenuHomeFreeBSD

Add WITH_LLVM_BITCODE option.
Needs ReviewPublic

Authored by jonathan on Oct 18 2017, 2:31 PM.

Details

Summary

This new option controls whether to build (and install) LLVM IR versions
of binaries and libraries alongside conventional (ELF) versions. Rather
than depending implicitly on LLVM_LINK being defined, an explicit option
(that errors out if XLLVM_LINK is not provided) is clearer with a more
obvious failure mode. It also provides a clearer signal for future
changes (e.g., the ability to build ELF binaries and libraries via IR
instead of the usual object-file workflow) to depend on.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 12108
Build 12409: arc lint + arc unit

Event Timeline

jonathan created this revision.Oct 18 2017, 2:31 PM
jonathan updated this revision to Diff 34107.Oct 18 2017, 3:02 PM
  • Add missing LLVM_IR_TYPE
sjg added inline comments.Dec 11 2017, 11:35 PM
share/mk/bsd.lib.mk
187

I believe the current convention is to test for == "yes" when that is what you mean.

189

test and logic appear to use LLVM_LINK, so the error should refer to that.

share/mk/bsd.prog.mk
157

same comments as for bsd.lib.mk

share/mk/src.opts.mk
183

shouldn't this be in bsd.opts.mk or src.opts.mk but not both?

emaste added inline comments.Dec 12 2017, 12:00 AM
share/mk/bsd.lib.mk
187

share/mk/bsd.opts.mk says:

These should be tested with == "no" or != "no" in makefiles.