Exclude assembly files from LLVM IR Builds
AbandonedPublic

Authored by bkidney_briankidney.ca on Mar 2 2017, 2:05 AM.

Details

Reviewers
jonathan
bdrewery
Summary

Excludes machine dependant code (*.S) that were causing builds to fail.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8175
Build 8403: arc lint + arc unit
bkidney_briankidney.ca retitled this revision from to Exclude assembly files from LLVM IR Builds.Mar 2 2017, 2:05 AM
bkidney_briankidney.ca updated this object.
bkidney_briankidney.ca edited the test plan for this revision. (Show Details)
jonathan added inline comments.Mar 11 2017, 3:12 AM
share/mk/bsd.lib.mk
203

How does this interact with STATICOBJS? I think that only gets used in libpam, but it would be worth checking whether we need to do the same thing there.

  • Adds filtering to STATICOBJS for BCOJBS and LLOBJS list creation.

Roling back last commit.

As I hit enter I realized that though it is safe to filer the STATICOBJS list it doesn't make sense. STATICOBJS list only include .o files.

share/mk/bsd.lib.mk
203

STATICOBJS is initialized in the Makefile for individual builds (libc, libc++, libpam, and libgcc). In this build file it is only a list of ".o" files and we do not know there origin to determine if they should be filtered.

I think this may now be redundant in light of https://reviews.freebsd.org/D12701?