Page MenuHomeFreeBSD
Differential D14134

New port: x11-themes/arc-gruvbox-theme
ClosedPublic
Actions

Authored by jonathan on Jan 30 2018, 6:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 13, 6:22 AM
Unknown Object (File)
Wed, Sep 9, 12:09 AM
Unknown Object (File)
Sat, Sep 5, 12:43 AM
Unknown Object (File)
Fri, Sep 4, 12:36 AM
Unknown Object (File)
Thu, Sep 3, 10:21 PM
Unknown Object (File)
Tue, Sep 1, 10:41 PM
Unknown Object (File)
Mon, Aug 31, 11:52 PM
Unknown Object (File)
Sun, Aug 30, 10:34 PM
View All Files
Subscribers
mat

Details

Reviewers
mat
Group Reviewers
Contributor Reviewers (ports)
Commits
rP460660: New port: x11-themes/arc-gruvbox-theme
Summary

Gruvbox variation of an Arc Black fork

WWW: https://github.com/Benoth/arc-variations

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jonathan created this revision.Jan 30 2018, 6:29 PM
Harbormaster completed remote builds in B14680: Diff 38682.Jan 30 2018, 6:29 PM
jonathan added a reviewer: Contributor Reviewers (ports).Jan 30 2018, 6:29 PM
mat added a subscriber: mat.Jan 31 2018, 7:50 AM
mat added inline comments.
x11-themes/arc-gruvbox-theme/Makefile
4 ↗(On Diff #38682)

Never use a commit hash here, they are unpredictable.

Use gyyyymmdd using the date of the commit: Example 5.13. Using USE_GITHUB When Upstream Does Not Use Versions.

21–22 ↗(On Diff #38682)

NO_BUILD=yes

jonathan updated this revision to Diff 38718.Jan 31 2018, 2:02 PM
jonathan marked 2 inline comments as done.
  • Clean up as per review comments.
Harbormaster completed remote builds in B14699: Diff 38718.Jan 31 2018, 2:02 PM
mat accepted this revision.Jan 31 2018, 2:20 PM

Looks good. Note that by "date of the commit" I meant date of the commit you reference in GH_TAGNAME, not the date you will commit it in the FreeBSD ports tree. Here, it seems the date is 2016-12-21.

This revision is now accepted and ready to land.Jan 31 2018, 2:20 PM
Closed by commit rP460660: New port: x11-themes/arc-gruvbox-theme (authored by jonathan). · Explain WhyFeb 2 2018, 1:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
x11-themes/
1 line
arc-gruvbox-theme/
35 lines
3 lines
3 lines
495 lines

Diff 38769

View Options

head/x11-themes/Makefile

Loading...
View Options

head/x11-themes/arc-gruvbox-theme/Makefile

Loading...
View Options

head/x11-themes/arc-gruvbox-theme/distinfo

Loading...
View Options

head/x11-themes/arc-gruvbox-theme/pkg-descr

Loading...
View Options

head/x11-themes/arc-gruvbox-theme/pkg-plist

Loading...