Page MenuHomeFreeBSD

New port: x11-themes/arc-gruvbox-theme
ClosedPublic

Authored by jonathan on Jan 30 2018, 6:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 3, 8:03 AM
Unknown Object (File)
Thu, May 23, 12:35 AM
Unknown Object (File)
May 9 2024, 10:17 PM
Unknown Object (File)
May 6 2024, 9:19 AM
Unknown Object (File)
May 2 2024, 2:41 PM
Unknown Object (File)
Apr 27 2024, 4:42 PM
Unknown Object (File)
Apr 26 2024, 12:12 PM
Unknown Object (File)
Apr 25 2024, 4:14 AM
Subscribers

Details

Summary

Gruvbox variation of an Arc Black fork

WWW: https://github.com/Benoth/arc-variations

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mat added inline comments.
x11-themes/arc-gruvbox-theme/Makefile
4 ↗(On Diff #38682)

Never use a commit hash here, they are unpredictable.

Use gyyyymmdd using the date of the commit: Example 5.13. Using USE_GITHUB When Upstream Does Not Use Versions.

21–22 ↗(On Diff #38682)

NO_BUILD=yes

jonathan marked 2 inline comments as done.
  • Clean up as per review comments.

Looks good. Note that by "date of the commit" I meant date of the commit you reference in GH_TAGNAME, not the date you will commit it in the FreeBSD ports tree. Here, it seems the date is 2016-12-21.

This revision is now accepted and ready to land.Jan 31 2018, 2:20 PM
This revision was automatically updated to reflect the committed changes.