Page MenuHomeFreeBSD

New port: x11-themes/arc-gruvbox-theme
ClosedPublic

Authored by jonathan on Jan 30 2018, 6:29 PM.
Tags
None
Referenced Files
F82062435: D14134.id38718.diff
Thu, Apr 25, 4:14 AM
Unknown Object (File)
Tue, Apr 23, 10:17 PM
Unknown Object (File)
Mon, Apr 22, 4:34 AM
Unknown Object (File)
Mon, Apr 22, 4:34 AM
Unknown Object (File)
Mon, Apr 22, 4:34 AM
Unknown Object (File)
Mon, Apr 22, 4:20 AM
Unknown Object (File)
Thu, Apr 11, 2:10 PM
Unknown Object (File)
Thu, Apr 11, 4:52 AM
Subscribers

Details

Summary

Gruvbox variation of an Arc Black fork

WWW: https://github.com/Benoth/arc-variations

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14680
Build 14807: arc lint + arc unit

Event Timeline

mat added inline comments.
x11-themes/arc-gruvbox-theme/Makefile
4

Never use a commit hash here, they are unpredictable.

Use gyyyymmdd using the date of the commit: Example 5.13. Using USE_GITHUB When Upstream Does Not Use Versions.

21–22

NO_BUILD=yes

jonathan marked 2 inline comments as done.
  • Clean up as per review comments.

Looks good. Note that by "date of the commit" I meant date of the commit you reference in GH_TAGNAME, not the date you will commit it in the FreeBSD ports tree. Here, it seems the date is 2016-12-21.

This revision is now accepted and ready to land.Jan 31 2018, 2:20 PM
This revision was automatically updated to reflect the committed changes.