Page MenuHomeFreeBSD

dchagin (Dmitry Chagin)
User

Projects

User Details

User Since
May 10 2014, 6:29 PM (511 w, 5 d)

Recent Activity

Sun, Feb 25

dchagin accepted D44077: sigsys test: correct count of delivered signals.
Sun, Feb 25, 7:40 AM

Dec 27 2023

dchagin accepted D43199: linux: Check for copyout errors in ioctl handlers.

10x

Dec 27 2023, 8:16 AM

Dec 19 2023

dchagin added a comment to D42374: linprocfs: Add arm64 CPU features.

Perhaps we should put the machine-dependent code into a separate file, eg, $arch/linux/linprocfs.c?

Dec 19 2023, 12:23 PM
dchagin accepted D43104: linux: Check for copyout errors in linux_fixup().
Dec 19 2023, 7:36 AM

Nov 21 2023

dchagin added a comment to D42694: sockets: don't malloc/free sockaddr memory on getpeername/getsockname.

just out of curiosity, why to not to add new kernel interfaces aka
kern_getsockname3(struct thread *td, int fd, struct sockaddr_storage *ss)
and below, into the pr methods?

Nov 21 2023, 9:47 AM
dchagin accepted D42635: sockets: don't malloc/free sockaddr memory on accept(2).

Linux emu part, I hope you merge that into at least stable/14

Nov 21 2023, 9:23 AM

Nov 17 2023

dchagin added inline comments to D42635: sockets: don't malloc/free sockaddr memory on accept(2).
Nov 17 2023, 9:07 AM

Nov 6 2023

dchagin committed rGc21038f55230: arm64: Use the Linux sigframe to restore registers (authored by andrew).
arm64: Use the Linux sigframe to restore registers
Nov 6 2023, 3:14 PM

Oct 25 2023

dchagin accepted D42360: arm64: Use the Linux sigframe to restore registers.

Please add PR: 270250 to the commit message,
You have fixed this bug, golang tests suite passed. Thank you

Oct 25 2023, 4:50 PM
dchagin added a comment to D42360: arm64: Use the Linux sigframe to restore registers.

Nice, that was in my plans, I was waiting when SVE to be finished. Thanks!
So are the go tests suite passes now? I suspected that similarly to amd64 the problem is in the sigcontext layout on arm64.

Oct 25 2023, 10:48 AM

Oct 22 2023

dchagin committed rGaccbd5ad06c3: vfs cache: Fallback to namei to resolve symlinks with leading / in target for… (authored by dchagin).
vfs cache: Fallback to namei to resolve symlinks with leading / in target for…
Oct 22 2023, 6:47 PM
dchagin committed rGb84a836ef02d: vfs cache: Fallback to namei to resolve symlinks with leading / in target for… (authored by dchagin).
vfs cache: Fallback to namei to resolve symlinks with leading / in target for…
Oct 22 2023, 6:57 AM

Oct 19 2023

dchagin closed D41806: vfs cache: Fallback to namei to resolve symlinks with leading / in target for non-native ABI.
Oct 19 2023, 10:35 AM
dchagin committed rGbb8ecf259f96: vfs cache: Fallback to namei to resolve symlinks with leading / in target for… (authored by dchagin).
vfs cache: Fallback to namei to resolve symlinks with leading / in target for…
Oct 19 2023, 10:35 AM

Oct 18 2023

dchagin committed rG133ada6bff53: linux(4): Drop the outdated comment, nosys is fine since 39024a89 (authored by dchagin).
linux(4): Drop the outdated comment, nosys is fine since 39024a89
Oct 18 2023, 5:54 AM
dchagin committed rGc9ec2fb86cf1: linux(4): Drop the outdated comments about sixth register on i386 int0x80 (authored by dchagin).
linux(4): Drop the outdated comments about sixth register on i386 int0x80
Oct 18 2023, 5:53 AM

Oct 10 2023

dchagin committed rG5bdd74cc05e6: linux(4): Drop the outdated comments about sixth register on i386 int0x80 (authored by dchagin).
linux(4): Drop the outdated comments about sixth register on i386 int0x80
Oct 10 2023, 9:34 AM
dchagin committed rG03f5bd1e4625: linux(4): Drop the outdated comment, nosys is fine since 39024a89 (authored by dchagin).
linux(4): Drop the outdated comment, nosys is fine since 39024a89
Oct 10 2023, 9:34 AM
dchagin committed rG78d34c77f425: linux(4): Deduplicate SystemV IPC defines from amd64/linux (authored by dchagin).
linux(4): Deduplicate SystemV IPC defines from amd64/linux
Oct 10 2023, 9:07 AM
dchagin committed rGf9d36fa86cdd: tests: Test that SIGSYS is not delivered if kern.signosys knob is off (authored by dchagin).
tests: Test that SIGSYS is not delivered if kern.signosys knob is off
Oct 10 2023, 5:17 AM
dchagin committed rG4c1b13627a75: linux(4): Fix semid64_ds structure layout (authored by dchagin).
linux(4): Fix semid64_ds structure layout
Oct 10 2023, 5:15 AM
dchagin committed rG2e8294945749: linux(4): Actually delete linux_sysproto.h (authored by dchagin).
linux(4): Actually delete linux_sysproto.h
Oct 10 2023, 5:15 AM
dchagin committed rG49dc4d714aee: sysent: Trim trailing whitespaces (authored by dchagin).
sysent: Trim trailing whitespaces
Oct 10 2023, 5:15 AM
dchagin committed rGce693de706fc: linux(4): Deorbit linux_nosys (authored by dchagin).
linux(4): Deorbit linux_nosys
Oct 10 2023, 5:14 AM
dchagin committed rG761d9162d2ab: tests: Test that SIGSYS is not delivered if kern.signosys knob is off (authored by dchagin).
tests: Test that SIGSYS is not delivered if kern.signosys knob is off
Oct 10 2023, 5:14 AM
dchagin committed rGa4b328aa4182: linux(4): Regen for linux_nosys change (authored by dchagin).
linux(4): Regen for linux_nosys change
Oct 10 2023, 5:14 AM
dchagin committed rGea54d65b340e: linux(4): Deorbit linux_nosys from syscalls.master (authored by dchagin).
linux(4): Deorbit linux_nosys from syscalls.master
Oct 10 2023, 5:14 AM

Oct 4 2023

dchagin committed rG1ee29160c5e5: linux(4): Fix semid64_ds structure layout (authored by dchagin).
linux(4): Fix semid64_ds structure layout
Oct 4 2023, 6:23 PM
dchagin committed rG4fe779900b5d: linux(4): Deduplicate SystemV IPC defines from amd64/linux (authored by dchagin).
linux(4): Deduplicate SystemV IPC defines from amd64/linux
Oct 4 2023, 6:22 PM

Oct 3 2023

dchagin added a reviewer for D42032: semctl(2): Add SEM_STAT to the list of operations: manpages.
Oct 3 2023, 5:49 PM
dchagin committed rGfbb3f13b1553: linux(4): Actually delete linux_sysproto.h (authored by dchagin).
linux(4): Actually delete linux_sysproto.h
Oct 3 2023, 8:27 AM
dchagin committed rG7ec361d627fa: sysent: Trim trailing whitespaces (authored by dchagin).
sysent: Trim trailing whitespaces
Oct 3 2023, 7:40 AM
dchagin committed rG199e397e9bf1: linux(4): Deorbit linux_nosys (authored by dchagin).
linux(4): Deorbit linux_nosys
Oct 3 2023, 7:39 AM
dchagin committed rG99abee8b7be2: linux(4): Regen for linux_nosys change (authored by dchagin).
linux(4): Regen for linux_nosys change
Oct 3 2023, 7:39 AM
dchagin committed rG8e523be5a5a2: linux(4): Deorbit linux_nosys from syscalls.master (authored by dchagin).
linux(4): Deorbit linux_nosys from syscalls.master
Oct 3 2023, 7:39 AM
dchagin committed rGb67c0ba46138: tests: Test that SIGSYS is not delivered if kern.signosys knob is off (authored by dchagin).
tests: Test that SIGSYS is not delivered if kern.signosys knob is off
Oct 3 2023, 7:39 AM
dchagin closed D41901: linux(4): Deorbit linux_nosys.
Oct 3 2023, 7:39 AM
dchagin closed D41902: linux(4): Deorbit linux_nosys from syscalls.master.
Oct 3 2023, 7:39 AM
dchagin closed D41979: tests: Test that SIGSYS is not delivered if kern.signosys knob is off.
Oct 3 2023, 7:39 AM

Oct 2 2023

dchagin updated the diff for D42032: semctl(2): Add SEM_STAT to the list of operations.

Fixed, thanks

Oct 2 2023, 4:56 PM
dchagin updated the diff for D42032: semctl(2): Add SEM_STAT to the list of operations.

Return values added

Oct 2 2023, 1:55 PM
dchagin closed D42028: Linux emulation q3 2023 report.
Oct 2 2023, 9:41 AM
dchagin committed R9:ca96efc8f57f: Status/2023Q3/linuxulator.adoc: Add report (authored by dchagin).
Status/2023Q3/linuxulator.adoc: Add report
Oct 2 2023, 9:41 AM
dchagin committed rG6f63d749febf: linux(4): Regen (authored by dchagin).
linux(4): Regen
Oct 2 2023, 5:46 AM
dchagin committed rG4d46ca655013: linux(4): Update syscalls.master to 6.5 (authored by dchagin).
linux(4): Update syscalls.master to 6.5
Oct 2 2023, 5:46 AM

Oct 1 2023

dchagin requested review of D42032: semctl(2): Add SEM_STAT to the list of operations.
Oct 1 2023, 9:54 PM

Sep 30 2023

dchagin retitled D42028: Linux emulation q3 2023 report from Linux emulation q2 2023 report to Linux emulation q3 2023 report.
Sep 30 2023, 11:20 PM
dchagin requested review of D42028: Linux emulation q3 2023 report.
Sep 30 2023, 11:19 PM
dchagin accepted D41976: Some fixes for nosys()/SIGSYS.
Sep 30 2023, 7:42 AM

Sep 28 2023

dchagin removed a reviewer for D36005: Unbreak syslogging with fabricated PID: dchagin.
Sep 28 2023, 6:42 PM
dchagin removed a reviewer for D41729: GPU firmware: Load i915 and amdgpu firmware failed.: dchagin.
Sep 28 2023, 6:42 PM
dchagin removed a reviewer for D39787: Support Linux Socket ioctl: LINUX_SIOCETHTOOL: dchagin.
Sep 28 2023, 6:41 PM
dchagin added inline comments to D41979: tests: Test that SIGSYS is not delivered if kern.signosys knob is off.
Sep 28 2023, 2:05 PM
dchagin updated the diff for D41979: tests: Test that SIGSYS is not delivered if kern.signosys knob is off.

Done, thanks

Sep 28 2023, 2:02 PM
dchagin added a reviewer for D41979: tests: Test that SIGSYS is not delivered if kern.signosys knob is off: markj.
Sep 28 2023, 9:13 AM
dchagin added inline comments to D41976: Some fixes for nosys()/SIGSYS.
Sep 28 2023, 9:12 AM
dchagin updated the diff for D41979: tests: Test that SIGSYS is not delivered if kern.signosys knob is off.

Use allow_sysctl_side_effects

Sep 28 2023, 9:10 AM

Sep 26 2023

dchagin removed a reviewer for D41982: timerfd: kernel random crash due to race condition to access the timerfd list: dchagin.
Sep 26 2023, 3:30 PM
dchagin added a comment to D41982: timerfd: kernel random crash due to race condition to access the timerfd list.

https://cgit.freebsd.org/src/commit/sys/kern/sys_timerfd.c?id=02f534b57f84d6f4f97c337b05b383c8b3aaf18c

btw, do you have a reproducer? I assume that it is sufficient to use the CK_LIST without locking

^^^^^^

ah, never mind, CK is not lock free

Sep 26 2023, 3:30 PM
dchagin updated the diff for D41979: tests: Test that SIGSYS is not delivered if kern.signosys knob is off.

Rebase

Sep 26 2023, 3:25 PM
dchagin added inline comments to D41976: Some fixes for nosys()/SIGSYS.
Sep 26 2023, 3:20 PM
dchagin retitled D41979: tests: Test that SIGSYS is not delivered if kern.signosys knob is off from tests: Add test for SIGSYS to tests: Test that SIGSYS is not delivered if kern.signosys knob is off.
Sep 26 2023, 1:13 PM
dchagin updated the diff for D41901: linux(4): Deorbit linux_nosys.

Adapt to D41976

Sep 26 2023, 1:11 PM
dchagin updated the diff for D41902: linux(4): Deorbit linux_nosys from syscalls.master.

Adapt to D41976

Sep 26 2023, 1:10 PM
dchagin updated the diff for D41979: tests: Test that SIGSYS is not delivered if kern.signosys knob is off.

Adapt to D41976

Sep 26 2023, 1:08 PM
dchagin added inline comments to D41976: Some fixes for nosys()/SIGSYS.
Sep 26 2023, 1:02 PM
dchagin added a comment to D41976: Some fixes for nosys()/SIGSYS.

btw, you didn't change the arm64 and i386 Linuxulator

Sep 26 2023, 10:48 AM
dchagin added a comment to D41982: timerfd: kernel random crash due to race condition to access the timerfd list.

btw, do you have a reproducer? I assume that it is sufficient to use the CK_LIST without locking

Sep 26 2023, 10:23 AM

Sep 25 2023

dchagin abandoned D41979: tests: Test that SIGSYS is not delivered if kern.signosys knob is off.
Sep 25 2023, 9:16 PM
dchagin requested review of D41979: tests: Test that SIGSYS is not delivered if kern.signosys knob is off.
Sep 25 2023, 6:39 PM
dchagin added inline comments to D41976: Some fixes for nosys()/SIGSYS.
Sep 25 2023, 6:20 PM
dchagin added a comment to D41901: linux(4): Deorbit linux_nosys.

Due to D41976

Sep 25 2023, 5:51 PM
dchagin abandoned D41929: syscall: Restore SIGSYS.

Due to D41976

Sep 25 2023, 5:51 PM
dchagin abandoned D41859: syscall: Allow the sv_fetch_syscall_args to return an uninitialized sysent on error.

Due to D41976

Sep 25 2023, 5:50 PM · Linux Emulation
dchagin accepted D41976: Some fixes for nosys()/SIGSYS.

Nice idea

Sep 25 2023, 5:47 PM
dchagin committed rGa08bb9bdd20b: linux(4): On Linux SIGKILL can not be reset to default (authored by dchagin).
linux(4): On Linux SIGKILL can not be reset to default
Sep 25 2023, 10:25 AM
dchagin committed rG058e9c13e309: linux(4): Cleanup dummy syscall list on arm64 (authored by dchagin).
linux(4): Cleanup dummy syscall list on arm64
Sep 25 2023, 10:25 AM
dchagin committed rG5ce9df199d7c: linux(4): Staticize lsiginfo_to_siginfo (authored by dchagin).
linux(4): Staticize lsiginfo_to_siginfo
Sep 25 2023, 10:25 AM
dchagin committed rG28035f675b85: linux(4): Regen (authored by dchagin).
linux(4): Regen
Sep 25 2023, 9:27 AM
dchagin committed rG0a16d3d14db6: linux(4): Update syscalls.master to 6.5 (authored by dchagin).
linux(4): Update syscalls.master to 6.5
Sep 25 2023, 9:27 AM

Sep 24 2023

dchagin committed rGcba7b3b9563c: linux(4): Cleanup includes under amd64/linux32 (authored by dchagin).
linux(4): Cleanup includes under amd64/linux32
Sep 24 2023, 10:56 AM
dchagin committed rG41a4122b7b78: linux(4): Cleanup includes under amd64/linux (authored by dchagin).
linux(4): Cleanup includes under amd64/linux
Sep 24 2023, 10:55 AM
dchagin committed rGcce0625cdf4f: linux(4): Cleanup includes under arm64 (authored by dchagin).
linux(4): Cleanup includes under arm64
Sep 24 2023, 10:55 AM
dchagin committed rGe68a2f18b64a: linux(4): Validate exec_setregs on arm64 (authored by dchagin).
linux(4): Validate exec_setregs on arm64
Sep 24 2023, 10:55 AM

Sep 21 2023

dchagin updated the summary of D41929: syscall: Restore SIGSYS.
Sep 21 2023, 12:17 PM
dchagin added a comment to D41859: syscall: Allow the sv_fetch_syscall_args to return an uninitialized sysent on error.
In D41859#955406, @kib wrote:
In D41859#955376, @kib wrote:

Btw, the way you proposed will not work, due to nosys marked as ABSENT and in such cases syscall_thread_enter() return ENOSYS.

Are you saying that sometimes we do not send SIGSYS for FreeBSD native processes?

yes, OBSOL syscalls, https://people.freebsd.org/~dchagin/nosys.c

And ABSENT as well?

Sep 21 2023, 12:14 PM · Linux Emulation
dchagin requested review of D41929: syscall: Restore SIGSYS.
Sep 21 2023, 12:09 PM
dchagin added a comment to D41806: vfs cache: Fallback to namei to resolve symlinks with leading / in target for non-native ABI.

Dmitry - appologies for not replying, I got distracted by The Witcher 3 being playable again

In essence yes, this resolved bug 273414 for me.

10x

Sep 21 2023, 8:57 AM
dchagin added a comment to D41806: vfs cache: Fallback to namei to resolve symlinks with leading / in target for non-native ABI.
In D41806#955572, @mjg wrote:

what is stopping having the same fallback as locked lookup?

Sep 21 2023, 7:26 AM

Sep 20 2023

dchagin added a comment to D41859: syscall: Allow the sv_fetch_syscall_args to return an uninitialized sysent on error.
In D41859#955376, @kib wrote:

Btw, the way you proposed will not work, due to nosys marked as ABSENT and in such cases syscall_thread_enter() return ENOSYS.

Are you saying that sometimes we do not send SIGSYS for FreeBSD native processes?

Sep 20 2023, 9:08 AM · Linux Emulation

Sep 19 2023

dchagin updated the diff for D41902: linux(4): Deorbit linux_nosys from syscalls.master.

Preserve last slot for nosys

Sep 19 2023, 10:48 PM
dchagin added a comment to D41859: syscall: Allow the sv_fetch_syscall_args to return an uninitialized sysent on error.
In D41859#955044, @kib wrote:

D41901 sounds as a hack, again.

Am I right that the issue is that nosys() sends signal, while Linux' nosys should not? If yes, there are two options:

yes

Sep 19 2023, 10:45 PM · Linux Emulation
dchagin updated the diff for D41901: linux(4): Deorbit linux_nosys.

Use a less hacker-ish method to check nosys

Sep 19 2023, 10:36 PM

Sep 18 2023

dchagin added a comment to D40623: csu: Add a stop indicator to _start to satisfy unwinders on aarch64.

Is there a reason you didn't add __asm__ volatile(".cfi_undefined x30"); to the start of the C function? In my testing with CheriBSD this appears to work in the same way (libunwind tests fail before, succeed after).

Sep 18 2023, 6:26 PM
dchagin added a comment to D40623: csu: Add a stop indicator to _start to satisfy unwinders on aarch64.

Is there a reason you didn't add __asm__ volatile(".cfi_undefined x30"); to the start of the C function? In my testing with CheriBSD this appears to work in the same way (libunwind tests fail before, succeed after).

Sep 18 2023, 6:14 PM
dchagin added a comment to D41859: syscall: Allow the sv_fetch_syscall_args to return an uninitialized sysent on error.
In D41859#954114, @kib wrote:

Can you explain more? Does linuxolator need syscall slot 0?

Sep 18 2023, 3:00 PM · Linux Emulation
dchagin requested review of D41902: linux(4): Deorbit linux_nosys from syscalls.master.
Sep 18 2023, 2:54 PM
dchagin committed rG227d01c1bc7c: linux(4): On Linux SIGKILL can not be reset to default (authored by dchagin).
linux(4): On Linux SIGKILL can not be reset to default
Sep 18 2023, 2:54 PM
dchagin requested review of D41901: linux(4): Deorbit linux_nosys.
Sep 18 2023, 2:54 PM
dchagin committed rG794328fbc174: linux(4): Staticize lsiginfo_to_siginfo (authored by dchagin).
linux(4): Staticize lsiginfo_to_siginfo
Sep 18 2023, 2:54 PM