Page MenuHomeFreeBSD

vfs cache: Fallback to namei to resolve symlinks with leading / in target for non-native ABI
ClosedPublic

Authored by dchagin on Sep 10 2023, 9:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 10:45 PM
Unknown Object (File)
Wed, Nov 20, 9:05 AM
Unknown Object (File)
Fri, Nov 15, 3:46 AM
Unknown Object (File)
Tue, Nov 12, 5:08 PM
Unknown Object (File)
Fri, Nov 8, 9:17 PM
Unknown Object (File)
Fri, Nov 8, 8:34 PM
Unknown Object (File)
Oct 28 2024, 8:12 PM
Unknown Object (File)
Oct 28 2024, 7:58 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

this would mean lookups of any absolute symlinks for linux emul would be guaranteed to start from scratch, wasting a lot of work

why not support the feature instead

In D41806#953131, @mjg wrote:

this would mean lookups of any absolute symlinks for linux emul would be guaranteed to start from scratch, wasting a lot of work

why not support the feature instead

Well, due to zander hunting season it’s to late for 14.0 ))
I propose to commit this temporary fix just for 14.0, In a month and a half, I'll have time to get serious, and for ufs too

what is stopping having the same fallback as locked lookup?

In D41806#955572, @mjg wrote:

what is stopping having the same fallback as locked lookup?

the same way? I think it's not trivial in fpl to do that, and too late for 14.0 to properly test it. I don't use ZFS, so I can't trust myself ))
So Im waiting for testing from reporters, but people are strange, no reaction

Dmitry - appologies for not replying, I got distracted by The Witcher 3 being playable again

In essence yes, this resolved bug 273414 for me.

However I also can confirm mjg's suspicion that this "creates a lot of extra work" as on first launch of Steam after the fix it took abnormally long to finish loading.

Dmitry - appologies for not replying, I got distracted by The Witcher 3 being playable again

In essence yes, this resolved bug 273414 for me.

10x

However I also can confirm mjg's suspicion that this "creates a lot of extra work" as on first launch of Steam after the fix it took abnormally long to finish loading.

Don't think it's related, we have only 2 such links: /etc/fonts and /lib/ld.so

mjg added a subscriber: glebius.

sorry for the delay

according to @glebius even with this patch things are buggy, but in a different way

I don't know if this is easily fixable, but I guess it makes sense to make them work and fail for the same cases.

All that said, I'm not going to stand in the way here.

according to @glebius even with this patch things are buggy, but in a different way

I didn't say that about this patch, that basically disabled fpl. I said that about one of the patches that tried to fix the problem without disabling fpl.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 19 2023, 10:35 AM
This revision was automatically updated to reflect the committed changes.