Page MenuHomeFreeBSD
Differential D41979

tests: Test that SIGSYS is not delivered if kern.signosys knob is off
ClosedPublic
Actions

Authored by dchagin on Sep 25 2023, 6:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 5, 3:24 AM
Unknown Object (File)
Wed, Mar 26, 5:17 PM
Unknown Object (File)
Wed, Mar 26, 3:47 PM
Unknown Object (File)
Wed, Mar 26, 3:45 PM
Unknown Object (File)
Wed, Mar 26, 3:44 PM
Unknown Object (File)
Wed, Mar 26, 3:32 PM
Unknown Object (File)
Wed, Mar 26, 1:09 PM
Unknown Object (File)
Mar 11 2025, 4:59 AM
View All 75 Files
Subscribers
imp

Details

Reviewers
kib
markj
Commits
rGf9d36fa86cdd: tests: Test that SIGSYS is not delivered if kern.signosys knob is off
rG761d9162d2ab: tests: Test that SIGSYS is not delivered if kern.signosys knob is off
rGb67c0ba46138: tests: Test that SIGSYS is not delivered if kern.signosys knob is off

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dchagin created this revision.Sep 25 2023, 6:39 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 25 2023, 6:39 PM
dchagin requested review of this revision.Sep 25 2023, 6:39 PM
Harbormaster completed remote builds in B53719: Diff 127800.Sep 25 2023, 6:39 PM
dchagin abandoned this revision.Sep 25 2023, 9:16 PM
kib mentioned this in D41976: Some fixes for nosys()/SIGSYS.Sep 26 2023, 9:52 AM
dchagin updated this revision to Diff 127820.Sep 26 2023, 1:08 PM

Adapt to D41976

Harbormaster completed remote builds in B53725: Diff 127820.Sep 26 2023, 1:08 PM
dchagin retitled this revision from tests: Add test for SIGSYS to tests: Test that SIGSYS is not delivered if kern.signosys knob is off.Sep 26 2023, 1:13 PM
dchagin updated this revision to Diff 127824.Sep 26 2023, 3:25 PM

Rebase

Harbormaster completed remote builds in B53728: Diff 127824.Sep 26 2023, 3:25 PM
dchagin updated this revision to Diff 127892.Sep 28 2023, 9:10 AM

Use allow_sysctl_side_effects

Harbormaster completed remote builds in B53750: Diff 127892.Sep 28 2023, 9:10 AM
dchagin added a reviewer: markj.Sep 28 2023, 9:13 AM
markj added inline comments.Sep 28 2023, 1:11 PM
tests/sys/kern/sigsys.c
43

Why not just pass the expected value as a parameter to sigsys_test()?

90
dchagin updated this revision to Diff 127905.Sep 28 2023, 2:02 PM

Done, thanks

Harbormaster completed remote builds in B53756: Diff 127905.Sep 28 2023, 2:02 PM
dchagin marked 2 inline comments as done.Sep 28 2023, 2:05 PM
dchagin added inline comments.
tests/sys/kern/sigsys.c
43

Why not just pass the expected value as a parameter to sigsys_test()?

Hmm, brought it back, indeed

markj accepted this revision.Sep 28 2023, 2:11 PM
This revision is now accepted and ready to land.Sep 28 2023, 2:11 PM
Closed by commit rGb67c0ba46138: tests: Test that SIGSYS is not delivered if kern.signosys knob is off (authored by dchagin). · Explain WhyOct 3 2023, 7:39 AM
This revision was automatically updated to reflect the committed changes.
dchagin marked an inline comment as done.
dchagin added a commit: rGb67c0ba46138: tests: Test that SIGSYS is not delivered if kern.signosys knob is off.
dchagin added a commit: rG761d9162d2ab: tests: Test that SIGSYS is not delivered if kern.signosys knob is off.Oct 10 2023, 5:14 AM
dchagin added a commit: rGf9d36fa86cdd: tests: Test that SIGSYS is not delivered if kern.signosys knob is off.Oct 10 2023, 5:17 AM

Revision Contents
Changeset List

PathSize
tests/
sys/
kern/
1 line
101 lines

Diff 128150

View Options

tests/sys/kern/Makefile

Show First 20 Lines • Show All 1,699 Lines • ▼ Show 20 Lines case SIOCDELMULTI:
trunk = TRUNK(ifv); trunk = TRUNK(ifv);
if (trunk != NULL) { if (trunk != NULL) {
TRUNK_LOCK(trunk); TRUNK_LOCK(trunk);
error = vlan_setmulti(ifp); error = vlan_setmulti(ifp);
TRUNK_UNLOCK(trunk); TRUNK_UNLOCK(trunk);
} }
break; break;
case SIOCSIFCAP:
VLAN_LOCK();
if (TRUNK(ifv) != NULL) {
p = PARENT(ifv);
VLAN_UNLOCK();
if ((p->if_type != IFT_ETHER) &&
(ifr->ifr_reqcap & IFCAP_VLAN_HWTAGGING) == 0) {
error = EINVAL;
break;
}
error = (*p->if_ioctl)(p, cmd, data);
if (error)
break;
/* Propogate vlan interface capabilities */
vlan_trunk_capabilities(p);
} else {
VLAN_UNLOCK();
error = EINVAL;
}
break;
default: default:
error = EINVAL; error = EINVAL;
break; break;
} }
return (error); return (error);
} }
View Options

tests/sys/kern/sigsys.c

Show First 20 Lines • Show All 1,699 Lines • ▼ Show 20 Lines case SIOCDELMULTI:
trunk = TRUNK(ifv); trunk = TRUNK(ifv);
if (trunk != NULL) { if (trunk != NULL) {
TRUNK_LOCK(trunk); TRUNK_LOCK(trunk);
error = vlan_setmulti(ifp); error = vlan_setmulti(ifp);
TRUNK_UNLOCK(trunk); TRUNK_UNLOCK(trunk);
} }
break; break;
case SIOCSIFCAP:
VLAN_LOCK();
if (TRUNK(ifv) != NULL) {
p = PARENT(ifv);
VLAN_UNLOCK();
if ((p->if_type != IFT_ETHER) &&
(ifr->ifr_reqcap & IFCAP_VLAN_HWTAGGING) == 0) {
error = EINVAL;
break;
}
error = (*p->if_ioctl)(p, cmd, data);
if (error)
break;
/* Propogate vlan interface capabilities */
vlan_trunk_capabilities(p);
} else {
VLAN_UNLOCK();
error = EINVAL;
}
break;
default: default:
error = EINVAL; error = EINVAL;
break; break;
} }
return (error); return (error);
} }