param.h
ClosedPublic
Actions

Authored by imp on May 24 2024, 9:07 PM.

Details

Reviewers

jrtc27
val_packett.cool

Commits

rG76efd90ab093: cross-build: Include sys/types.h from sys/param.h

Summary

FreeBSD has a style(9) enforced assumption that sys/param.h includes
sys/types.h. However, Linux under musl doesn't do this so go ahead and
explicitly include it here. It won't hurt on the glibc systems, and
helps musl.

Co-authored-by: Val Packett <val@packett.cool>
Sponsored by: Netflix
Pull Request: https://github.com/freebsd/freebsd-src/pull/1066

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.May 24 2024, 9:07 PM

imp created this revision.

Harbormaster completed remote builds in B57906: Diff 139063.May 24 2024, 9:07 PM

imp added a parent revision: D45351: build: Include sys/cdefs.h in our fcntl.h shim.May 24 2024, 9:07 PM

imp added a child revision: D45353: cross-build: string.h uses mode_t, so we need sys/types.h.

val_packett.cool accepted this revision.May 25 2024, 5:06 PM

This revision is now accepted and ready to land.May 25 2024, 5:06 PM

Closed by commit rG76efd90ab093: cross-build: Include sys/types.h from sys/param.h (authored by imp). · Explain WhyMay 26 2024, 5:41 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG76efd90ab093: cross-build: Include sys/types.h from sys/param.h.

Revision Contents
Changeset List

Path

Size

tools/

build/

cross-build/

include/

linux/

sys/

param.h

2 lines

Diff 139120

View Options

tools/build/cross-build/include/linux/sys/param.h

cross-build: Include sys/types.h from sys/param.hClosedPublicActions