Page MenuHomeFreeBSD

dfr (Doug Rabson)
User

Projects

User Details

User Since
Mar 7 2015, 6:48 PM (456 w, 6 d)

Recent Activity

Tue, Dec 5

dfr requested review of D42904: devel/bazel: update to 6.4.0.
Tue, Dec 5, 2:07 PM

Mon, Dec 4

dfr added a comment to D42883: FreeBSD-EN-23:19.pkgbase.

Looks good to me - the paragraphs I edited may need reformatting since I probably didn't estimate the 72 column mark consistently.

Mon, Dec 4, 3:36 PM
dfr added inline comments to D42883: FreeBSD-EN-23:19.pkgbase.
Mon, Dec 4, 3:04 PM
dfr abandoned D41607: devel/bazel*: fix build on 14.0-ALPHA3.

Fix for devel/bazel5 is merged in D42729. I will make a new diff for fixing devel/bazel which will also update to the current release version, 6.4.0.

Mon, Dec 4, 10:20 AM
dfr closed D42729: devel/bazel5: fix build on 14.0-RELEASE.
Mon, Dec 4, 10:15 AM
dfr committed R11:9e39f2af50c1: devel/bazel5: fix build on 14.0-RELEASE (authored by dfr).
devel/bazel5: fix build on 14.0-RELEASE
Mon, Dec 4, 10:15 AM

Fri, Nov 24

dfr added a comment to D41873: pkgbase: Move libz and libcrypt from runtime to clibs.
In D41873#975105, @dfr wrote:
In D41873#975104, @manu wrote:
In D41873#975103, @dfr wrote:
In D41873#975075, @manu wrote:

I think that the question is should we have a FreeBSD-sh package or not.

I really like the idea of a FreeBSD-sh package - it covers what I'm trying to achieve here and avoids breaking up the carefully curated set of libs in runtime. We would have to be careful about upgrades to try to avoid leaving systems without /bin/sh.

There is always FreeBSD-rescue in case sh fails to upgrade

Good point. I will abandon this review and make one to add FreeBSD-sh.

Fri, Nov 24, 11:30 AM · pkgbase
dfr abandoned D41873: pkgbase: Move libz and libcrypt from runtime to clibs.
Fri, Nov 24, 10:34 AM · pkgbase
dfr added a comment to D41873: pkgbase: Move libz and libcrypt from runtime to clibs.
In D41873#975104, @manu wrote:
In D41873#975103, @dfr wrote:
In D41873#975075, @manu wrote:

I think that the question is should we have a FreeBSD-sh package or not.

I really like the idea of a FreeBSD-sh package - it covers what I'm trying to achieve here and avoids breaking up the carefully curated set of libs in runtime. We would have to be careful about upgrades to try to avoid leaving systems without /bin/sh.

There is always FreeBSD-rescue in case sh fails to upgrade

Fri, Nov 24, 10:33 AM · pkgbase
dfr added a comment to D41873: pkgbase: Move libz and libcrypt from runtime to clibs.
In D41873#975075, @manu wrote:

I think that the question is should we have a FreeBSD-sh package or not.

Fri, Nov 24, 10:21 AM · pkgbase

Thu, Nov 23

dfr requested review of D42729: devel/bazel5: fix build on 14.0-RELEASE.
Thu, Nov 23, 11:06 AM

Thu, Nov 16

dfr added inline comments to D41844: Add an implementation of the 9P filesystem.
Thu, Nov 16, 2:16 PM
dfr added inline comments to D41844: Add an implementation of the 9P filesystem.
Thu, Nov 16, 2:02 PM
dfr updated the diff for D41844: Add an implementation of the 9P filesystem.

Rebased, addressed most of kib@'s comments.

Thu, Nov 16, 2:01 PM
dfr committed rGda7e9601a99a: pkgbase: use <major>.<minor> format for alpha, beta and release package versions (authored by dfr).
pkgbase: use <major>.<minor> format for alpha, beta and release package versions
Thu, Nov 16, 8:23 AM

Mon, Nov 13

dfr committed rG21e9018ae196: pkgbase: use <major>.<minor> format for alpha, beta and release package versions (authored by dfr).
pkgbase: use <major>.<minor> format for alpha, beta and release package versions
Mon, Nov 13, 2:47 PM
dfr closed D42562: pkgbase: use <major>.<minor> format for alpha, beta and release package versions.
Mon, Nov 13, 2:47 PM
dfr requested review of D42562: pkgbase: use <major>.<minor> format for alpha, beta and release package versions.
Mon, Nov 13, 1:24 PM

Sun, Nov 12

dfr committed rGe968616046a3: pkgbase: Move headers and libs out of runtime and utilities (authored by dfr).
pkgbase: Move headers and libs out of runtime and utilities
Sun, Nov 12, 11:32 AM
dfr committed rG61ba094af4b4: netfront: fix the support for disabling LRO at boot time (authored by dfr).
netfront: fix the support for disabling LRO at boot time
Sun, Nov 12, 11:32 AM

Thu, Nov 9

dfr accepted D42527: kern linker: Do not try to unload module if it has dependants.
Thu, Nov 9, 3:46 PM
dfr accepted D42530: kern linker: Do not try to unload kernel.

Looks good

Thu, Nov 9, 3:45 PM
dfr closed D42482: Update podman components to latest release versions.
Thu, Nov 9, 1:15 PM
dfr committed R11:c6f23766b6a2: sysutils/podman-suite: update to 20231103 (authored by dfr).
sysutils/podman-suite: update to 20231103
Thu, Nov 9, 1:15 PM
dfr committed R11:b39cab6a9e6f: sysutils/podman: update to 4.7.1 (authored by dfr).
sysutils/podman: update to 4.7.1
Thu, Nov 9, 1:15 PM
dfr committed R11:dac51445706f: sysutils/buildah: update to 1.32.0 (authored by dfr).
sysutils/buildah: update to 1.32.0
Thu, Nov 9, 1:15 PM
dfr committed R11:f5299ca60e33: sysutils/skopeo: update to 1.13.3 (authored by dfr).
sysutils/skopeo: update to 1.13.3
Thu, Nov 9, 1:15 PM
dfr committed R11:283602d30707: sysutils/containers-common: update to 0.56.0 (authored by dfr).
sysutils/containers-common: update to 0.56.0
Thu, Nov 9, 1:15 PM
dfr committed R11:a6e55286a659: net/containernetworking-plugins: update to 0.5 (authored by dfr).
net/containernetworking-plugins: update to 0.5
Thu, Nov 9, 1:15 PM
dfr committed R11:1e7d38d2ef70: sysutils/ocijail: update to 0.3.0 (authored by dfr).
sysutils/ocijail: update to 0.3.0
Thu, Nov 9, 1:15 PM

Nov 6 2023

dfr accepted D42474: kern linker: Do not retry loading modules on EEXIST.

Looks good to me.

Nov 6 2023, 5:35 PM
dfr added a comment to D41607: devel/bazel*: fix build on 14.0-ALPHA3.

Friendly ping - these ports are still broken on FreeBSD-14.0-RC4 which is a problem for me since I use bazel a lot and I want to be able to upgrade my home lab systems to FreeBSD-14.

Nov 6 2023, 5:02 PM
dfr requested review of D42482: Update podman components to latest release versions.
Nov 6 2023, 3:59 PM

Oct 21 2023

dfr added a comment to D41844: Add an implementation of the 9P filesystem.

Is there any assistance, short of time, that you could use from the community to help this along?

Oct 21 2023, 7:26 AM

Oct 20 2023

dfr committed rG254f85f060d6: pkgbase: Split out manpages by default (authored by dfr).
pkgbase: Split out manpages by default
Oct 20 2023, 2:15 PM
dfr committed rG2eab6bc3c08f: pkgbase: Add instructions for upgrading past 78847e1 (authored by dfr).
pkgbase: Add instructions for upgrading past 78847e1
Oct 20 2023, 2:15 PM
dfr committed rG8015c5477bd9: pkgbase: put library links and symlinks in the -dev package (authored by dfr).
pkgbase: put library links and symlinks in the -dev package
Oct 20 2023, 2:14 PM
dfr committed rGda4b0d6eb06d: netfront: fix the support for disabling LRO at boot time (authored by dfr).
netfront: fix the support for disabling LRO at boot time
Oct 20 2023, 10:52 AM
dfr closed D41439: netfront: fix the support for disabling LRO at boot time.
Oct 20 2023, 10:51 AM

Oct 9 2023

dfr added a comment to D42095: release: Let caroot depend on certctl, not vice versa..

Perhaps just remove the dependency from caroot to certctl entirely?

That's what I was asking myself earlier but the problem with this approch is that if you pkg install FreeBSD-\* (or something like that) nothing guaranty that caroot will be installed before certctl and you have a non fonctional installation because certctl wasn't run.

Oct 9 2023, 3:12 PM

Oct 8 2023

dfr added a comment to D42095: release: Let caroot depend on certctl, not vice versa..

I'm lost, what would caroot contain then ?

Oct 8 2023, 4:26 PM
dfr added a comment to D42095: release: Let caroot depend on certctl, not vice versa..
In D42095#960999, @des wrote:
In D42095#960934, @dfr wrote:

My goal with the previous change (hash 1d7ffb3) was to be able to install the caroot files in an empty chroot. This can be used as a base container image for statically linked SSL workloads.

You'd still need to hash them. So a better solution is to modify certctl to copy instead of symlinking, and just run certctl -D /path/to/jail without installing anything.

Oct 8 2023, 3:38 PM
dfr added a comment to D42095: release: Let caroot depend on certctl, not vice versa..

My goal with the previous change (hash 1d7ffb3) was to be able to install the caroot files in an empty chroot. This can be used as a base container image for statically linked SSL workloads. The other change in that commit to separate out openssl libs allows for a similar (but slightly larger) base image for dynamically linked SSL workloads. When building these images, I use the build host's certctl with DESTDIR set to generate the contents of $chroot/etc/ssl.

Oct 8 2023, 7:30 AM

Oct 3 2023

dfr added a comment to D41439: netfront: fix the support for disabling LRO at boot time.

I'll land it shortly - I also plan to merge it to stable/14 and stable/13. I'll see what re@ thinks about releng/14.0.

Oct 3 2023, 2:21 PM

Sep 17 2023

dfr committed rG4ff9d270893a: pkgbase: Add instructions for upgrading past 78847e1 (authored by dfr).
pkgbase: Add instructions for upgrading past 78847e1
Sep 17 2023, 12:22 PM
dfr closed D41892: pkgbase: Add instructions for upgrading past 78847e1.
Sep 17 2023, 12:21 PM
dfr requested review of D41892: pkgbase: Add instructions for upgrading past 78847e1.
Sep 17 2023, 10:14 AM

Sep 15 2023

dfr requested review of D41873: pkgbase: Move libz and libcrypt from runtime to clibs.
Sep 15 2023, 1:00 PM · pkgbase

Sep 14 2023

dfr updated the diff for D41844: Add an implementation of the 9P filesystem.

Rebase, remove $FreeBSD$

Sep 14 2023, 4:46 PM
dfr committed rG74da9c39c346: pkgbase: Split out manpages by default (authored by dfr).
pkgbase: Split out manpages by default
Sep 14 2023, 3:52 PM
dfr closed D41861: pkgbase: Split out manpages by default.
Sep 14 2023, 3:51 PM · pkgbase
dfr updated the diff for D41861: pkgbase: Split out manpages by default.

Document the change to MANSPLITPKG

Sep 14 2023, 2:54 PM · pkgbase
dfr requested review of D41861: pkgbase: Split out manpages by default.
Sep 14 2023, 2:39 PM · pkgbase
dfr committed rG4e899378bf5d: pkgbase: put library links and symlinks in the -dev package (authored by dfr).
pkgbase: put library links and symlinks in the -dev package
Sep 14 2023, 9:21 AM
dfr closed D41841: pkgbase: put library links and symlinks in the -dev package.
Sep 14 2023, 9:20 AM

Sep 13 2023

dfr updated subscribers of D41844: Add an implementation of the 9P filesystem.

Thanks for working on this - I also tried to get it to work a few years ago but didn't get too far. It looks like this includes the fix to the uninitialized variable that I ran into (https://github.com/arichardson/cheribsd/commits/virtfs-cheribsd) so I think all of my fixes from back then are included.

Sep 13 2023, 3:59 PM
dfr added a comment to D41844: Add an implementation of the 9P filesystem.

Is there a reason why you use p9fs in a bunch of places rather than 9pfs? It’s called 9P not P9.

Sep 13 2023, 2:11 PM
dfr requested review of D41844: Add an implementation of the 9P filesystem.
Sep 13 2023, 12:34 PM
dfr updated the diff for D41841: pkgbase: put library links and symlinks in the -dev package.

Use a new variable, LINKTAGS, to make the interface between bsd.lib.mk and bsd.links.mk clearer.

Sep 13 2023, 11:03 AM
dfr added a comment to D41841: pkgbase: put library links and symlinks in the -dev package.

I wonder if something like LINKTAGS=dev and then

.if defined(LINKTAGS)
        ${INSTALL_LINK} ${TAG_ARGS:D${TAG_ARGS},${LINKTAGS}} ${DESTDIR}${s} ${DESTDIR}${t}

is more clear?

Sep 13 2023, 10:45 AM
dfr requested review of D41841: pkgbase: put library links and symlinks in the -dev package.
Sep 13 2023, 10:23 AM

Sep 12 2023

dfr committed rG78847e1e5927: pkgbase: Move headers and libs out of runtime and utilities (authored by dfr).
pkgbase: Move headers and libs out of runtime and utilities
Sep 12 2023, 12:24 PM
dfr closed D41815: pkgbase: Move headers and libs out of runtime and utilities.
Sep 12 2023, 12:24 PM
dfr updated the diff for D41815: pkgbase: Move headers and libs out of runtime and utilities.

Remove build-essential, moving its dependencies to clang (except for
clibs-dev as discussed). Also move crt*.o from utilities to clibs-dev to
allow linking programs without needing to install utilities.

Sep 12 2023, 8:27 AM
dfr added a comment to D41815: pkgbase: Move headers and libs out of runtime and utilities.

On reflection, it seems clear that lld, libcompiler_rt-dev and the new clang-dev are needed for any meaningful use of clang and should probably be dependencies of the FreeBSD-clang package. I would like to keep clibs-dev separate though - clang doesn't require these to be installed, e.g. for embedded development and conversely, clibs-dev could be used with some other compiler. I will remove the metapackage and add new dependencies to clang. This would allow installing a functional toolchain with just 'pkg install FreeBSD-clang FreeBSD-clibs-dev' which seems reasonable.

Sep 12 2023, 7:10 AM

Sep 11 2023

dfr added a comment to D41815: pkgbase: Move headers and libs out of runtime and utilities.

Why doesn’t clang-dev depend on everything you need to build C/C++ binaries?

Sep 11 2023, 4:51 PM
dfr added a comment to D41815: pkgbase: Move headers and libs out of runtime and utilities.
In D41815#953113, @manu wrote:

I'm not sure about the build-essential meta package, we wanted to avoid adding this kind of package since the begining because we wanted to add the notion of pkg groups (metapackage at the repository level) for this.
Otherwise the rest looks good.

Sep 11 2023, 4:36 PM
dfr requested review of D41815: pkgbase: Move headers and libs out of runtime and utilities.
Sep 11 2023, 3:11 PM
dfr added a comment to D41439: netfront: fix the support for disabling LRO at boot time.

Would it be simpler to not set IFCAP_LRO in the if_setcapenable() call on create_netdev() if xn_enable_lro is false? I think that way we would avoid exposing feature-gso-tcpv4 on xenstore and you won't need to modify talk_to_backend().

Sep 11 2023, 10:14 AM
dfr updated the diff for D41439: netfront: fix the support for disabling LRO at boot time.

Rebased and simplified based on review feedback.

Sep 11 2023, 10:13 AM

Sep 2 2023

dfr committed rG973e6a6572d3: netstat(1): fix manpage date (authored by dfr).
netstat(1): fix manpage date
Sep 2 2023, 11:02 AM
dfr committed rG153a0e6b038c: netstat(1): teach netstat to attach to jails (authored by dfr).
netstat(1): teach netstat to attach to jails
Sep 2 2023, 11:02 AM

Aug 31 2023

dfr added a comment to D41607: devel/bazel*: fix build on 14.0-ALPHA3.

Any feedback or questions for this would be welcome - I need bazel5 to build to unblock building packages for podman and related ports.

Aug 31 2023, 3:31 AM

Aug 27 2023

dfr requested review of D41607: devel/bazel*: fix build on 14.0-ALPHA3.
Aug 27 2023, 1:06 PM

Aug 26 2023

dfr committed rGb5c4616582ce: Fix MNT_IGNORE for devfs, fdescfs and nullfs (authored by dfr).
Fix MNT_IGNORE for devfs, fdescfs and nullfs
Aug 26 2023, 2:32 PM
dfr requested review of D41603: allow mount(8) to set the MNT_IGNORE flag on a filesystem.
Aug 26 2023, 2:32 PM

Aug 24 2023

dfr committed R11:1e8393f74b6c: sysutils/podman-suite: update to 20230817 (authored by dfr).
sysutils/podman-suite: update to 20230817
Aug 24 2023, 3:24 PM
dfr closed D41490: Summary: Update podman, buildah and related ports to the latest versions..
Aug 24 2023, 3:24 PM
dfr committed R11:a1cc0bd7789e: sysutils/containers-common: update to 0.55.3 (authored by dfr).
sysutils/containers-common: update to 0.55.3
Aug 24 2023, 3:24 PM
dfr committed R11:e16f4bd70210: sysutils/buildah: update to 1.31.2 (authored by dfr).
sysutils/buildah: update to 1.31.2
Aug 24 2023, 3:24 PM
dfr committed R11:cb16608661e6: sysutils/skopeo: update to 1.13.2 (authored by dfr).
sysutils/skopeo: update to 1.13.2
Aug 24 2023, 3:24 PM
dfr committed R11:3f569b3f02c3: sysutils/podman: update to 4.6.1 (authored by dfr).
sysutils/podman: update to 4.6.1
Aug 24 2023, 3:24 PM
dfr committed R11:d1158a4601c1: sysutils/ocijail: update to 0.2.0 (authored by dfr).
sysutils/ocijail: update to 0.2.0
Aug 24 2023, 3:24 PM
dfr committed R11:be587fc5e9f4: net/containernetworking-plugins: update to 0.4 (authored by dfr).
net/containernetworking-plugins: update to 0.4
Aug 24 2023, 3:24 PM

Aug 21 2023

dfr retitled D41490: Summary: Update podman, buildah and related ports to the latest versions. from Summary: to Summary: Update podman, buildah and related ports to the latest versions..
Aug 21 2023, 3:21 PM

Aug 18 2023

dfr committed rGab3a78287800: pkgbase: move libcom_err from kerberos to kerberos-lib (authored by dfr).
pkgbase: move libcom_err from kerberos to kerberos-lib
Aug 18 2023, 2:12 PM

Aug 17 2023

dfr requested review of D41490: Summary: Update podman, buildah and related ports to the latest versions..
Aug 17 2023, 12:41 PM

Aug 16 2023

dfr added a comment to D41446: netstat(1): teach netstat to attach to jails.

late to the party, but the man page is missing a .Dd update.

Aug 16 2023, 2:15 PM
dfr committed rG3af3571ca5b8: netstat(1): fix manpage date (authored by dfr).
netstat(1): fix manpage date
Aug 16 2023, 2:15 PM
dfr committed rG182e8ae26d7c: netstat(1): teach netstat to attach to jails (authored by dfr).
netstat(1): teach netstat to attach to jails
Aug 16 2023, 1:06 PM
dfr closed D41446: netstat(1): teach netstat to attach to jails.
Aug 16 2023, 1:06 PM
dfr committed rG3af770071046: ifconfig(8): Teach ifconfig to attach and run itself in a jail (authored by nyan_myuji.xyz).
ifconfig(8): Teach ifconfig to attach and run itself in a jail
Aug 16 2023, 12:33 PM
dfr committed rG07cbc2f943ff: route(8): teach route to attach to jails (authored by nyan_myuji.xyz).
route(8): teach route to attach to jails
Aug 16 2023, 12:33 PM

Aug 15 2023

dfr added a comment to D41446: netstat(1): teach netstat to attach to jails.

The code change here is fairly straightforward and brings netstat in line with similar support in ifconfig and route. The manpage change is larger and it would be nice to get a review if possible. I know people are busy this week preparing for the stable/14 branch - I'll leave the review up for another day. If someone has time to give it a review then great, otherwise I'll commit anyway and we can fix any manpage issues as followups.

Aug 15 2023, 6:55 AM
dfr updated subscribers of D41439: netfront: fix the support for disabling LRO at boot time.

This looks plausible. Likely it mostly amounts to a debugging tool since you would basically never want this in anything approximating a real world situation.

Aug 15 2023, 6:48 AM

Aug 14 2023

dfr requested review of D41446: netstat(1): teach netstat to attach to jails.
Aug 14 2023, 9:17 AM

Aug 13 2023

dfr requested review of D41439: netfront: fix the support for disabling LRO at boot time.
Aug 13 2023, 10:26 AM
dfr added a comment to D40213: Teach ifconfig to attach and run itself in a jail..

Would there be any objection to me merging this change and the related change in D40377 to stable/13? It would make setting up container networking for containerd and nerdctl much simpler. For podman, it could also make networking more efficient - we currently use two jails per container with one solely used to own the container vnet while also allowing access to host networking tools.

Aug 13 2023, 10:15 AM

Aug 11 2023

dfr committed rG54cfeb848468: pkgbase: move libcom_err from kerberos to kerberos-lib (authored by dfr).
pkgbase: move libcom_err from kerberos to kerberos-lib
Aug 11 2023, 1:58 PM

Aug 5 2023

dfr committed rG1d7ffb373c9d: pkgbase: reorganise caroot and openssl packages (authored by dfr).
pkgbase: reorganise caroot and openssl packages
Aug 5 2023, 8:33 AM