Page MenuHomeFreeBSD

dfr (Doug Rabson)
User

Projects

User Details

User Since
Mar 7 2015, 6:48 PM (403 w, 6 d)

Recent Activity

Yesterday

dfr updated the diff for D37478: Add support for mounting single files in nullfs.

Split out vn_path_to_global_path_hardlink into its own commit.

Fri, Dec 2, 2:14 PM
dfr added a comment to D37568: Refresh the podman-suite parts with stability and functionality updates..

I changed from DISTVERSION to PORTVERSION so that the package versioning matches the compiled-in version numbers. The porter's handbook doesn't seem to discourage this, just noting that 'Only one of PORTVERSION and DISTVERSION can be set at a time.'

Fri, Dec 2, 1:53 PM

Thu, Dec 1

dfr updated the diff for D37568: Refresh the podman-suite parts with stability and functionality updates..

Update containernetworking-plugins so that portmap works with the example pf.conf from v0.1

Thu, Dec 1, 4:03 PM
dfr added inline comments to D37568: Refresh the podman-suite parts with stability and functionality updates..
Thu, Dec 1, 11:27 AM

Wed, Nov 30

dfr added a comment to D37478: Add support for mounting single files in nullfs.

I will also reach out to pho@ for advice on stress testing.

Wed, Nov 30, 5:00 PM
dfr updated the diff for D37478: Add support for mounting single files in nullfs.

Added a comment to note that vnode type validation happens in vfs_domount_first. Also fixed a couple of line-too-long formatting issues.

Wed, Nov 30, 4:59 PM
dfr requested review of D37568: Refresh the podman-suite parts with stability and functionality updates..
Wed, Nov 30, 3:54 PM

Tue, Nov 29

dfr added a comment to D37478: Add support for mounting single files in nullfs.

Added a couple of comments above

Tue, Nov 29, 8:38 AM
dfr added a comment to D37478: Add support for mounting single files in nullfs.
In D37478#853071, @mjg wrote:
In D37478#852960, @dfr wrote:
In D37478#852943, @mjg wrote:

The invocation suggested is definitely a problem: sudo mount -t nullfs /COPYRIGHT /mnt/foo

should someone try to mount a regular file by accident on stock system their attempt is going to fail, patched one will succeed when it should not have.

I think there should be an explicit option (say -o regfile or similar) which would *require* the target to be VREG when used, VDIR otherwise.

I'm not sure what the problem is here. Assuming that /mnt/foo is a regular file, why should the example mount fail? Surely the checks to enforce that the two objects are either both file or both directory is sufficient.

I mean they made a mistake and with your patch it will happen to "work" even though it is not what was meant.

Tue, Nov 29, 8:35 AM

Mon, Nov 28

dfr updated the diff for D37478: Add support for mounting single files in nullfs.

Add vn_path_to_global_path_hardlink. This works for trivial tests and makes
the code in vfs_domount more readable. I'll update my podman test VM and
stress test it a little.

Mon, Nov 28, 4:06 PM
dfr added a comment to D37478: Add support for mounting single files in nullfs.
In D37478#852943, @mjg wrote:

The invocation suggested is definitely a problem: sudo mount -t nullfs /COPYRIGHT /mnt/foo

should someone try to mount a regular file by accident on stock system their attempt is going to fail, patched one will succeed when it should not have.

I think there should be an explicit option (say -o regfile or similar) which would *require* the target to be VREG when used, VDIR otherwise.

Mon, Nov 28, 3:02 PM
dfr updated the diff for D37478: Add support for mounting single files in nullfs.

Updated to include requested changes. I'm still working on a regular-file equivalent to vn_path_to_global_path.

Mon, Nov 28, 3:02 PM
dfr added a comment to D37478: Add support for mounting single files in nullfs.

I have tested this with my main use-cases (podman and buildah) and simple tests are working. I plan to run some of the podman integration tests to get a better signal.

Mon, Nov 28, 1:19 PM
dfr updated the diff for D37478: Add support for mounting single files in nullfs.

THere were a couple of places in vfs_cache.c which assumed that mount
points are directories and paniced if they were files. I relaxes these
checks to allow file mounts.

Mon, Nov 28, 1:04 PM

Wed, Nov 23

dfr added a comment to D37478: Add support for mounting single files in nullfs.

This is a work in progress but I wanted a sanity check for the changes to vfs_mount.c while I figure out how to write ATF tests for it.

Wed, Nov 23, 4:41 PM
dfr requested review of D37478: Add support for mounting single files in nullfs.
Wed, Nov 23, 4:35 PM

Tue, Nov 22

dfr committed R11:97c61edd72e1: sysutils/ocijail: disable build for 12.x (authored by dfr).
sysutils/ocijail: disable build for 12.x
Tue, Nov 22, 11:13 AM

Fri, Nov 18

dfr added a comment to D37432: imgact_binmisc: Optionally pre-open the interpreter vnode.

I added a new field to struct image_args. Since this was added to the end of the structure, it should make it possible to MFC to stable/13 since the structure is owned and zeroed by do_execve and any imgact modules should not be affected.

Fri, Nov 18, 3:33 PM
dfr requested review of D37432: imgact_binmisc: Optionally pre-open the interpreter vnode.
Fri, Nov 18, 3:11 PM

Thu, Nov 10

dfr added inline comments to D37324: PR: 267184.
Thu, Nov 10, 1:20 PM

Fri, Nov 4

dfr accepted D37256: include: put includes into -dev packages.

Looks good to me.

Fri, Nov 4, 10:52 AM

Nov 1 2022

dfr committed rGc7631f9153b7: libc_nonshared: Move to clibs package (authored by dfr).
libc_nonshared: Move to clibs package
Nov 1 2022, 10:18 AM

Aug 19 2022

dfr committed rGf5bbed62172b: pkgbase: split kerberos binaries and libs (authored by dfr).
pkgbase: split kerberos binaries and libs
Aug 19 2022, 1:28 PM
dfr committed rG55f186a13a4f: Move sort to runtime (authored by dfr).
Move sort to runtime
Aug 19 2022, 1:28 PM

Aug 3 2022

dfr committed rG6e4dbb7feff4: pkgbase: split kerberos binaries and libs (authored by dfr).
pkgbase: split kerberos binaries and libs
Aug 3 2022, 10:05 AM
dfr closed D36028: pkgbase: split kerberos binaries and libs.
Aug 3 2022, 10:04 AM
dfr updated the diff for D36028: pkgbase: split kerberos binaries and libs.

FIx a typo in Makefie.packages

Aug 3 2022, 9:28 AM
dfr updated the diff for D36028: pkgbase: split kerberos binaries and libs.

Add an example use-case for kerberos-lib to the commit message.

Aug 3 2022, 9:21 AM
dfr updated the diff for D36028: pkgbase: split kerberos binaries and libs.

Updated Makefile.package to add entries for kerberos-lib

Aug 3 2022, 8:59 AM
dfr added reviewers for D36028: pkgbase: split kerberos binaries and libs: manu, bapt, emaste.
Aug 3 2022, 7:15 AM
dfr requested review of D36028: pkgbase: split kerberos binaries and libs.
Aug 3 2022, 7:11 AM

Jul 29 2022

dfr committed rG0c19c4db74aa: Move sort to runtime (authored by dfr).
Move sort to runtime
Jul 29 2022, 10:30 AM

Jun 17 2022

dfr accepted D35511: kldload: Bring functionality in line with manual page.

LGTM

Jun 17 2022, 2:48 PM

Jun 13 2022

dfr committed rG2dfa77ed7051: pkgbase: Move pw to the runtime package (authored by dfr).
pkgbase: Move pw to the runtime package
Jun 13 2022, 10:05 AM

May 30 2022

dfr committed rG5e9c888a7ac0: pkgbase: Move pw to the runtime package (authored by dfr).
pkgbase: Move pw to the runtime package
May 30 2022, 2:26 PM

Sep 11 2021

dfr committed rG895545d0e666: Fix spelling of BUILDENV_SHELL (authored by dfr).
Fix spelling of BUILDENV_SHELL
Sep 11 2021, 12:28 PM

Dec 13 2020

dfr committed R9:333fd3a604a6: Document how to debug LKMs with kgdb. (authored by dfr).
Document how to debug LKMs with kgdb.
Dec 13 2020, 8:11 PM
dfr committed R9:41c864a80da8: Add Andrew Gallatin <gallatin@cs.duke.edu> for his work on the alpha kernel. (authored by dfr).
Add Andrew Gallatin <gallatin@cs.duke.edu> for his work on the alpha kernel.
Dec 13 2020, 8:02 PM
dfr committed R9:626f20bbab89: Add my pgp key to the handbook. (authored by dfr).
Add my pgp key to the handbook.
Dec 13 2020, 7:35 PM
dfr committed R9:77b86cec46b5: Add documentation for __FreeBSD_version 500043. (authored by dfr).
Add documentation for __FreeBSD_version 500043.
Dec 13 2020, 7:15 PM
dfr committed R9:83ff4e1a13a1: Add entry for kobj multiple inheritance. (authored by dfr).
Add entry for kobj multiple inheritance.
Dec 13 2020, 6:57 PM
dfr committed R9:09467af01a9f: Update for __FreeBSD_version bump to 700103: Adding l_sysid to struct flock (authored by dfr).
Update for __FreeBSD_version bump to 700103: Adding l_sysid to struct flock
Dec 13 2020, 5:51 PM
dfr committed R9:26f614034847: Document __FreeBSD_version 603102. (authored by dfr).
Document __FreeBSD_version 603102.
Dec 13 2020, 5:50 PM
dfr committed R9:01ecd25073ce: Add description for __FreeBSD_version 800040 (authored by dfr).
Add description for __FreeBSD_version 800040
Dec 13 2020, 5:48 PM
dfr committed R9:6bdb4273b279: Add entry for MFC of NFS advisory locking. (authored by dfr).
Add entry for MFC of NFS advisory locking.
Dec 13 2020, 5:47 PM
dfr committed R9:0ea2d8fde819: Update my pgp key to something slightly more recent. (authored by dfr).
Update my pgp key to something slightly more recent.
Dec 13 2020, 5:39 PM

Jun 22 2020

dfr committed rS362490: Add some missing parts for supporting va_birthtime..
Add some missing parts for supporting va_birthtime.
Jun 22 2020, 8:23 AM

Jun 15 2020

dfr accepted D14210: Rationalize license test on Linuxolator files.

Not sure if this is still active, approving anyway.

Jun 15 2020, 5:41 PM
dfr resigned from D4201: Allow quoted user/group names in exports file.
Jun 15 2020, 5:40 PM
dfr resigned from D6254: NFS remove: Send the remove RPC when a vnode is in-use with more than 1 link..
Jun 15 2020, 5:31 PM

Jun 14 2020

dfr committed rS362175: Add support for the timecreate attribute.
Add support for the timecreate attribute
Jun 14 2020, 11:42 AM

Feb 3 2019

dfr committed rS343706: Reduce log spam from rpc.statd.
Reduce log spam from rpc.statd
Feb 3 2019, 8:15 AM

Sep 30 2017

dfr accepted D12547: Remove an unneeded and incorrect memset()..

Looks good to me.

Sep 30 2017, 9:31 AM

Apr 25 2017

dfr committed rS317402: Fix a potential problem where we might try to shift by more than 31 bits.
Fix a potential problem where we might try to shift by more than 31 bits
Apr 25 2017, 10:29 AM

May 8 2016

dfr added a comment to D6254: NFS remove: Send the remove RPC when a vnode is in-use with more than 1 link..

I think the patch is probably ok. As you point out, it does open a race where some other client can remove the file while we still have it open but its not clear how likely that is in the real world.

May 8 2016, 8:23 AM

Feb 1 2016

dfr accepted D5146: kcrypto_aes: Use separate sessions for AES and SHA1.

Looks good to me.

Feb 1 2016, 11:12 AM

Jan 31 2016

dfr added inline comments to D5146: kcrypto_aes: Use separate sessions for AES and SHA1.
Jan 31 2016, 4:51 PM

Jan 4 2016

dfr committed rS293168: Fix a memory leak in gss_release_oid_set.
Fix a memory leak in gss_release_oid_set
Jan 4 2016, 5:42 PM

May 10 2015

dfr added a comment to D2506: Mount option to set high order mnt_flag bits.

I know I suggested adding an option for the high flag bits but now I wonder if it would be cleaner to just have all 64 bits of flags in an option which would be or'ed with the flags argument from nmount. This would cut out most of the bit masking.

May 10 2015, 2:40 PM

Apr 25 2015

dfr committed rD46593: Update PGP key.
Update PGP key
Apr 25 2015, 11:45 AM

Mar 28 2015

dfr accepted D2165: Remove antique hard-coded limit and integer overflow bugs in kernel RPC request throttling code.

Sounds good to me.

Mar 28 2015, 8:29 PM