This also adds catatonit as a run-time dependancy since it is needed to
support 'podman pod'.
Details
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 62282 Build 59166: arc lint + arc unit
Event Timeline
The patch introduces new dependency - sysutils/catatonit; the current version in the ports tree is 0.1.7, latest one is 0.2.1. Is there any plans to update the port to the recent version?
Also, RUN_DEPENDS list will look better when it sorted out, i.e.:
RUN_DEPENDS= buildah>=0:sysutils/buildah \ catatonit>=0:sysutils/catatonit \ podman>=0:sysutils/podman \ skopeo>=0:sysutils/skopeo
There're two spaces after buildah work in RUN_DEPENDS section, one of those can be safely removed.
Here's the patch{F109555392}
I've taken a look on the version 0.2.1 of the catatonit. Your patches in the freebsd branch look good, however there's a small change in the distribution:
--- catatonit.c +++ catatonit.c -#ifdef HAVE_CLOSE_RANGE +#ifdef HAVE_LINUX_CLOSE_RANGE_H
So, I've applied both of your patches, fix the rejection and built new version. Hope that can be updated as well.
Combined your patches into one here.
I'm currently building this from my fork of catatonit - the upstream seemed dormant when I did the port. Since then, there clearly has been some activity upstream so I will update my fork and look into the possibility of getting the FreeBSD support upstream. Looking at the changes between 0.1.7 and 0.2.1, I don't think there is a problem staying with 0.1.7 for now though.
Thanks for this - I will incorporate this into my fork and make a new review for catatonit.
After further testing, I came across a regression in 'podman build' and 'buildah build' which I will get fixed upstream (https://github.com/containers/common/pull/2326). I will add that as patches to the buildah and podman ports and test a bit more before I ship this.