Page MenuHomeFreeBSD

net/containernetworking-plugins: use correct family during rule generation
ClosedPublic

Authored by dch on Sat, Jun 14, 5:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 7, 4:09 PM
Unknown Object (File)
Mon, Jul 7, 3:52 AM
Unknown Object (File)
Sun, Jul 6, 10:24 AM
Unknown Object (File)
Sun, Jul 6, 10:23 AM
Unknown Object (File)
Sun, Jul 6, 10:23 AM
Unknown Object (File)
Sun, Jul 6, 10:23 AM
Unknown Object (File)
Sat, Jul 5, 7:31 AM
Unknown Object (File)
Fri, Jul 4, 3:52 PM
Subscribers

Details

Reviewers
dfr
dch
Summary

PR: 287196
Tested by: Bretton Vine <bv@honeyguide.eu>
Sponsored by: SkunkWerks, GmbH

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64884
Build 61767: arc lint + arc unit

Event Timeline

dch requested review of this revision.Sat, Jun 14, 5:09 PM
dch created this revision.

fix family alignment in rule generation and skip cross-family rules

dfr added a subscriber: dfr.

Looks good to me and works in my testing. It would be helpful if you could also make a pull request for github.com/dfr/plugins which is the upstream for this port (my fork of the CNI plugins).

This revision is now accepted and ready to land.Mon, Jun 16, 2:55 PM

Let's upstream this first and then I can just bump the port.

What is the branch from your https://github.com/dfr/plugins ?
There's no matching branch compared to what the ports tree fetches

{F120368428}

In D50847#1161816, @dch wrote:

Let's upstream this first and then I can just bump the port.

What is the branch from your https://github.com/dfr/plugins ?
There's no matching branch compared to what the ports tree fetches

{F120368428}

It's the freebsd branch - the port is fetching the freebsd-v0.5 tag which somehow wasn't pushed to the freebsd branch (it was present in my local git repo). Not sure how it was fetchable from github - I think I must have pushed the tag up to github but not the branch. It should make sense now that I have pushed the branch.