Page MenuHomeFreeBSD
Differential D50847

net/containernetworking-plugins: use correct family during rule generation
ClosedPublic
Actions

Authored by dch on Jun 14 2025, 5:09 PM.
Tags
None
Referenced Files
F164576727: D50847.id157055.diff
Sun, Aug 2, 4:28 AM
F164565336: D50847.id157024.diff
Sun, Aug 2, 3:10 AM
F164561013: D50847.id157054.diff
Sun, Aug 2, 2:39 AM
F164545151: D50847.id157053.diff
Sun, Aug 2, 12:46 AM
F164533887: D50847.id157055.diff
Sat, Aug 1, 9:51 PM
F164518699: D50847.id.diff
Sat, Aug 1, 4:57 PM
Unknown Object (File)
Sat, Aug 1, 1:37 PM
Unknown Object (File)
Sat, Aug 1, 5:32 AM
View All Files
Subscribers
dfr

Details

Reviewers
dfr
dch
Summary

PR: 287196
Tested by: Bretton Vine <bv@honeyguide.eu>
Sponsored by: SkunkWerks, GmbH

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64883
Build 61766: arc lint + arc unit

Event Timeline

dch requested review of this revision.Jun 14 2025, 5:09 PM
dch created this revision.
Harbormaster completed remote builds in B64865: Diff 157024.Jun 14 2025, 5:09 PM
dch updated this revision to Diff 157053.Jun 14 2025, 10:34 PM

fix family alignment in rule generation and skip cross-family rules

Harbormaster completed remote builds in B64882: Diff 157053.Jun 14 2025, 10:34 PM
dch updated this revision to Diff 157054.Jun 14 2025, 10:53 PM

tidy up patch

Harbormaster completed remote builds in B64883: Diff 157054.Jun 14 2025, 10:53 PM
dch updated this revision to Diff 157055.Jun 14 2025, 11:00 PM

fix map error

Harbormaster completed remote builds in B64884: Diff 157055.Jun 14 2025, 11:00 PM
dfr accepted this revision.Jun 16 2025, 2:55 PM
dfr added a subscriber: dfr.

Looks good to me and works in my testing. It would be helpful if you could also make a pull request for github.com/dfr/plugins which is the upstream for this port (my fork of the CNI plugins).

This revision is now accepted and ready to land.Jun 16 2025, 2:55 PM
dch accepted this revision.Jun 17 2025, 10:05 AM

Let's upstream this first and then I can just bump the port.

What is the branch from your https://github.com/dfr/plugins ?
There's no matching branch compared to what the ports tree fetches

{F120368428}

dfr added a comment.Jun 17 2025, 12:37 PM
In D50847#1161816, @dch wrote:

Let's upstream this first and then I can just bump the port.

What is the branch from your https://github.com/dfr/plugins ?
There's no matching branch compared to what the ports tree fetches

{F120368428}

It's the freebsd branch - the port is fetching the freebsd-v0.5 tag which somehow wasn't pushed to the freebsd branch (it was present in my local git repo). Not sure how it was fetchable from github - I think I must have pushed the tag up to github but not the branch. It should make sense now that I have pushed the branch.

dch closed this revision.Jun 18 2025, 10:58 PM

fixed in d2fd973c7d34

Revision Contents
Changeset List

PathSize
net/
containernetworking-plugins/
2 lines
files/
61 lines

Diff 157054

View Options

net/containernetworking-plugins/Makefile

Loading...
View Options

net/containernetworking-plugins/files/patch-plugins_freebsd_meta_portmap_portmap.go

Loading...