Page MenuHomeFreeBSD
Differential D39585

procctl: add state flags to PROC_REAP_GETPIDS reports
ClosedPublic
Actions

Authored by val_packett.cool on Apr 15 2023, 6:03 PM.
Tags
None
Referenced Files
F160578741: D39585.id.diff
Thu, Jun 25, 9:04 PM
Unknown Object (File)
Wed, Jun 24, 5:09 AM
Unknown Object (File)
Tue, Jun 23, 4:09 PM
Unknown Object (File)
Tue, Jun 23, 5:40 AM
Unknown Object (File)
Wed, Jun 17, 2:27 AM
Unknown Object (File)
Mon, Jun 15, 5:07 PM
Unknown Object (File)
Thu, Jun 4, 2:27 PM
Unknown Object (File)
Thu, Jun 4, 2:26 PM
View All Files
Subscribers
ihor_antonovs.family
imp

Details

Reviewers
kib
Group Reviewers
Contributor Reviews (src)
Commits
rG77f0e198d913: procctl: add state flags to PROC_REAP_GETPIDS reports
Summary

For a process supervisor using the reaper API to track process subtrees,
it is very useful to know which processes on the list are zombies.

Sponsored by: https://www.patreon.com/valpackett

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

val_packett.cool created this revision.Apr 15 2023, 6:03 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 15 2023, 6:03 PM
val_packett.cool requested review of this revision.Apr 15 2023, 6:03 PM
Harbormaster completed remote builds in B50923: Diff 120368.Apr 15 2023, 6:03 PM
val_packett.cool added reviewers: Contributor Reviews (src), kib.Apr 15 2023, 6:05 PM
kib added a comment.Apr 15 2023, 7:12 PM

I do not object. IMO it would make sense to also report stopped and exiting processes too?

val_packett.cool updated this revision to Diff 120374.Apr 15 2023, 8:06 PM

Yeah, agreed.

BTW, is the only difference between P_WEXIT and zombie state is that P_WEXIT gets set earlier in the process?

Harbormaster completed remote builds in B50924: Diff 120374.Apr 15 2023, 8:06 PM
val_packett.cool retitled this revision from procctl: add a REAPER_PIDINFO_ZOMBIE flag to PROC_REAP_GETPIDS reports to procctl: add state flags to PROC_REAP_GETPIDS reports.Apr 15 2023, 8:07 PM
ihor_antonovs.family added a subscriber: ihor_antonovs.family.Apr 15 2023, 8:22 PM
kib added a comment.Apr 15 2023, 8:59 PM
In D39585#901149, @val_packett.cool wrote:

BTW, is the only difference between P_WEXIT and zombie state is that P_WEXIT gets set earlier in the process?

P_WEXIT processes are not zombies (sometimes).

sys/kern/kern_procctl.c
242

Note that P_WEXIT is kept even for zombies, the flag is not cleared on transition. Perhaps it makes sense to not set EXITING flag for processes that already exited.

val_packett.cool updated this revision to Diff 120379.Apr 15 2023, 9:04 PM

Yeah, I guess it would make sense to only report "exiting" when not yet exited.

Harbormaster completed remote builds in B50928: Diff 120379.Apr 15 2023, 9:05 PM
kib accepted this revision.Apr 15 2023, 9:14 PM

Please mail me git-formatted patch with all metadata. Also please bump the man page date.

This revision is now accepted and ready to land.Apr 15 2023, 9:14 PM
Closed by commit rG77f0e198d913: procctl: add state flags to PROC_REAP_GETPIDS reports (authored by val_packett.cool, committed by kib). · Explain WhyApr 16 2023, 10:49 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG77f0e198d913: procctl: add state flags to PROC_REAP_GETPIDS reports.

Revision Contents
Changeset List

PathSize
lib/
libc/
sys/
10 lines
sys/
kern/
6 lines
sys/
3 lines

Diff 120392

View Options

lib/libc/sys/procctl.2

Loading...
View Options

sys/kern/kern_procctl.c

Loading...
View Options

sys/sys/procctl.h

Loading...