Page MenuHomeFreeBSD

acpi_cros_kblt: New driver for Chromebook keyboard backlight control
Needs ReviewPublic

Authored by on Sep 21 2019, 10:02 PM.
Referenced Files
Unknown Object (File)
Wed, May 24, 12:31 AM
Unknown Object (File)
Mon, May 22, 2:10 PM
Unknown Object (File)
Mon, May 22, 2:09 PM
Unknown Object (File)
Fri, May 19, 12:06 PM
Unknown Object (File)
Tue, May 9, 10:50 PM
Unknown Object (File)
May 7 2023, 11:53 AM
Unknown Object (File)
May 3 2023, 3:07 AM
Unknown Object (File)
Apr 7 2023, 7:43 AM


Group Reviewers
Contributor Reviews (src)

Allows adjusting keyboard backlight level on amd64 Chromebooks, restores it on resume from sleep.

Sponsored by:
Test Plan

Tested on: Google Pixelbook (eve)

Diff Detail

rG FreeBSD src repository
Lint Skipped
Tests Skipped
Build Status
Buildable 49520
Build 46410: arc lint + arc unit

Event Timeline

I was going to suggest adding the devmatch changes, but no other ACPI driver seems to have them yet, so I can do that in a sweep.

This revision is now accepted and ready to land.Sep 21 2019, 10:15 PM

Yeah, I was wondering about devmatch in D21612 edited the summary of this revision. (Show Details) added a reviewer: manu.
  • Use backlight(9) subsystem
  • Add SPDX tag
  • Some formatting changes

@imp how's the ACPI devmatch work? :)

This revision now requires review to proceed.Mar 31 2021, 7:02 PM

Oops, with git now, we don't need $FreeBSD$ in the Makefile either

Add man page and sys/conf/files entry

Can this driver generate org.freedesktop.UPower.KbdBacklight events ?

Can this driver generate org.freedesktop.UPower.KbdBacklight events ?

That's not a kernel thing, that can't be done *here*. upowerd needs integration with the backlight(9) system. But I think backlight(9) currently doesn't have event notifications. I'll look into that, but that's unrelated to drivers for particular hardware :)