Page MenuHomeFreeBSD

acpi_cros_kblt: New driver for Chromebook keyboard backlight control
Needs ReviewPublic

Authored by val_packett.cool on Sep 21 2019, 10:02 PM.
Tags
None
Referenced Files
F88386857: D21746.diff
Sun, Jul 14, 4:40 PM
F88348374: D21746.diff
Sun, Jul 14, 4:50 AM
Unknown Object (File)
Fri, Jul 12, 7:04 PM
Unknown Object (File)
Mon, Jul 8, 7:17 AM
Unknown Object (File)
Fri, Jul 5, 9:00 AM
Unknown Object (File)
Wed, Jun 26, 5:30 PM
Unknown Object (File)
Tue, Jun 25, 5:59 PM
Unknown Object (File)
Fri, Jun 14, 9:33 PM

Details

Reviewers
imp
manu
Group Reviewers
Contributor Reviews (src)
desktop
Summary

Allows adjusting keyboard backlight level on amd64 Chromebooks, restores it on resume from sleep.

Sponsored by: https://www.patreon.com/valpackett
Test Plan

Tested on: Google Pixelbook (eve)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49520
Build 46410: arc lint + arc unit

Event Timeline

I was going to suggest adding the devmatch changes, but no other ACPI driver seems to have them yet, so I can do that in a sweep.

This revision is now accepted and ready to land.Sep 21 2019, 10:15 PM

Yeah, I was wondering about devmatch in D21612

val_packett.cool edited the summary of this revision. (Show Details)
val_packett.cool added a reviewer: manu.
  • Use backlight(9) subsystem
  • Add SPDX tag
  • Some formatting changes

@imp how's the ACPI devmatch work? :)

This revision now requires review to proceed.Mar 31 2021, 7:02 PM

Oops, with git now, we don't need $FreeBSD$ in the Makefile either

Add man page and sys/conf/files entry

Can this driver generate org.freedesktop.UPower.KbdBacklight events ?

Can this driver generate org.freedesktop.UPower.KbdBacklight events ?

That's not a kernel thing, that can't be done *here*. upowerd needs integration with the backlight(9) system. But I think backlight(9) currently doesn't have event notifications. I'll look into that, but that's unrelated to drivers for particular hardware :)