@bdrewery, take a look on this approach as well.

diff -l works for me as-is as intended:

Code is fine, some finishing touches are needed.

stable/13 goes EOL today, a good day to merge this PR. :)

JFYI. This patch (with the one from D54763) can be applied and compiled "as-is" to stable/13 and stable/12 branches resulting a working /sbin/ipfw15 binary.

We had a number talks about the way we should provide backward compatibility for ipfw. These options include (but not limited to):

• implement netlink control interface instead of KBI (see pfctl)
• backport new KBI to older branches (see D54763)
• keep compat KBI using compat module (as per this differential)

Warning is muted for jails now

implement compatibility layer for earlier/historical jails

not in this proposal I guess.

I've updated patch to minimize kernel logging errors similar to ipfw: ipfw_ctl3 invalid option 116v0 while detection is done. Unless we're not in a jail, value reported by getosreldate() is used as-is.

You don't need a special sysctl for that.

@cperciva can you please take a look on this fix? It is designed to be direct-committed into stable/14 and release/14.3.

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291562 for other approaches seen in the wild.

Removed stat() checks, added execv() error reporting

Added tests: both opcode checking and real traffic.

Is it possible to substitute all sleep 5 in this test with a loop

Reworked diff to get rid of long sleeps, now all NDP-related tests wait for DAD to finish in wait_tentative()

Test for temp record is included into https://reviews.freebsd.org/D53299

In D49459#1213490, @zarychtam_plan-b.pwste.edu.pl wrote:

Are the tests that hard to add, or perhaps can it be proceeded with further without them?

In D52120#1192351, @emaste wrote:

Ok, I can commit. @lytboris_gmail.com please confirm Boris Lytochkin <lytboris@gmail.com> as the git --author.

LGTM

Thanks for these patches, a long-waited change as for me. There are some minor things to fix and we're good to go.

Upated ipfw.8, fix some mandoc -T lint warnings.