Differential D21746

acpi_cros_kblt: New driver for Chromebook keyboard backlight control
AcceptedPublic
Actions

Authored by greg_unrelenting.technology on Sep 21 2019, 10:02 PM.

Details

Reviewers

imp

Group Reviewers

Contributor Reviews (base)

Summary

Allows adjusting keyboard backlight level on Chromebooks, restores it on resume from sleep.

Test Plan

Tested on: Google Pixelbook (eve)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

greg_unrelenting.technology created this revision.Sep 21 2019, 10:02 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 21 2019, 10:02 PM

I was going to suggest adding the devmatch changes, but no other ACPI driver seems to have them yet, so I can do that in a sweep.

This revision is now accepted and ready to land.Sep 21 2019, 10:15 PM

Yeah, I was wondering about devmatch in D21612

greg_unrelenting.technology mentioned this in D26250: Add backlight subsystem.Sep 4 2020, 5:19 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpi_support/

acpi_cros_kblt.c

159 lines

modules/

acpi/

acpi_cros_kblt/

Makefile

7 lines

Diff 62405

View Options

sys/dev/acpi_support/acpi_cros_kblt.c