Page MenuHomeFreeBSD

x86: Create manpage for mca subsystem
ClosedPublic

Authored by jtl on Dec 7 2025, 10:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 22, 5:44 PM
Unknown Object (File)
Sat, Jan 17, 5:37 AM
Unknown Object (File)
Fri, Jan 16, 8:23 PM
Unknown Object (File)
Thu, Jan 15, 6:07 PM
Unknown Object (File)
Thu, Jan 15, 1:10 PM
Unknown Object (File)
Thu, Jan 15, 12:22 PM
Unknown Object (File)
Thu, Jan 15, 12:20 PM
Unknown Object (File)
Wed, Jan 14, 11:59 AM
Subscribers

Details

Summary

Create a manpage for the mca subsystem.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jtl requested review of this revision.Dec 7 2025, 10:43 PM
share/man/man4/mca.4
6

We no longer need to write this, see

https://docs.freebsd.org/en/articles/license-guide/

28

We dropped i386. You're not going to back port this, right? Thus this is only for amd64?

Updated license and clarified this is only applicable to amd64 in main.

jtl marked 2 inline comments as done.Dec 8 2025, 3:49 PM
jtl added inline comments.
share/man/man4/mca.4
6

Thanks! I've updated the license text.

28

I updated this to amd64. I may actually backport this, but I can modify it as part of the MFC. There may be other changes which are needed as part of any MFC.

Thanks for writing this.

I wonder how to make the page more discoverable. I'd think we should have platform-specific man pages which describe platform features, so amd64.4 could link to mca.4, pkru.3, etc.. But that's a larger project of course.

share/man/man4/mca.4
22
33

Should we mention the syslog facility/level?

This revision is now accepted and ready to land.Dec 14 2025, 4:14 PM
share/man/man4/mca.4
33

I would perhaps say "the system log" rather than "Syslog".

65–67

This language will probably read less stale in the more distant future.

68
79

You don't have to, but if you would find it more readable, you could create a table with columns instead of a tagged list. See for example bhyve_config(5) which uses separate columns for the default value and description. siginfo(3) is another manual page that uses a .Bl -column.

In this case I could imagine a column for the name, one for if the sysctl is writable (Y/N), one for the default value, and the last for the description.

102

I don't know that Haswell needs to be quoted here?

267

Maybe Xr syslogd(8) here?

Not sure if it's worth adding a mention of mcelog in ports? (I'm not convinced mcelog is very useful)

jtl marked 9 inline comments as done.Mon, Jan 12, 7:28 PM
jtl added inline comments.
share/man/man4/mca.4
33

I added the facility. The level varies with the message. I also tried to strike a compromise between your suggestion and @jhb's suggestion:
"The system log (using the LOG_KERN syslog (3) facility)"

79

Thanks for the suggestion. I can see the value of this, but I think I will leave it the way it is at the moment. I'm concerned that using a table would hurt readability. I have added commentary around the meaning of the default values. I also would add another column to indicate whether it is available as a tunable. With all of that, I'm concerned that the main text would have too narrow a column.

Updated to incorporate review feedback.

This revision now requires review to proceed.Mon, Jan 12, 7:29 PM
This revision is now accepted and ready to land.Wed, Jan 14, 2:22 PM
This revision was automatically updated to reflect the committed changes.

I tried to test this, but the patch failed to apply

share/man/man4/mca.4
12

... Should we do this, so people find this page if they search the manual for x86? I don't know if they would or not.