In D56517#1294491, @rosenfeld_grumpf.hope-2000.org wrote:

There's currently four individual definitions of __maybe_unused the source tree, I'm just moving them to a central place as suggested by Ed.

Since we have [[maybe_unused]] in C23, could you elaborate why we need this to be in <sys/cdefs.h>?

LGTM

@koinec_yahoo.co.jp Could you please work on intelhfi based on this patch series?

Two things to add:

Reflect moving sysctl in parent revision

Move sysctl

Changes from D56547:

I overhauled the implementation which has quite different from this change. Superseded by D56546.

Duplicate of D56548 created by arc bug.

Display message on success

update commit message

update commit message

Since D56250 has changed to accomodate full dumps as well, rename this utility to dump2elf and update code and man page accordingly.

The point of this feature is to facilitate cross-platform debugging, thus this needs to accept full dumps as well. As a result, the name has changed from kvm_minidump_to_elf() to kvm_convert_to_elf(). Live kernel (/dev/mem) is still unsupported since kvm_walk_pages() doesn't work for that.

Use kvm_openfiles() instead

Duplicate of D56256.

update copyright notice

In D54674#1293419, @koinec_yahoo.co.jp wrote:

Also, based on my impression of the design of this module, do you have any ideas or approaches for integrating it into sched_ule?

Fix typo in license header

reflect @bz's suggestion on commit message

make hmp optional

In D44455#1287237, @koinec_yahoo.co.jp wrote:

Regarding the modification to save the acquired score values ​​from struct cpu_group to pcpu, I'd like to use the HMP (https://reviews.freebsd.org/D54674) API rather than creating a new, intelhfi's specific variable in pcpu for saving the values.
Are there any problems with this approach? If so, please let me know.

Rebase and fix

For now, let's share hmp_score_t for both capacity and score (same for macros like HMP_SCORE_SCALE). When we need to separate them (e.g. we confront architecture that has different type expectation for score and capacity), we can add capacity-specific types and values.

I think I'm not qualified for MFV: someone with trust (= commit bit) in the community should take this work instead.

Abandoning in favour of D56250 and D56256

Author isn't working on this anymore so I'm taking control of this revision.

Add coauthorship

This is improvement for D19253, but I moved this to libkvm so utilities like savecore(8) can invoke this easily.

After some considerations, I decided to abandon this revision based on the fact that kgdb(1) is a port and not in the base system. This means that if there is a need for this script, it should be provided via ports not through the base system. Also, I haven't heard any voice that wants this so it seems I'm trying to solve a problem that doesn't exist for now.

After talk with other FreeBSD dev at AsiaBSDCon, we concluded that score should be stored in pcpu structure, not in cpu_group for the following reasons:

LGTM, although we need approval from committer.

LGTM

Could you rebase main?

Could you rebase main?

In D44456#1277852, @koinec_yahoo.co.jp wrote:

In D44456#1272317, @minsoochoo0122_proton.me wrote:

Can we enable/disable the whole module when one or both of HMP and SMP aren't enabled? I don't see why we need to build this driver when HMP and SMP don't exist.

Thank you for the advice.
As you advised, there's no need to build this driver without specifying the SMP option, so I removed "#if defined(SMP)".

However, to prevent accidental builds, I've added a build error using "#error" if it's undefined, but I'm not sure if this is the correct practice. Any advice would be appreciated.
Also, I think it would be better to remove "#if defined(HMP)" when the ULE scheduler support and the HMP interface code support you separately posted are officially merged, but what about leaving it in during development?

Note that even without including opt_sched.h, if SMP is defined in the kernel configuration, the build error caused by #error will not occur.

Superseded by D55838

In D55458#1276878, @minsoochoo0122_proton.me wrote:

I'm falling behind for this topic. Does this mean starting from pkg 2.5, we don't need pkgbasify? Also what version of FreeBSD support this? Some might have pkg 2.5 but not have FreeBSD-base in its conf file.

I'm falling behind for this topic. Does this mean starting from pkg 2.5, we don't need pkgbasify? Also what version of FreeBSD support this? Some might have pkg 2.5 but not have FreeBSD-base in its conf file.

I can take this once my work on LLDB is done (probably in April). I think this is mostly complete although there are some places that need fixes or improvements. Phab shows the author has been inactive for a long time, so I'll take this unless I hear back from the author.

Can we enable/disable the whole module when one or both of HMP and SMP aren't enabled? I don't see why we need to build this driver when HMP and SMP don't exist.

LGTM

LGTM

Please remove all SCHED_ULE ifs. Recently we made a change so that scheduler can be chosen on boot time, so it's now meaningless to have SCHED_ULE or SCHED_4BSD

The diff is off. Could you rebase main and create diff with git format-patch -U999999 --stdout main > change.diff?

You can squash all your previous and this one into one commit. (and that's preferred)

You can squash all your previous and this one into one commit. (and that's preferred)

The diff is off. Could you rebase main and create diff with git format-patch -U999999 --stdout main > change.diff?

In D55189#1261894, @kib wrote:

In D55189#1261893, @minsoochoo0122_proton.me wrote:

In D55189#1261892, @kib wrote:

Please commit the x86 change.

I did in 728adff455a3. Or do you mean submit only x86 change and discard others?

I do not see this revision in the FreeBSD git repo. I mean literally commit the sys/x86/include part, leaving other arches for their maintainers to review.

In D55189#1261892, @kib wrote:

Please commit the x86 change.

update misplaced comment

remove blank line and separate commit for x86

cleanup x86