Page MenuHomeFreeBSD

jo_bruelltuete.com (Johannes Totz)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2021, 9:59 PM (119 w, 2 d)

Recent Activity

Thu, May 25

jo_bruelltuete.com added a comment to D39969: superio(4): Add device ID for ITE IT8613.

Can you please provide the author info as you'd like it to be, for git commit --author=...

Thu, May 25, 2:07 PM
jo_bruelltuete.com added a comment to D39969: superio(4): Add device ID for ITE IT8613.

hi @emaste, thanks for review.
feel free to commit if you are happy with this.

Thu, May 25, 1:41 PM

Tue, May 23

jo_bruelltuete.com added a comment to D40139: cpufreq(4): add tunable to prefer MSR over acpi_perf for P-state info.

I think this is ok. It would be useful to have some motivation for the tunable: when should a user try it? Is there some risk involved?

Tue, May 23, 2:44 PM
jo_bruelltuete.com updated the diff for D40139: cpufreq(4): add tunable to prefer MSR over acpi_perf for P-state info.

less indent via elseif

Tue, May 23, 2:38 PM
jo_bruelltuete.com updated the diff for D40158: cpufreq(4): allow overriding P-state configuration.

use x86_msr_op

Tue, May 23, 2:24 PM
jo_bruelltuete.com added a comment to D40158: cpufreq(4): allow overriding P-state configuration.

x86_msr_op looks much better and already does the right thing wrt unbind. thanks for the suggestion!

Tue, May 23, 1:25 PM
jo_bruelltuete.com added inline comments to D40158: cpufreq(4): allow overriding P-state configuration.
Tue, May 23, 12:33 PM

Mon, May 22

jo_bruelltuete.com updated the test plan for D40158: cpufreq(4): allow overriding P-state configuration.
Mon, May 22, 8:35 PM
jo_bruelltuete.com updated the diff for D40158: cpufreq(4): allow overriding P-state configuration.

addressing review

Mon, May 22, 8:33 PM
jo_bruelltuete.com updated the diff for D40139: cpufreq(4): add tunable to prefer MSR over acpi_perf for P-state info.

addressing review

Mon, May 22, 7:57 PM
jo_bruelltuete.com added a comment to D40158: cpufreq(4): allow overriding P-state configuration.

thanks for looking at the patch

Mon, May 22, 7:28 PM

Fri, May 19

jo_bruelltuete.com requested review of D40158: cpufreq(4): allow overriding P-state configuration.
Fri, May 19, 12:18 AM

Thu, May 18

jo_bruelltuete.com added a reviewer for D40140: cpufreq(4): calculate power if P-state info comes from MSR: cem.
Thu, May 18, 3:43 PM
jo_bruelltuete.com updated the test plan for D40140: cpufreq(4): calculate power if P-state info comes from MSR.
Thu, May 18, 12:46 AM
jo_bruelltuete.com added inline comments to D40140: cpufreq(4): calculate power if P-state info comes from MSR.
Thu, May 18, 12:45 AM
jo_bruelltuete.com requested review of D40140: cpufreq(4): calculate power if P-state info comes from MSR.
Thu, May 18, 12:44 AM
jo_bruelltuete.com requested review of D40139: cpufreq(4): add tunable to prefer MSR over acpi_perf for P-state info.
Thu, May 18, 12:37 AM

Tue, May 9

jo_bruelltuete.com added inline comments to D39961: efiwake(8): add man page.
Tue, May 9, 1:38 PM
jo_bruelltuete.com updated the diff for D39961: efiwake(8): add man page.

synopsis for no options. make the other two non-optional.

Tue, May 9, 1:37 PM

Mon, May 8

jo_bruelltuete.com updated the diff for D39971: it8613hwm(4): add man page.

review

Mon, May 8, 6:48 PM
jo_bruelltuete.com updated the diff for D39970: it8613hwm(4): Add new driver for ITE IT8613 hardware monitor.

style?

Mon, May 8, 6:40 PM
jo_bruelltuete.com retitled D39970: it8613hwm(4): Add new driver for ITE IT8613 hardware monitor from Add driver for ITE 8613 hardware monitor to it8613hwm(4): Add new driver for ITE IT8613 hardware monitor.
Mon, May 8, 3:09 PM
jo_bruelltuete.com retitled D39969: superio(4): Add device ID for ITE IT8613 from Add ITE 8613 to superio to superio(4): Add device ID for ITE IT8613.
Mon, May 8, 3:07 PM
jo_bruelltuete.com updated the test plan for D39961: efiwake(8): add man page.
Mon, May 8, 3:06 PM
jo_bruelltuete.com updated the diff for D39961: efiwake(8): add man page.

d and e option on separate lines

Mon, May 8, 3:04 PM
jo_bruelltuete.com updated the test plan for D39971: it8613hwm(4): add man page.
Mon, May 8, 2:53 PM
jo_bruelltuete.com updated the diff for D39971: it8613hwm(4): add man page.

review comments.
i hope i got that right... man page diffs are surprisingly hard to read...

Mon, May 8, 2:52 PM

Fri, May 5

jo_bruelltuete.com abandoned D36424: Add ITE 8613 to superio.

all refreshed into new patches and separated out.

Fri, May 5, 12:48 AM
jo_bruelltuete.com updated the summary of D39971: it8613hwm(4): add man page.
Fri, May 5, 12:48 AM
jo_bruelltuete.com updated subscribers of D39971: it8613hwm(4): add man page.
Fri, May 5, 12:46 AM
jo_bruelltuete.com requested review of D39971: it8613hwm(4): add man page.
Fri, May 5, 12:45 AM
jo_bruelltuete.com updated subscribers of D39970: it8613hwm(4): Add new driver for ITE IT8613 hardware monitor.
Fri, May 5, 12:24 AM
jo_bruelltuete.com updated the test plan for D39970: it8613hwm(4): Add new driver for ITE IT8613 hardware monitor.
Fri, May 5, 12:23 AM
jo_bruelltuete.com updated the test plan for D39970: it8613hwm(4): Add new driver for ITE IT8613 hardware monitor.
Fri, May 5, 12:23 AM
jo_bruelltuete.com updated the test plan for D39970: it8613hwm(4): Add new driver for ITE IT8613 hardware monitor.
Fri, May 5, 12:20 AM
jo_bruelltuete.com updated the summary of D39970: it8613hwm(4): Add new driver for ITE IT8613 hardware monitor.
Fri, May 5, 12:19 AM
jo_bruelltuete.com requested review of D39970: it8613hwm(4): Add new driver for ITE IT8613 hardware monitor.
Fri, May 5, 12:17 AM

Thu, May 4

jo_bruelltuete.com updated the test plan for D39969: superio(4): Add device ID for ITE IT8613.
Thu, May 4, 11:58 PM
jo_bruelltuete.com updated subscribers of D39969: superio(4): Add device ID for ITE IT8613.

cc @avg if you are still around

Thu, May 4, 11:52 PM
jo_bruelltuete.com requested review of D39969: superio(4): Add device ID for ITE IT8613.
Thu, May 4, 11:51 PM
jo_bruelltuete.com planned changes to D36424: Add ITE 8613 to superio.

let me refresh this

Thu, May 4, 11:32 PM
jo_bruelltuete.com added a comment to D39965: rc.suspend: execute rc-scripts with suspend keyword.

feel free to commit if good to go

Thu, May 4, 11:31 PM
jo_bruelltuete.com updated the diff for D39961: efiwake(8): add man page.

review

Thu, May 4, 11:28 PM
jo_bruelltuete.com updated the diff for D39961: efiwake(8): add man page.

making sure to pick up the makefile as well

Thu, May 4, 7:20 PM
jo_bruelltuete.com retitled D39961: efiwake(8): add man page from Add man page for efiwake to efiwake(8): add man page.
Thu, May 4, 7:18 PM
jo_bruelltuete.com added a comment to D39961: efiwake(8): add man page.

You also need to add:

MAN=	efiwake.8

to usr.sbin/efiwake/Makefile, otherwise the man page won't be installed.

Thu, May 4, 7:17 PM
jo_bruelltuete.com updated the diff for D39961: efiwake(8): add man page.

review comments

Thu, May 4, 6:57 PM
jo_bruelltuete.com added a comment to D39961: efiwake(8): add man page.

linter is happy

Thu, May 4, 6:45 PM
jo_bruelltuete.com updated the diff for D39961: efiwake(8): add man page.

address comments

Thu, May 4, 6:44 PM
jo_bruelltuete.com added a comment to D39961: efiwake(8): add man page.

thanks for looking at this patch

Thu, May 4, 6:32 PM
jo_bruelltuete.com added a comment to D39965: rc.suspend: execute rc-scripts with suspend keyword.

thanks for looking!

Thu, May 4, 6:23 PM
jo_bruelltuete.com retitled D39965: rc.suspend: execute rc-scripts with suspend keyword from rc.suspend can execute rc-scripts with suspend keyword to rc.suspend: execute rc-scripts with suspend keyword.
Thu, May 4, 6:22 PM
jo_bruelltuete.com added a comment to D39965: rc.suspend: execute rc-scripts with suspend keyword.

i've pretty much copy-pasted the added bits from rc.resume and adjusted the keyword. that's it.

Thu, May 4, 6:07 PM
jo_bruelltuete.com updated the test plan for D39965: rc.suspend: execute rc-scripts with suspend keyword.
Thu, May 4, 6:06 PM
jo_bruelltuete.com requested review of D39965: rc.suspend: execute rc-scripts with suspend keyword.
Thu, May 4, 6:02 PM
jo_bruelltuete.com updated subscribers of D39961: efiwake(8): add man page.

cc @kib

Thu, May 4, 3:50 PM
jo_bruelltuete.com updated the test plan for D39961: efiwake(8): add man page.
Thu, May 4, 3:50 PM
jo_bruelltuete.com requested review of D39961: efiwake(8): add man page.
Thu, May 4, 3:49 PM

Apr 26 2023

jo_bruelltuete.com added a comment to D36714: EFI wake time.

@kib this came out of git-format-patch, does that look right?

Apr 26 2023, 4:19 PM
jo_bruelltuete.com updated the diff for D36714: EFI wake time.

review comments.
patch against current. compile-tested only.

Apr 26 2023, 2:27 PM

Apr 25 2023

jo_bruelltuete.com added inline comments to D36714: EFI wake time.
Apr 25 2023, 4:40 PM

Apr 24 2023

jo_bruelltuete.com added a comment to D36714: EFI wake time.

I tested this patch against CURRENT and the update wakes my generic AMD desktop at the specified time using efiwake.

Apr 24 2023, 5:37 PM
jo_bruelltuete.com updated the diff for D36714: EFI wake time.

review comments

Apr 24 2023, 4:24 PM
jo_bruelltuete.com updated the test plan for D36714: EFI wake time.
Apr 24 2023, 4:02 PM
jo_bruelltuete.com added a comment to D36714: EFI wake time.
In D36714#905278, @kib wrote:

Thanks for reviewing!
Would be good to get folks to test this out on their hardware. I'm not sure what to make of the BIOS in my mainboard... it allows setting the wake timer, e.g. 2025-10-31T20:50:59, but ignores the month component! So you get a timer date of 2025-04-31T..., a date that does not exist. Or maybe I made a mistake somewhere...

Could you try to add printf()s in the kernel code right before SET_WAKETIME and after GET_WAKETIME efi_calls, to see what is the month value passed to/from UEFI RT methods. It might be not bios but some bug in userspace/kernel.

Apr 24 2023, 3:59 PM

Apr 23 2023

jo_bruelltuete.com added a comment to D36714: EFI wake time.

Thanks for reviewing!
Would be good to get folks to test this out on their hardware. I'm not sure what to make of the BIOS in my mainboard... it allows setting the wake timer, e.g. 2025-10-31T20:50:59, but ignores the month component! So you get a timer date of 2025-04-31T..., a date that does not exist. Or maybe I made a mistake somewhere...

Apr 23 2023, 5:28 PM
jo_bruelltuete.com updated the diff for D36714: EFI wake time.

addressing comments.
and found a weird bug in my bios...

Apr 23 2023, 5:25 PM

Apr 22 2023

jo_bruelltuete.com updated the diff for D36714: EFI wake time.

Patch against current. I've checked that it compiles but cannot runtime test it.
The 13-stable version of this patch works fine on my hardware.

Apr 22 2023, 7:37 PM
jo_bruelltuete.com added a comment to D36714: EFI wake time.

will update patch shortly.
meanwhile, got this in the console after (first) resume:

ACPI Error: No installed handler for fixed event - RealTimeClock (4), disabling (20201113/evevent-436)

Otherwise seems to be working fine.

Apr 22 2023, 4:35 PM

Apr 21 2023

jo_bruelltuete.com added inline comments to D36714: EFI wake time.
Apr 21 2023, 2:29 PM

Jan 15 2023

jo_bruelltuete.com added a comment to D34094: Update superiotool to latest version.

thank you @pi!

Jan 15 2023, 3:13 PM

Jan 10 2023

jo_bruelltuete.com added a comment to D34094: Update superiotool to latest version.

@avg @pi new year new luck. can we commit this?

Jan 10 2023, 1:16 PM

Jan 7 2023

jo_bruelltuete.com added a comment to D36424: Add ITE 8613 to superio.

ping @avg or @imp: any thoughts here?
works fine for me. Most likely works with any IT87 chip (because thats the datasheet I found), but i only have it8613 to actually test on.

Jan 7 2023, 2:34 PM

Dec 23 2022

jo_bruelltuete.com added a comment to D36714: EFI wake time.

thanks for the pointer, kib!
spec looks relevant. but i have no idea how to do anything about those flags in the fbsd source code...

Dec 23 2022, 1:10 AM

Dec 13 2022

jo_bruelltuete.com added a comment to D36714: EFI wake time.

Hm... no idea how that is supposed to work then...
I suspect that something something ACPI needs to happen.
For example, for my NAS box I have (sysctl):

dev.acpi_sysresource.3.wake: 0

which is the super-io / power management controller (cf D36424).
But messing around with that wake parameter does not seem to do anything.

Dec 13 2022, 4:14 PM

Dec 9 2022

jo_bruelltuete.com updated the diff for D36714: EFI wake time.

rebase onto current.
(compiles but not runtime tested)

Dec 9 2022, 5:19 PM

Dec 4 2022

jo_bruelltuete.com added a comment to D36714: EFI wake time.

hi @imp & @john.grafton_runbox.com, thanks for looking!
this patch was against stable-13. I don't have spare hardware to test on current...
how useful do you think this patch is? it did not actually work for me... i suspect a dodgy bios in the nas box, as it wakes from s5 but not from s3.

Dec 4 2022, 12:35 AM

Nov 7 2022

jo_bruelltuete.com added a comment to D34094: Update superiotool to latest version.

ping @avg -- please click the merge button if good to go.

Nov 7 2022, 1:24 AM
jo_bruelltuete.com added a comment to D33677: Mention vendor driver for if_re.

Someone please click the merge button... thanks!

Nov 7 2022, 1:22 AM
jo_bruelltuete.com updated the diff for D33677: Mention vendor driver for if_re.
Nov 7 2022, 1:22 AM
jo_bruelltuete.com added a comment to D36424: Add ITE 8613 to superio.

works pretty well, here's a grafana screenshot of the numbers that this driver spits out.

Nov 7 2022, 1:18 AM

Oct 1 2022

jo_bruelltuete.com added a comment to D36495: Minor fixes to acpi_thermal.
In D36495#836211, @jhb wrote:

Can you please confirm the e-mail address and name to use for the commit author when merging this?

Oct 1 2022, 1:06 PM

Sep 26 2022

jo_bruelltuete.com updated the test plan for D36714: EFI wake time.
Sep 26 2022, 2:32 PM
jo_bruelltuete.com requested review of D36714: EFI wake time.
Sep 26 2022, 2:30 PM
jo_bruelltuete.com added a comment to D36424: Add ITE 8613 to superio.

hi @avg , anything else i should change here? good to commit?

Sep 26 2022, 1:41 PM

Sep 8 2022

jo_bruelltuete.com updated the diff for D36495: Minor fixes to acpi_thermal.

use snprintf as well

Sep 8 2022, 11:40 PM
jo_bruelltuete.com added a comment to D36424: Add ITE 8613 to superio.

Notice that acpi says the temp is 10 deg lower. Looks like it does not take into account the sensor offset. (Or the BIOS is botched... not unlikely tbh...)

Sep 8 2022, 3:55 PM
jo_bruelltuete.com added a reviewer for D36495: Minor fixes to acpi_thermal: jhb.

hi john, adding you as you've made recent changes here.
thanks for looking!

Sep 8 2022, 3:49 PM
jo_bruelltuete.com added inline comments to D36495: Minor fixes to acpi_thermal.
Sep 8 2022, 3:44 PM
jo_bruelltuete.com requested review of D36495: Minor fixes to acpi_thermal.
Sep 8 2022, 3:39 PM

Sep 7 2022

jo_bruelltuete.com updated the diff for D36424: Add ITE 8613 to superio.

add man page

Sep 7 2022, 11:56 PM
jo_bruelltuete.com added a comment to D36424: Add ITE 8613 to superio.
$ sysctl dev.it8613hwm
dev.it8613hwm.0.fan2: 1470
dev.it8613hwm.0.fan1: 648
dev.it8613hwm.0.fan0: 0
dev.it8613hwm.0.temperature2: 35C
dev.it8613hwm.0.temperature1: 40C
dev.it8613hwm.0.temperature0: 49C
dev.it8613hwm.0.%parent: superio0
dev.it8613hwm.0.%pnpinfo: type=HWM
dev.it8613hwm.0.%location: ldn=0x04
dev.it8613hwm.0.%driver: it8613hwm
dev.it8613hwm.0.%desc: Hardware monitor on ITE SuperIO
dev.it8613hwm.%parent:
Sep 7 2022, 6:25 PM
jo_bruelltuete.com updated the diff for D36424: Add ITE 8613 to superio.

add fan speed

Sep 7 2022, 6:21 PM
jo_bruelltuete.com updated the diff for D36424: Add ITE 8613 to superio.

cleanup

Sep 7 2022, 12:16 AM

Sep 6 2022

jo_bruelltuete.com added a comment to D36424: Add ITE 8613 to superio.

thanks for taking a look.

Sep 6 2022, 11:06 PM

Sep 5 2022

jo_bruelltuete.com added a comment to D36424: Add ITE 8613 to superio.

Is this the right thing to do?
I wrote a sbin tool that opens /dev/io and does raw io to talk to the chip. Now turning that into a driver that exposes the system info as sysctl seems reasonable to me... but maybe this should go somewhere else? I'm looking for opinions.

Sep 5 2022, 4:33 PM
jo_bruelltuete.com added a comment to D36424: Add ITE 8613 to superio.

mostly copy-pasta'd together from itwd and other drivers already in source.

Sep 5 2022, 4:27 PM
jo_bruelltuete.com updated the summary of D36424: Add ITE 8613 to superio.
Sep 5 2022, 4:26 PM
jo_bruelltuete.com added a reviewer for D36424: Add ITE 8613 to superio: avg.
Sep 5 2022, 4:24 PM
jo_bruelltuete.com updated the diff for D36424: Add ITE 8613 to superio.
$ devinfo -r
[...]
        isab0
          isa0
            superio0
                ACPI I/O ports:
                    0x2e-0x2f
              it8613hwm0
                  ACPI I/O ports:
                      0xa35-0xa36
[...]
Sep 5 2022, 4:24 PM