virtio_gpu: Avoid panic if a 0x0 mode is provided
Needs ReviewPublic
Actions

Authored by val_packett.cool on Jun 25 2024, 5:09 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Nov 26 2024, 8:40 PM

	Unknown Object (File)
	Nov 26 2024, 3:12 PM

	Unknown Object (File)
	Oct 30 2024, 4:35 AM

	Unknown Object (File)
	Aug 7 2024, 2:07 PM

	Unknown Object (File)
	Jul 20 2024, 11:43 PM

	Unknown Object (File)
	Jun 29 2024, 1:06 AM

	Unknown Object (File)
	Jun 28 2024, 11:29 PM

	Unknown Object (File)
	Jun 27 2024, 6:55 PM

View All 10 Files

Subscribers

imp

Details

Reviewers

andrew

Group Reviewers

Contributor Reviews (src)

Summary

On an amd64 QEMU host, using "-device virtio-gpu-gl" results in a 0x0
mode being provided, which would panic the kernel due to a zero-sized
allocation attempt. Suggest using virtio-vga(-gl) which does not have
that issue.

Sponsored by: Ihor Antonov <ihor@antonovs.family>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58342
Build 55230: arc lint + arc unit

Event Timeline

val_packett.cool created this revision.Jun 25 2024, 5:09 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 25 2024, 5:09 AM

val_packett.cool requested review of this revision.Jun 25 2024, 5:09 AM

Harbormaster completed remote builds in B58342: Diff 140204.Jun 25 2024, 5:09 AM

val_packett.cool added reviewers: Contributor Reviews (src), andrew.Jun 25 2024, 5:11 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

gpu/

virtio_gpu.c

4 lines

Diff 140204

View Options

sys/dev/virtio/gpu/virtio_gpu.c

virtio_gpu: Avoid panic if a 0x0 mode is providedNeeds ReviewPublicActions