Page MenuHomeFreeBSD

virtio_gpu: Avoid panic if a 0x0 mode is provided
Needs ReviewPublic

Authored by val_packett.cool on Jun 25 2024, 5:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 25, 11:51 AM
Unknown Object (File)
Sun, Sep 21, 11:56 AM
Unknown Object (File)
Sat, Sep 20, 10:54 PM
Unknown Object (File)
Fri, Sep 19, 2:20 AM
Unknown Object (File)
Tue, Sep 16, 3:22 AM
Unknown Object (File)
Mon, Sep 15, 6:19 AM
Unknown Object (File)
Sep 10 2025, 11:35 AM
Unknown Object (File)
Sep 8 2025, 11:24 AM
Subscribers

Details

Reviewers
andrew
Group Reviewers
Contributor Reviews (src)
Summary

On an amd64 QEMU host, using "-device virtio-gpu-gl" results in a 0x0
mode being provided, which would panic the kernel due to a zero-sized
allocation attempt. Suggest using virtio-vga(-gl) which does not have
that issue.

Sponsored by: Ihor Antonov <ihor@antonovs.family>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58342
Build 55230: arc lint + arc unit

Event Timeline

emaste added inline comments.
sys/dev/virtio/gpu/virtio_gpu.c
507

It's not necessarily 0x0 (e.g. 640x0 would also trigger this). We could either do "skipping %ux%u" and include the width and height, or e.g. "skipping display mode with width/height 0"

Or just skip it without a message