Page MenuHomeFreeBSD
Differential D45724

virtio_gpu: Avoid panic if a 0x0 mode is provided
Needs ReviewPublic
Actions

Authored by val_packett.cool on Jun 25 2024, 5:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 5, 3:49 AM
Unknown Object (File)
Thu, Apr 2, 5:23 PM
Unknown Object (File)
Fri, Mar 27, 11:36 PM
Unknown Object (File)
Mon, Mar 23, 7:21 PM
Unknown Object (File)
Sun, Mar 22, 11:35 PM
Unknown Object (File)
Sat, Mar 21, 7:40 PM
Unknown Object (File)
Mar 18 2026, 9:49 PM
Unknown Object (File)
Mar 18 2026, 3:53 AM
View All 75 Files
Subscribers
emaste
imp

Details

Reviewers
andrew
Group Reviewers
Contributor Reviews (src)
Summary

On an amd64 QEMU host, using "-device virtio-gpu-gl" results in a 0x0
mode being provided, which would panic the kernel due to a zero-sized
allocation attempt. Suggest using virtio-vga(-gl) which does not have
that issue.

Sponsored by: Ihor Antonov <ihor@antonovs.family>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58342
Build 55230: arc lint + arc unit

Event Timeline

val_packett.cool created this revision.Jun 25 2024, 5:09 AM
Herald added a subscriber: imp. · View Herald TranscriptJun 25 2024, 5:09 AM
val_packett.cool requested review of this revision.Jun 25 2024, 5:09 AM
Harbormaster completed remote builds in B58342: Diff 140204.Jun 25 2024, 5:09 AM
val_packett.cool added reviewers: Contributor Reviews (src), andrew.Jun 25 2024, 5:11 AM
emaste added a subscriber: emaste.Feb 20 2025, 11:50 PM
emaste added inline comments.
sys/dev/virtio/gpu/virtio_gpu.c
507

It's not necessarily 0x0 (e.g. 640x0 would also trigger this). We could either do "skipping %ux%u" and include the width and height, or e.g. "skipping display mode with width/height 0"

Or just skip it without a message

Revision Contents
Changeset List

PathSize
sys/
dev/
virtio/
gpu/
4 lines

Diff 140204

View Options

sys/dev/virtio/gpu/virtio_gpu.c

Loading...