Differential D50871

gpiopps: don't use internal gpiobus function
ClosedPublic
Actions

Authored by vexeduxr on Jun 16 2025, 7:51 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 17, 9:55 AM

	Unknown Object (File)
	Sun, May 17, 4:16 AM

	Unknown Object (File)
	Sun, May 17, 4:03 AM

	Unknown Object (File)
	Thu, May 14, 1:41 PM

	Unknown Object (File)
	Thu, Apr 30, 5:54 AM

	Unknown Object (File)
	Thu, Apr 30, 5:54 AM

	Unknown Object (File)
	Tue, Apr 28, 8:17 AM

	Unknown Object (File)
	Sun, Apr 26, 5:52 AM

View All 84 Files

Subscribers

Details

Reviewers

imp
wulf

Commits

rGff826f8ed434: gpiopps: don't use internal gpiobus function

Summary

gpiobus_release_pin is only meant to be used internally by gpiobus. Use
gpio_pin_release instead.

This also fixes a memory leak as gpio_pin_get_by_ofw_idx returns a
malloc'd pointer, which gpio_pin_release now frees.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vexeduxr created this revision.Jun 16 2025, 7:51 AM

Herald added a subscriber: loos. · View Herald TranscriptJun 16 2025, 7:51 AM

vexeduxr requested review of this revision.Jun 16 2025, 7:51 AM

Harbormaster completed remote builds in B64898: Diff 157092.Jun 16 2025, 7:51 AM

vexeduxr added a parent revision: D50870: regulator: don't use internal gpiobus function.Jun 16 2025, 7:51 AM

vexeduxr added a child revision: D50872: gpio: hide internal gpiobus symbols.

LGTM

This revision is now accepted and ready to land.Jun 25 2025, 8:32 AM

imp accepted this revision.Jul 3 2025, 7:58 PM

Closed by commit rGff826f8ed434: gpiopps: don't use internal gpiobus function (authored by vexeduxr). · Explain WhyJul 4 2025, 8:26 PM

This revision was automatically updated to reflect the committed changes.

vexeduxr added a commit: rGff826f8ed434: gpiopps: don't use internal gpiobus function.

Revision Contents
Changeset List

Path

Size

sys/

dev/

gpio/

2 lines

Diff 157988

sys/dev/gpio/gpiopps.c

Loading...