Page MenuHomeFreeBSD
Differential D50939

gpiobus: gpiobus_release_pin: convert errors to panic
ClosedPublic
Actions

Authored by vexeduxr on Jun 19 2025, 2:32 PM.
Tags
None
Referenced Files
F154353479: D50939.id157943.diff
Tue, Apr 28, 1:17 AM
Unknown Object (File)
Sun, Apr 26, 12:31 PM
Unknown Object (File)
Fri, Apr 24, 1:14 AM
Unknown Object (File)
Tue, Apr 21, 6:50 PM
Unknown Object (File)
Sun, Apr 19, 10:27 AM
Unknown Object (File)
Sat, Apr 18, 12:26 PM
Unknown Object (File)
Fri, Apr 17, 1:30 PM
Unknown Object (File)
Fri, Apr 17, 8:31 AM
View All 71 Files
Subscribers
None

Details

Reviewers
imp
wulf
mmel
Commits
rGa2bfb7cff243: gpiobus: gpiobus_release_pin: convert errors to panic
Summary

These are programming errors.

Suggested by: mmel

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vexeduxr requested review of this revision.Jun 19 2025, 2:32 PM
vexeduxr created this revision.
Harbormaster completed remote builds in B64981: Diff 157310.Jun 19 2025, 2:32 PM
vexeduxr added a parent revision: D50940: gpiobus: gpiobus_acquire_pin: panic on invalid pin.Jun 19 2025, 2:34 PM
vexeduxr added a child revision: D50868: gpiobus: gpio_pin_release: convert checks to KASSERTs.
imp accepted this revision.Jul 3 2025, 8:09 PM

I'm not sure if this is still relevant given other changes, but it looks good.. If it's no longer relevant, please abandon.

This revision is now accepted and ready to land.Jul 3 2025, 8:09 PM
vexeduxr added a comment.Jul 4 2025, 2:22 PM

Should be good to go. Although I just realized one of the callers explicitly casts this to void. That should be removed too.

vexeduxr updated this revision to Diff 157943.Jul 4 2025, 2:24 PM

Remove the now redundant cast to void.

This revision now requires review to proceed.Jul 4 2025, 2:24 PM
Harbormaster completed remote builds in B65205: Diff 157943.Jul 4 2025, 2:24 PM
imp accepted this revision.Jul 4 2025, 3:33 PM

OK. Looks great!

This revision is now accepted and ready to land.Jul 4 2025, 3:33 PM
Closed by commit rGa2bfb7cff243: gpiobus: gpiobus_release_pin: convert errors to panic (authored by vexeduxr). · Explain WhyJul 4 2025, 8:26 PM
This revision was automatically updated to reflect the committed changes.
vexeduxr added a commit: rGa2bfb7cff243: gpiobus: gpiobus_release_pin: convert errors to panic.

Revision Contents
Changeset List

PathSize
sys/
dev/
gpio/
21 lines
2 lines

Diff 157984

View Options

sys/dev/gpio/gpiobus.c

Loading...
View Options

sys/dev/gpio/gpiobusvar.h

Loading...