Differential D50869

gpiobus: add gpio_pin_acquire
Needs ReviewPublic
Actions

Authored by vexeduxr on Mon, Jun 16, 7:46 AM.

Tags

None

Referenced Files

	F121556843: D50869.diff
	Fri, Jun 27, 11:18 AM

	Unknown Object (File)
	Wed, Jun 25, 5:10 PM

	Unknown Object (File)
	Sun, Jun 22, 11:26 PM

	Unknown Object (File)
	Thu, Jun 19, 4:19 AM

	Unknown Object (File)
	Wed, Jun 18, 9:19 PM

	Unknown Object (File)
	Wed, Jun 18, 9:08 PM

	Unknown Object (File)
	Tue, Jun 17, 4:53 AM

	Unknown Object (File)
	Tue, Jun 17, 4:30 AM

View All 9 Files

Subscribers

Details

Reviewers

imp
wulf
mmel

Summary

In some cases, drivers may need to acquire an existing gpio_pin_t. With
the functions gpiobus currently exposes, this isn't possible as they
allocate a new pin then acquire that. Add a new gpio_pin_acquire
function which accepts an existing gpiobus_pin structure.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64984
Build 61867: arc lint + arc unit

Event Timeline

vexeduxr created this revision.Mon, Jun 16, 7:46 AM

Herald added a subscriber: loos. · View Herald TranscriptMon, Jun 16, 7:46 AM

vexeduxr requested review of this revision.Mon, Jun 16, 7:46 AM

Harbormaster completed remote builds in B64896: Diff 157090.Mon, Jun 16, 7:46 AM

vexeduxr added a parent revision: D50868: gpiobus: gpio_pin_release: convert checks to KASSERTs.Mon, Jun 16, 7:46 AM

vexeduxr added a child revision: D50870: regulator: don't use internal gpiobus function.Mon, Jun 16, 7:53 AM

Otherwise, it looks fine to me.

sys/dev/gpio/gpiobusvar.h
162	Wrong place, see the comment a line above. And, please, add short comment all other functions here have it.

This revision now requires changes to proceed.Tue, Jun 17, 1:14 PM

vexeduxr added inline comments.Tue, Jun 17, 5:01 PM

sys/dev/gpio/gpiobusvar.h
162	Ah, not sure how I missed that. Thanks.

fixup function declaration

Harbormaster completed remote builds in B64945: Diff 157202.Tue, Jun 17, 5:07 PM

mmel accepted this revision.Tue, Jun 17, 5:57 PM

This revision is now accepted and ready to land.Tue, Jun 17, 5:57 PM

Convert null check to KASSERT

This revision now requires review to proceed.Thu, Jun 19, 2:38 PM

Harbormaster completed remote builds in B64984: Diff 157313.Thu, Jun 19, 2:38 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

gpio/

22 lines

2 lines

Diff 157313

sys/dev/gpio/gpiobus.c

Loading...

sys/dev/gpio/gpiobusvar.h

Loading...