Differential D50869

gpiobus: add gpio_pin_acquire
ClosedPublic
Actions

Authored by vexeduxr on Jun 16 2025, 7:46 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jul 15, 9:28 AM

	Unknown Object (File)
	Thu, Jul 10, 7:19 AM

	Unknown Object (File)
	Tue, Jul 8, 10:34 AM

	Unknown Object (File)
	Mon, Jul 7, 12:13 PM

	Unknown Object (File)
	Sat, Jul 5, 2:57 AM

	Unknown Object (File)
	Sat, Jul 5, 2:57 AM

	Unknown Object (File)
	Fri, Jul 4, 7:12 PM

	Unknown Object (File)
	Mon, Jun 30, 9:03 PM

View All 18 Files

Subscribers

Details

Reviewers

imp
wulf
mmel

Commits

rG4a21713278a8: gpiobus: add gpio_pin_acquire

Summary

In some cases, drivers may need to acquire an existing gpio_pin_t. With
the functions gpiobus currently exposes, this isn't possible as they
allocate a new pin then acquire that. Add a new gpio_pin_acquire
function which accepts an existing gpiobus_pin structure.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vexeduxr created this revision.Jun 16 2025, 7:46 AM

Herald added a subscriber: loos. · View Herald TranscriptJun 16 2025, 7:46 AM

vexeduxr requested review of this revision.Jun 16 2025, 7:46 AM

Harbormaster completed remote builds in B64896: Diff 157090.Jun 16 2025, 7:46 AM

vexeduxr added a parent revision: D50868: gpiobus: gpio_pin_release: convert checks to KASSERTs.Jun 16 2025, 7:46 AM

vexeduxr added a child revision: D50870: regulator: don't use internal gpiobus function.Jun 16 2025, 7:53 AM

Otherwise, it looks fine to me.

sys/dev/gpio/gpiobusvar.h
162	Wrong place, see the comment a line above. And, please, add short comment all other functions here have it.

This revision now requires changes to proceed.Tue, Jun 17, 1:14 PM

vexeduxr added inline comments.Tue, Jun 17, 5:01 PM

sys/dev/gpio/gpiobusvar.h
162	Ah, not sure how I missed that. Thanks.

fixup function declaration

Harbormaster completed remote builds in B64945: Diff 157202.Tue, Jun 17, 5:07 PM

mmel accepted this revision.Tue, Jun 17, 5:57 PM

This revision is now accepted and ready to land.Tue, Jun 17, 5:57 PM

Convert null check to KASSERT

This revision now requires review to proceed.Thu, Jun 19, 2:38 PM

Harbormaster completed remote builds in B64984: Diff 157313.Thu, Jun 19, 2:38 PM

love the extra context for the function's use.

This revision is now accepted and ready to land.Thu, Jul 3, 8:00 PM

Closed by commit rG4a21713278a8: gpiobus: add gpio_pin_acquire (authored by vexeduxr). · Explain WhyFri, Jul 4, 8:26 PM

This revision was automatically updated to reflect the committed changes.

vexeduxr added a commit: rG4a21713278a8: gpiobus: add gpio_pin_acquire.

Revision Contents
Changeset List

Path

Size

sys/

dev/

gpio/

22 lines

2 lines

Diff 157986

sys/dev/gpio/gpiobus.c

Loading...

sys/dev/gpio/gpiobusvar.h

Loading...