Page MenuHomeFreeBSD
Differential D50940

gpiobus: gpiobus_acquire_pin: panic on invalid pin
ClosedPublic
Actions

Authored by vexeduxr on Jun 19 2025, 2:33 PM.
Tags
None
Referenced Files
F154277475: D50940.id.diff
Mon, Apr 27, 1:36 PM
Unknown Object (File)
Sat, Apr 25, 11:25 AM
Unknown Object (File)
Mon, Apr 6, 10:59 AM
Unknown Object (File)
Mon, Apr 6, 2:49 AM
Unknown Object (File)
Sun, Apr 5, 2:25 AM
Unknown Object (File)
Sat, Apr 4, 2:25 AM
Unknown Object (File)
Sat, Mar 28, 6:17 PM
Unknown Object (File)
Mar 19 2026, 1:30 AM
View All 64 Files
Subscribers
None

Details

Reviewers
imp
wulf
mmel
Commits
rGed50879c4a95: gpiobus: gpiobus_acquire_pin: panic on invalid pin
Summary

It is a programming error to call this function with an invalid pin.
Also return proper error value on failure.

Suggested by: mmel

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vexeduxr requested review of this revision.Jun 19 2025, 2:33 PM
vexeduxr created this revision.
Harbormaster completed remote builds in B64982: Diff 157311.Jun 19 2025, 2:33 PM
vexeduxr added a child revision: D50939: gpiobus: gpiobus_release_pin: convert errors to panic.Jun 19 2025, 2:34 PM
mmel accepted this revision.Jun 19 2025, 2:38 PM
This revision is now accepted and ready to land.Jun 19 2025, 2:38 PM
imp accepted this revision.Jul 3 2025, 7:57 PM

Go ahead and commit this. I saw the discussion, and this represents what was talked about elsewhere.

Closed by commit rGed50879c4a95: gpiobus: gpiobus_acquire_pin: panic on invalid pin (authored by vexeduxr). · Explain WhyJul 4 2025, 8:26 PM
This revision was automatically updated to reflect the committed changes.
vexeduxr added a commit: rGed50879c4a95: gpiobus: gpiobus_acquire_pin: panic on invalid pin.

Revision Contents
Changeset List

PathSize
sys/
dev/
gpio/
7 lines

Diff 157983

View Options

sys/dev/gpio/gpiobus.c

Loading...