Page MenuHomeFreeBSD
Differential D50940

gpiobus: gpiobus_acquire_pin: panic on invalid pin
ClosedPublic
Actions

Authored by vexeduxr on Jun 19 2025, 2:33 PM.
Tags
None
Referenced Files
F134515124: D50940.diff
Sun, Nov 2, 7:40 PM
Unknown Object (File)
Sat, Nov 1, 3:16 AM
Unknown Object (File)
Fri, Oct 31, 11:21 AM
Unknown Object (File)
Wed, Oct 29, 8:09 AM
Unknown Object (File)
Sun, Oct 26, 10:30 AM
Unknown Object (File)
Oct 2 2025, 3:48 PM
Unknown Object (File)
Sep 29 2025, 11:22 PM
Unknown Object (File)
Sep 23 2025, 4:03 PM
View All 36 Files
Subscribers
None

Details

Reviewers
imp
wulf
mmel
Commits
rGed50879c4a95: gpiobus: gpiobus_acquire_pin: panic on invalid pin
Summary

It is a programming error to call this function with an invalid pin.
Also return proper error value on failure.

Suggested by: mmel

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64982
Build 61865: arc lint + arc unit

Event Timeline

vexeduxr requested review of this revision.Jun 19 2025, 2:33 PM
vexeduxr created this revision.
Harbormaster completed remote builds in B64982: Diff 157311.Jun 19 2025, 2:33 PM
vexeduxr added a child revision: D50939: gpiobus: gpiobus_release_pin: convert errors to panic.Jun 19 2025, 2:34 PM
mmel accepted this revision.Jun 19 2025, 2:38 PM
This revision is now accepted and ready to land.Jun 19 2025, 2:38 PM
imp accepted this revision.Jul 3 2025, 7:57 PM

Go ahead and commit this. I saw the discussion, and this represents what was talked about elsewhere.

Closed by commit rGed50879c4a95: gpiobus: gpiobus_acquire_pin: panic on invalid pin (authored by vexeduxr). · Explain WhyJul 4 2025, 8:26 PM
This revision was automatically updated to reflect the committed changes.
vexeduxr added a commit: rGed50879c4a95: gpiobus: gpiobus_acquire_pin: panic on invalid pin.

Revision Contents
Changeset List

PathSize
sys/
dev/
gpio/
7 lines

Diff 157311

View Options

sys/dev/gpio/gpiobus.c

Loading...