sysutils/iichid: Update to 0.0.3 Add two OPTIONS: * Make USB support optional * Verbose mode optional One of the things I dont want with my computer is having those messages from iichid on the console, so I added the verbose option. Reviewed_by: koobs (ports) Approved by: koobs (ports) Approved by: imp (maintainer) Differential_Revision: D25538 MFH: <branch|No> <reason>
Details
- Reviewers
imp wulf koobs - Commits
- rP543383: sysutils/iichid: Update to 0.0.3
poudriere
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Following is Makefile I was going to submit to ports some time ago:
# Created by: jrhett@netconsonance.com # $FreeBSD: head/sysutils/iichid/Makefile 529986 2020-03-31 16:15:16Z rene $ PORTNAME= iichid DISTVERSION= 0.0.2 CATEGORIES= sysutils MAINTAINER= imp@FreeBSD.org COMMENT= Generic FreeBSD HID layer for I2C and USB devices LICENSE= BSD2CLAUSE LICENSE_FILE= ${WRKSRC}/LICENSE IGNORE_FreeBSD_11= Requires FreeBSD 12.1 or later USES= kmod uidfix # USB backend is disabled by default as it interferes with existing USB drivers OPTIONS_DEFINE= I2C USB OPTIONS_DEFAULT=I2C I2C_DESC= HID over I2C support USB_DESC= HID over USB support USE_GITHUB= yes GH_ACCOUNT= wulf7 PLIST_FILES= ${KMODDIR}/iichid.ko I2C_MAKE_ARGS_OFF= -DDISABLE_I2CHID USB_MAKE_ARGS_OFF= -DDISABLE_USBHID .include <bsd.port.options.mk> .if ${PORT_OPTIONS:MI2C} ONLY_FOR_ARCHS= aarch64 amd64 i386 ONLY_FOR_ARCHS_REASON= I2C transport requires architecture supporting ACPI .endif .include <bsd.port.mk>
It is slightly simpler and can optionally disable both HID backends.
sysutils/iichid/Makefile | ||
---|---|---|
35 โ | (On Diff #73980) | It is better to reduce iichid default debug level rather than disable debug completely. It is set with following line in iichid.c: static int iichid_debug = 1; Patch it with sed to be initialized to zero. |
38 โ | (On Diff #73980) | You can skip USB HID compiling with addition of -DDISABLE_USBHID to make arguments. No need to patch Makefile. |
This port is maintained by @imp so we need his approval or timeout (is there a PR for this?)
BTW, if all the development is moved to base now, we may want to mark IGNORE on 13?
Really no. We have similar PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247787
I wrote to it's author to replace his patch with this one to not duplicate things.
BTW, if all the development is moved to base now, we may want to mark IGNORE on 13?
I hope we will mark it with IGNORE on on 13, but not now. It requires some surgery like moving all existing HID code to its own subsystem. That is not done yet.
Is this ready to go? I've been busy with personal stuff the last few weeks, but could do this if we're ready... And is this patch identical to the one in the bug or not?
thanks guys, I though @wulf was the maintainer as well. But thank you very much for following this up all of you.
Happy to hand it off, said so in the bugzilla, feel free to proceed with my fullest possible blessing.