Page MenuHomeFreeBSD

Contributor Reviewers (ports)Tag
ActivePublic

Details

Description

A group that committers can join (opt-in to) to be notified of revisions created by contributors (non-committers).

Perfect for grooming and teaching proactive contributors for future mentorship.

Recent Activity

Yesterday

lwhsu requested changes to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

I can build this port in poudriere fine. I think previous error was because of patching issue.

Sat, Sep 14, 8:24 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Sorry for forgetting about this. I didn't added it to my TODO list.
This doesn't build on FreeBSD 12 due to following error:

libtool: compile:  c++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"1.8.1\" "-DPACKAGE_STRING=\"mesos 1.8.1\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" -DVERSION=\"1.8.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_BOOST_VERSION_HPP=1 -DHAVE_LIBCURL=1 -DHAVE_GLOG_LOGGING_H=1 -DHAVE_ARCHIVE_H=1 -DHAVE_GOOGLE_PROTOBUF_MAP_H=1 -DHAVE_EV_H=1 -DHAVE_PICOJSON_H=1 -DHAVE_RAPIDJSON_RAPIDJSON_H=1 -DHAVE_LIBSASL2=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_GRPCPP_GRPCPP_H=1 -DHAVE_ZOOKEEPER_H=1 -I. -DLIBDIR=\"/usr/local/lib\" -DPKGLIBEXECDIR=\"/usr/local/libexec/mesos\" -DPKGDATADIR=\"/usr/local/share/mesos\" -DPKGMODULEDIR=\"/usr/local/lib/mesos/modules\" -I../include -I../include -I../include/mesos -D__STDC_FORMAT_MACROS -I../3rdparty/concurrentqueue-7b69a8f -I../3rdparty/elfio-3.2 -I../3rdparty/leveldb-1.19/include -I../3rdparty/libprocess/include -I../3rdparty/nvml-352.79 -I../3rdparty/stout/include -I/usr/local/include/subversion-1 -I/usr/local/include -I/usr/local/include -I/usr/local/include/apr-1 -I/usr/local/include/apr-1.0 -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/zookeeper -D_THREAD_SAFE -pthread -Wall -Wsign-compare -Wformat-security -fstack-protector-strong -fPIC -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wno-unused-local-typedef -Wno-inconsistent-missing-override -std=c++11 -stdlib=libc++ -DGTEST_HAS_PTHREAD -D_WITH_GETLINE -Wno-sentinel -MT master/libmesos_no_3rdparty_la-constants.lo -MD -MP -MF master/.deps/libmesos_no_3rdparty_la-constants.Tpo -c master/constants.cpp  -fPIC -DPIC -o master/.libs/libmesos_no_3rdparty_la-constants.o
master/allocator/mesos/hierarchical.cpp:1649:5: error: use of undeclared identifier 'random_shuffle'; did you mean 'std::random_shuffle'?
    random_shuffle(resourceVector.begin(), resourceVector.end());
    ^~~~~~~~~~~~~~
    std::random_shuffle
/usr/include/c++/v1/algorithm:3168:1: note: 'std::random_shuffle' declared here
random_shuffle(_RandomAccessIterator __first, _RandomAccessIterator __last)
^
Sat, Sep 14, 7:42 PM · Contributor Reviewers (ports)
arrowd added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Sorry for forgetting about this. I didn't added it to my TODO list.

Sat, Sep 14, 5:23 PM · Contributor Reviewers (ports)
lwhsu added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

@arrowd: any update on this?
@james.wright_digital-chaos.com: do you want to also submit the patch to the upstream?

Sat, Sep 14, 1:57 PM · Contributor Reviewers (ports)

Aug 13 2019

james.wright_digital-chaos.com added inline comments to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.
Aug 13 2019, 1:43 AM · Contributor Reviewers (ports)

Aug 12 2019

arrowd added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Looks good to me. If no one objects, I'll commit this after giving it a run in poudriere.

Aug 12 2019, 9:10 AM · Contributor Reviewers (ports)
arrowd closed D21185: devel/elfio: Updated to 3.4.
Aug 12 2019, 8:59 AM · Contributor Reviewers (ports)

Aug 8 2019

james.wright_digital-chaos.com retitled D21185: devel/elfio: Updated to 3.4 from devel/efio: Updated to 3.4 to devel/elfio: Updated to 3.4.
Aug 8 2019, 1:24 AM · Contributor Reviewers (ports)
james.wright_digital-chaos.com created D21185: devel/elfio: Updated to 3.4.
Aug 8 2019, 1:22 AM · Contributor Reviewers (ports)
james.wright_digital-chaos.com added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Updated to 1.8.1
Added patch to fix compilation error in src/master/allocator/mesos/hierarchical.cpp

Aug 8 2019, 12:45 AM · Contributor Reviewers (ports)

Jun 15 2019

tobik removed a member for Contributor Reviewers (ports): tobik.
Jun 15 2019, 5:57 AM

Jun 8 2019

james.wright_digital-chaos.com added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Please could take a look over the updated diff, as I appreciate the constructive feedback! :-)

Jun 8 2019, 8:48 PM · Contributor Reviewers (ports)

Jun 2 2019

james.wright_digital-chaos.com updated the diff for D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Makefile changes;

  • Fixed incorrect braces for PORTVERSION
  • Added USES= libtool
  • Added USES= shebangfix and SHEBANG_FILES= (although make stage-qa still seems unhappy with these files?)
  • Added USE_LDCONFIG=yes
  • Added option for installing CLI tools (which require the python runtime)
  • Added option for installing Deploy scripts (which should now install the *.template files as samples)
  • Added --disable-werror flag as suggested
Jun 2 2019, 9:04 PM · Contributor Reviewers (ports)
tobik resigned from D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.
Jun 2 2019, 1:41 PM · Contributor Reviewers (ports)

May 14 2019

mat added inline comments to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.
May 14 2019, 11:47 AM · Contributor Reviewers (ports)
tobik requested changes to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.
May 14 2019, 7:41 AM · Contributor Reviewers (ports)

May 13 2019

james.wright_digital-chaos.com updated the diff for D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Added SUBDIR += apache-mesos to sysutils/Makefile, as requested.

May 13 2019, 8:52 PM · Contributor Reviewers (ports)
linimon retitled D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software from sysutils/apache-mesos: New port to [new port] sysutils/apache-mesos: Apache Mesos cluster management software.
May 13 2019, 4:37 PM · Contributor Reviewers (ports)
tcberner added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

This needs to be hooked into sysutils/Makefile

May 13 2019, 4:22 AM · Contributor Reviewers (ports)

May 12 2019

james.wright_digital-chaos.com updated the summary of D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.
May 12 2019, 11:36 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com created D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.
May 12 2019, 11:31 PM · Contributor Reviewers (ports)

Apr 23 2019

tobik closed D19899: devel/picojson: New port.
Apr 23 2019, 5:18 PM · Contributor Reviewers (ports)

Apr 19 2019

tcberner accepted D19899: devel/picojson: New port.

lgtm

Apr 19 2019, 7:19 AM · Contributor Reviewers (ports)

Apr 16 2019

james.wright_digital-chaos.com added a comment to D19899: devel/picojson: New port.

Are there any further changes that this port needs, or can it be merged?

Apr 16 2019, 7:58 PM · Contributor Reviewers (ports)

Apr 15 2019

tobik closed D19879: devel/elfio: Updated from 1.0.3 to 3.3.
Apr 15 2019, 8:10 AM · Contributor Reviewers (ports)
tobik accepted D19879: devel/elfio: Updated from 1.0.3 to 3.3.
Apr 15 2019, 8:01 AM · Contributor Reviewers (ports)

Apr 14 2019

james.wright_digital-chaos.com updated the diff for D19879: devel/elfio: Updated from 1.0.3 to 3.3.

Updated Makefile based on suggestions;

Apr 14 2019, 11:13 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com updated the diff for D19899: devel/picojson: New port.

Fixed typo in pkg-descr.

Apr 14 2019, 9:09 PM · Contributor Reviewers (ports)
tobik accepted D19899: devel/picojson: New port.
Apr 14 2019, 6:53 PM · Contributor Reviewers (ports)
tobik requested changes to D19879: devel/elfio: Updated from 1.0.3 to 3.3.
Apr 14 2019, 6:45 PM · Contributor Reviewers (ports)
tcberner added inline comments to D19879: devel/elfio: Updated from 1.0.3 to 3.3.
Apr 14 2019, 3:31 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com updated the diff for D19879: devel/elfio: Updated from 1.0.3 to 3.3.

Updated existing devel/elfio port rather than creating a new one (devel/elfio3).

Apr 14 2019, 3:26 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com retitled D19879: devel/elfio: Updated from 1.0.3 to 3.3 from Added port for devel/elfio3 to devel/elfio: Updated from 1.0.3 to 3.3.
Apr 14 2019, 3:24 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com added a comment to D19879: devel/elfio: Updated from 1.0.3 to 3.3.

Added a new port for ELFIO v3.x as it is incompatible with the existing v1.x.x

devel/elfio is unmaintained and no ports depend on it. Why not update it to 3.x instead of adding a new port? Is there a reason devel/elfio needs to stay at 1.x?

Apr 14 2019, 2:54 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com added inline comments to D19899: devel/picojson: New port.
Apr 14 2019, 2:35 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com updated the diff for D19899: devel/picojson: New port.

Updated Makefile as suggested by tobik;
Removed ALL_TARGET=
Added NO_BUILD= yes
Added TEST_TARGET= check
Moved 'OPTIONS' variables down for correct ordering

Apr 14 2019, 2:33 PM · Contributor Reviewers (ports)
tobik requested changes to D19879: devel/elfio: Updated from 1.0.3 to 3.3.
Apr 14 2019, 6:15 AM · Contributor Reviewers (ports)
tobik added a comment to D19879: devel/elfio: Updated from 1.0.3 to 3.3.

Added a new port for ELFIO v3.x as it is incompatible with the existing v1.x.x

Apr 14 2019, 6:15 AM · Contributor Reviewers (ports)
tobik requested changes to D19899: devel/picojson: New port.
Apr 14 2019, 6:07 AM · Contributor Reviewers (ports)

Apr 13 2019

james.wright_digital-chaos.com added a reviewer for D19879: devel/elfio: Updated from 1.0.3 to 3.3: tcberner.
Apr 13 2019, 8:39 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com updated the diff for D19879: devel/elfio: Updated from 1.0.3 to 3.3.

Added elfio3 directory to devel/Makefile
Added myself as maintainer

Apr 13 2019, 8:38 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com updated the diff for D19899: devel/picojson: New port.

Added picojson subdirectory to devel/Makefile
Added myself as maintainer of this port

Apr 13 2019, 3:55 PM · Contributor Reviewers (ports)
tcberner requested changes to D19899: devel/picojson: New port.

The port needs to be hooked into devel/Makefile

Apr 13 2019, 3:26 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com updated the summary of D19899: devel/picojson: New port.
Apr 13 2019, 3:17 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com created D19899: devel/picojson: New port.
Apr 13 2019, 3:15 PM · Contributor Reviewers (ports)
greg_unrelenting.technology created D19897: Do not overwrite DISTNAME when USE_GITLAB=nodefault.
Apr 13 2019, 1:39 PM · Contributor Reviewers (ports)

Apr 12 2019

james.wright_digital-chaos.com updated the summary of D19879: devel/elfio: Updated from 1.0.3 to 3.3.
Apr 12 2019, 2:12 PM · Contributor Reviewers (ports)

Apr 10 2019

james.wright_digital-chaos.com created D19879: devel/elfio: Updated from 1.0.3 to 3.3.
Apr 10 2019, 8:29 PM · Contributor Reviewers (ports)

Apr 8 2019

dbaio removed a member for Contributor Reviewers (ports): dbaio.
Apr 8 2019, 7:11 PM

Feb 25 2019

brooks closed D19068: devel/llvm70, devel/llvm80: fix libclangDoc.a installation, install clang-doc80.
Feb 25 2019, 7:29 PM · Contributor Reviewers (ports)