Page MenuHomeFreeBSD

Contributor Reviewers (ports)Tag
ActivePublic

Details

Description

A group that committers can join (opt-in to) to be notified of revisions created by contributors (non-committers).

Perfect for grooming and teaching proactive contributors for future mentorship.

Recent Activity

Wed, Nov 6

lwhsu closed D22238: sysutils/apache-mesos: Fix build for breaking change in grpc dependency.
Wed, Nov 6, 6:14 PM · Contributor Reviewers (ports)

Tue, Nov 5

james.wright_digital-chaos.com updated the summary of D22238: sysutils/apache-mesos: Fix build for breaking change in grpc dependency.
Tue, Nov 5, 2:15 AM · Contributor Reviewers (ports)
james.wright_digital-chaos.com created D22238: sysutils/apache-mesos: Fix build for breaking change in grpc dependency.
Tue, Nov 5, 2:12 AM · Contributor Reviewers (ports)

Fri, Nov 1

ehaupt accepted D22204: editors/linux-sublime3: Updated to 3.2.2 (Build 3211).
  • poudriere builds look good
  • I used the new version for an entire day without any issues
Fri, Nov 1, 7:25 AM · Contributor Reviewers (ports)

Thu, Oct 31

james.wright_digital-chaos.com created D22204: editors/linux-sublime3: Updated to 3.2.2 (Build 3211).
Thu, Oct 31, 4:49 AM · Contributor Reviewers (ports)

Sun, Oct 27

lwhsu closed D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.
Sun, Oct 27, 6:02 PM · Contributor Reviewers (ports)

Sat, Oct 26

james.wright_digital-chaos.com added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

I would say just add IGNORE_FreeBSD_11= does not build between LICENSE* and *DEPENDS
I'm fine with both, IGNORE would tell people don't really need to try it, while BROKEN will still be built by the package builders.

Sat, Oct 26, 8:47 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com updated the diff for D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Added IGNORE_FreeBSD_11 due to breaking build.

Sat, Oct 26, 8:45 PM · Contributor Reviewers (ports)
lwhsu added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Still fails: https://gist.github.com/987197a48472bfc4790495dfdebab8de
I suggest mark IGNORE on 11 first.

What is best way to do this, I tried adding following block near the bottom of the Makfile but portlint complains about it's position no matter where I put it;

.include <bsd.port.pre.mk>
.if (${OSVERSION} < 1200000)
IGNORE= build fails on FreeBSD 11
.endif

Also should we use BROKEN= rather than IGNORE= for this case?

Sat, Oct 26, 6:08 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Still fails: https://gist.github.com/987197a48472bfc4790495dfdebab8de
I suggest mark IGNORE on 11 first.

Sat, Oct 26, 1:32 PM · Contributor Reviewers (ports)
lwhsu added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Still fails: https://gist.github.com/987197a48472bfc4790495dfdebab8de
I suggest mark IGNORE on 11 first.

Sat, Oct 26, 9:18 AM · Contributor Reviewers (ports)

Fri, Oct 25

lwhsu added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

I've purged my poudriere's pkg repository of 11 and kicked out a new test.

Fri, Oct 25, 7:55 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

BTW, it fails to build on 11: https://gist.github.com/3d72c1ad6338657c385a86ec8bbb2526
If this is hard to fix, we could consider mark this IGNORE on 11.

Fri, Oct 25, 6:26 PM · Contributor Reviewers (ports)

Wed, Oct 23

lwhsu added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

This patch build failed in poudriere: https://gist.github.com/5919089c2e8d247342cf9a8749df7ca7
I added these files in include/ to pkg-plist and it pass the poudriere test. Is that the right fix? (these files need to be installed and installed to the right place)

The orphaned files mentioned in that poudriere log were header files I deliberately excluded from the pkg-plist, as I think they are for internal libs and headers only required during the build process, so didn't need to be included in the final package.

Wed, Oct 23, 2:46 AM · Contributor Reviewers (ports)
james.wright_digital-chaos.com updated the diff for D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Updated pkg-plist to include missing header files.

Wed, Oct 23, 2:20 AM · Contributor Reviewers (ports)

Tue, Oct 22

james.wright_digital-chaos.com added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

This patch build failed in poudriere: https://gist.github.com/5919089c2e8d247342cf9a8749df7ca7
I added these files in include/ to pkg-plist and it pass the poudriere test. Is that the right fix? (these files need to be installed and installed to the right place)

Tue, Oct 22, 9:18 PM · Contributor Reviewers (ports)
lwhsu added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Updated pkg-plist: https://gist.github.com/cc17d08532e48039d9c5c30fc2a145f9

Tue, Oct 22, 8:44 PM · Contributor Reviewers (ports)
lwhsu added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

This patch build failed in poudriere: https://gist.github.com/5919089c2e8d247342cf9a8749df7ca7

Tue, Oct 22, 8:43 PM · Contributor Reviewers (ports)

Oct 4 2019

james.wright_digital-chaos.com updated the diff for D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.
  • Updated port to 1.9.0
  • Added databases/leveldb dependency
  • Added devel/elfio dependency
  • Added www/http-parser dependency
  • Additional patches to fix compile errors
  • Removed CLI option (always installed)
Oct 4 2019, 2:57 AM · Contributor Reviewers (ports)

Sep 23 2019

tadeusz.struk_intel.com added a comment to D21770: security/tpm2-abrmd: update default TCTI config.

I'll commit with minor fixes.

Sep 23 2019, 10:50 PM · Contributor Reviewers (ports)
lwhsu closed D21770: security/tpm2-abrmd: update default TCTI config.
Sep 23 2019, 8:24 PM · Contributor Reviewers (ports)
lwhsu accepted D21770: security/tpm2-abrmd: update default TCTI config.

I'll commit with minor fixes.

Sep 23 2019, 8:23 PM · Contributor Reviewers (ports)
lwhsu retitled D21770: security/tpm2-abrmd: update default TCTI config from security/abrmd: update default TCTI config to security/tpm2-abrmd: update default TCTI config.
Sep 23 2019, 7:55 PM · Contributor Reviewers (ports)
tadeusz.struk_intel.com created D21770: security/tpm2-abrmd: update default TCTI config.
Sep 23 2019, 6:20 PM · Contributor Reviewers (ports)

Sep 22 2019

lbartoletti_tuxfamily.org added a member for Contributor Reviewers (ports): lbartoletti_tuxfamily.org.
Sep 22 2019, 12:04 PM

Sep 18 2019

james.wright_digital-chaos.com added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Still:

====> Running Q/A tests (stage-qa)
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-ps'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-tail'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-scp'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-cat'
*** Error code 1

The problem is those files under bin/ need Python, are installed even when CLI is not defined, while python:run and shebangfix are only defined when CLI is on.
So, the possible solution is either only install these files when CLI is defined, or having python:run and shebangfix defined globally.

Sep 18 2019, 10:32 PM · Contributor Reviewers (ports)
lwhsu added a member for Contributor Reviewers (ports): lwhsu.
Sep 18 2019, 9:08 PM
lwhsu added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Because python is used for those bin/* files, the quickest way is moving python:run to USE=, however, I tried this and poudriere gives many Error: Orphaned: include/*.
Can you check this part?

I think the previous errors (regarding python and shebangfix) were caused by a typo in CLI_USES=, I have since updated the diff and they seem to have been resolved.
Please could you run a build through poudriere and let me know if there are any outstanding issues?

Sep 18 2019, 9:08 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Tried moving shebangfix from USES= to CLI_USES= but still get the same error when running make stage-qa.
Please could you provide a suggestion how to fix this issue as I'm stumped as to what is the actual problem here.

Because python is used for those bin/* files, the quickest way is moving python:run to USE=, however, I tried this and poudriere gives many Error: Orphaned: include/*.
Can you check this part?

Sep 18 2019, 8:21 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com updated the diff for D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Makefile changes

  • Fixed typo; CLI_USE= should have been CLI_USES=
  • Added 'shebangfix' to CLI_USES=
  • Removed extraneous whitespace (to satisfy portlint)
Sep 18 2019, 2:48 AM · Contributor Reviewers (ports)

Sep 17 2019

lwhsu added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.
====> Running Q/A tests (stage-qa)
Error: '/usr/local/bin/python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-ps'
Error: '/usr/local/bin/python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-tail'
Error: '/usr/local/bin/python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-cat'
Error: '/usr/local/bin/python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-scp'
*** Error code 1

I think this is because USE=python:run is only defined when CLI option enabled.

Tried moving shebangfix from USES= to CLI_USES= but still get the same error when running make stage-qa.
Please could you provide a suggestion how to fix this issue as I'm stumped as to what is the actual problem here.

Sep 17 2019, 1:20 AM · Contributor Reviewers (ports)

Sep 16 2019

james.wright_digital-chaos.com added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.
====> Running Q/A tests (stage-qa)
Error: '/usr/local/bin/python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-ps'
Error: '/usr/local/bin/python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-tail'
Error: '/usr/local/bin/python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-cat'
Error: '/usr/local/bin/python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-scp'
*** Error code 1

I think this is because USE=python:run is only defined when CLI option enabled.

Sep 16 2019, 12:16 AM · Contributor Reviewers (ports)

Sep 15 2019

james.wright_digital-chaos.com added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

@james.wright_digital-chaos.com: do you want to also submit the patch to the upstream?

Sep 15 2019, 10:13 PM · Contributor Reviewers (ports)

Sep 14 2019

lwhsu requested changes to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

I can build this port in poudriere fine. I think previous error was because of patching issue.

Sep 14 2019, 8:24 PM · Contributor Reviewers (ports)
james.wright_digital-chaos.com added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Sorry for forgetting about this. I didn't added it to my TODO list.
This doesn't build on FreeBSD 12 due to following error:

libtool: compile:  c++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"1.8.1\" "-DPACKAGE_STRING=\"mesos 1.8.1\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" -DVERSION=\"1.8.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_BOOST_VERSION_HPP=1 -DHAVE_LIBCURL=1 -DHAVE_GLOG_LOGGING_H=1 -DHAVE_ARCHIVE_H=1 -DHAVE_GOOGLE_PROTOBUF_MAP_H=1 -DHAVE_EV_H=1 -DHAVE_PICOJSON_H=1 -DHAVE_RAPIDJSON_RAPIDJSON_H=1 -DHAVE_LIBSASL2=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_GRPCPP_GRPCPP_H=1 -DHAVE_ZOOKEEPER_H=1 -I. -DLIBDIR=\"/usr/local/lib\" -DPKGLIBEXECDIR=\"/usr/local/libexec/mesos\" -DPKGDATADIR=\"/usr/local/share/mesos\" -DPKGMODULEDIR=\"/usr/local/lib/mesos/modules\" -I../include -I../include -I../include/mesos -D__STDC_FORMAT_MACROS -I../3rdparty/concurrentqueue-7b69a8f -I../3rdparty/elfio-3.2 -I../3rdparty/leveldb-1.19/include -I../3rdparty/libprocess/include -I../3rdparty/nvml-352.79 -I../3rdparty/stout/include -I/usr/local/include/subversion-1 -I/usr/local/include -I/usr/local/include -I/usr/local/include/apr-1 -I/usr/local/include/apr-1.0 -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/zookeeper -D_THREAD_SAFE -pthread -Wall -Wsign-compare -Wformat-security -fstack-protector-strong -fPIC -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wno-unused-local-typedef -Wno-inconsistent-missing-override -std=c++11 -stdlib=libc++ -DGTEST_HAS_PTHREAD -D_WITH_GETLINE -Wno-sentinel -MT master/libmesos_no_3rdparty_la-constants.lo -MD -MP -MF master/.deps/libmesos_no_3rdparty_la-constants.Tpo -c master/constants.cpp  -fPIC -DPIC -o master/.libs/libmesos_no_3rdparty_la-constants.o
master/allocator/mesos/hierarchical.cpp:1649:5: error: use of undeclared identifier 'random_shuffle'; did you mean 'std::random_shuffle'?
    random_shuffle(resourceVector.begin(), resourceVector.end());
    ^~~~~~~~~~~~~~
    std::random_shuffle
/usr/include/c++/v1/algorithm:3168:1: note: 'std::random_shuffle' declared here
random_shuffle(_RandomAccessIterator __first, _RandomAccessIterator __last)
^
Sep 14 2019, 7:42 PM · Contributor Reviewers (ports)
arrowd added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Sorry for forgetting about this. I didn't added it to my TODO list.

Sep 14 2019, 5:23 PM · Contributor Reviewers (ports)
lwhsu added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

@arrowd: any update on this?
@james.wright_digital-chaos.com: do you want to also submit the patch to the upstream?

Sep 14 2019, 1:57 PM · Contributor Reviewers (ports)

Aug 13 2019

james.wright_digital-chaos.com added inline comments to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.
Aug 13 2019, 1:43 AM · Contributor Reviewers (ports)

Aug 12 2019

arrowd added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Looks good to me. If no one objects, I'll commit this after giving it a run in poudriere.

Aug 12 2019, 9:10 AM · Contributor Reviewers (ports)
arrowd closed D21185: devel/elfio: Updated to 3.4.
Aug 12 2019, 8:59 AM · Contributor Reviewers (ports)

Aug 8 2019

james.wright_digital-chaos.com retitled D21185: devel/elfio: Updated to 3.4 from devel/efio: Updated to 3.4 to devel/elfio: Updated to 3.4.
Aug 8 2019, 1:24 AM · Contributor Reviewers (ports)
james.wright_digital-chaos.com created D21185: devel/elfio: Updated to 3.4.
Aug 8 2019, 1:22 AM · Contributor Reviewers (ports)
james.wright_digital-chaos.com added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Updated to 1.8.1
Added patch to fix compilation error in src/master/allocator/mesos/hierarchical.cpp

Aug 8 2019, 12:45 AM · Contributor Reviewers (ports)

Jun 15 2019

tobik removed a member for Contributor Reviewers (ports): tobik.
Jun 15 2019, 5:57 AM

Jun 8 2019

james.wright_digital-chaos.com added a comment to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Please could take a look over the updated diff, as I appreciate the constructive feedback! :-)

Jun 8 2019, 8:48 PM · Contributor Reviewers (ports)

Jun 2 2019

james.wright_digital-chaos.com updated the diff for D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Makefile changes;

  • Fixed incorrect braces for PORTVERSION
  • Added USES= libtool
  • Added USES= shebangfix and SHEBANG_FILES= (although make stage-qa still seems unhappy with these files?)
  • Added USE_LDCONFIG=yes
  • Added option for installing CLI tools (which require the python runtime)
  • Added option for installing Deploy scripts (which should now install the *.template files as samples)
  • Added --disable-werror flag as suggested
Jun 2 2019, 9:04 PM · Contributor Reviewers (ports)
tobik resigned from D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.
Jun 2 2019, 1:41 PM · Contributor Reviewers (ports)

May 14 2019

mat added inline comments to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.
May 14 2019, 11:47 AM · Contributor Reviewers (ports)
tobik requested changes to D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.
May 14 2019, 7:41 AM · Contributor Reviewers (ports)

May 13 2019

james.wright_digital-chaos.com updated the diff for D20251: [new port] sysutils/apache-mesos: Apache Mesos cluster management software.

Added SUBDIR += apache-mesos to sysutils/Makefile, as requested.

May 13 2019, 8:52 PM · Contributor Reviewers (ports)