In D58339#1341688, @ivy wrote:

we don't want to add manual dependencies on library packages; these are supposed to be handled automatically by pkg. if that's not working properly, it's a bug in pkg(8) and should be fixed there.

additional comments - applied

In D58234#1336907, @salvadore wrote:

I approved the whole report, but there there is something weird with this review, it looks like it is referencing a commit that fixed line 25 instead of a commit that adds the full file.

remark considered

In D58175#1334411, @michaelo wrote:

One nit.

Yes, as you said, change it.

https://docs.asciidoctor.org/asciidoc/latest/sections/bibliography/

In D57999#1330255, @ziaee wrote:

Do you see any problems with them?

It seems you pushed this commit already and it is live on https://docs.freebsd.org/en/books/dev-model/, where the links work. However local build with cd documentation; make, the links do not work, whereas they links do work for local build in handbook. Also, the appearance is wrong for that page because there are padded spaces some places and not other places. Maybe we can do something like \[crossref:dev-model[ref-freebsd-trenches, Lehey 2002]\] for the appearance? I do not know why the links are broken in offline build though.

In D58001#1330236, @bcr wrote:

We can't make changes to past release notes once they are published. They become part of the release hash and would change in a number of places that reference them (even if they contain typos).

In D57725#1323489, @ziaee wrote:

1. 20 is too short. Can we have 50?
2. why does this combine security and errata if we have two separate feeds for that?
3. can we please put the actual content in these?

In D57999#1330069, @ziaee wrote:

In D57999#1330065, @carlavilla wrote:

In D57999#1330057, @ziaee wrote:

Dude you rock! Aside from dev-model, all the changes LGTM.

if the macro is broken, I need to fix it. But I created this macros coz we have these scenarios:

• Online website (freebsd.org, docs.freebsd.org)
• Offline website
• PDFs

It works everywhere else I checked except dev-model.

In D57998#1329898, @ziaee wrote:

Thank you so much, I've tried various things and was unable to get to the bottom of this myself!

In D57722#1323579, @ziaee wrote:

Can we fix https://www.freebsd.org/status/feed.xml instead of adding a new one?

I do not see anything wrong, and my spell checker too.
LGFM.