Page MenuHomeFreeBSD

Fix HTML validation errors in site header
ClosedPublic

Authored by vladlen on Sat, Sep 26, 10:43 AM.
Tags
Referenced Files
F173619743: D60039.diff
Sun, Sep 27, 5:41 AM
F173605709: D60039.id.diff
Sun, Sep 27, 3:36 AM
F173600524: D60039.id187743.diff
Sun, Sep 27, 2:48 AM
F173552825: D60039.id187732.diff
Sat, Sep 26, 7:35 PM
F173524550: D60039.id187743.diff
Sat, Sep 26, 2:25 PM
F173517124: D60039.diff
Sat, Sep 26, 12:59 PM
F173510639: D60039.diff
Sat, Sep 26, 11:44 AM
F173507997: D60039.id187732.diff
Sat, Sep 26, 11:16 AM
Subscribers
None

Details

Summary

Documentation pages emit "The element label must not appear as a
descendant of the a element" for every top-level menu item, because
each label is wrapped in <a href="#">.

Apply the same fix already merged for the website in a8654f311
("Website: Fix HTML validation errors"):

  • drop the wrapping anchor and
  • extend the existing .menu-item a rules to .menu-item-description,

so the label keeps the same appearance and the sub-menu hover still works.

  • header.css: add .menu-item-description to the rules that previously targeted .menu-item a only (padding/color, text-decoration, font-weight, :hover, and the +.sub-menu hover trigger), in both the desktop and max-width: 1100px blocks.
  • site-header.html: remove the <a href="#" aria-label="..."> wrapper around each <label class="menu-item-description">.

No visual changes expected — mirrors the website fix.

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vladlen created this revision.
This revision is now accepted and ready to land.Sat, Sep 26, 12:41 PM
This revision was automatically updated to reflect the committed changes.