Page MenuHomeFreeBSD

carlavilla (Sergio Carlavilla)
User

Projects

User Details

User Since
Nov 1 2019, 8:56 PM (187 w, 4 d)

Recent Activity

Thu, May 25

carlavilla accepted D40164: Show that 13.2 is the preferred release and 12.4/13.1 are legacy.

Sorry, forgot about that, I'll take a look tomorrow. But looks good

Thu, May 25, 7:52 PM

Tue, May 23

carlavilla added a comment to D40164: Show that 13.2 is the preferred release and 12.4/13.1 are legacy.

Sorry, forgot about that, I'll take a look tomorrow. But looks good.

Tue, May 23, 7:41 PM
carlavilla added a comment to D40217: Update handbook/pkg-files#pkg-message to use sysrc and service .

Np :)

Tue, May 23, 7:32 PM
carlavilla accepted D40217: Update handbook/pkg-files#pkg-message to use sysrc and service .
Tue, May 23, 7:29 PM
carlavilla accepted D40232: developers-handbook: Remove source code layout.

LGTM

Tue, May 23, 5:27 PM

Tue, May 9

carlavilla added a comment to D40026: Git and related corrections and improvements.

Guau, I'll send an email to developers@ with that...

Tue, May 9, 8:40 PM
carlavilla added a comment to D40026: Git and related corrections and improvements.
In D40026#911545, @bofh wrote:

Don't use "you", I know is used across the documentation, but the idea is to remove the use of it

@carlavilla The idea of removing doesn't look too promising. :/

❯ find . -type f -name "*.adoc" -exec grep -i -E '\syou\s' {} \+ | wc -l
   15453

Do you want me to writ a vale rule? 3:)

Tue, May 9, 7:26 PM
carlavilla added inline comments to D40026: Git and related corrections and improvements.
Tue, May 9, 6:56 PM

May 8 2023

carlavilla closed D39836: Handbook WG - kernelconfig.
May 8 2023, 2:01 PM
carlavilla committed R9:2c95a546791c: Handbook - kernelconfig: Global review (authored by carlavilla).
Handbook - kernelconfig: Global review
May 8 2023, 2:01 PM
carlavilla updated the diff for D39836: Handbook WG - kernelconfig.
May 8 2023, 6:38 AM

May 7 2023

carlavilla committed R9:8995ee8abef0: Safekeep sam's src bit (authored by carlavilla).
Safekeep sam's src bit
May 7 2023, 7:30 PM
carlavilla updated the diff for D39836: Handbook WG - kernelconfig.
May 7 2023, 7:17 PM
carlavilla added inline comments to D39836: Handbook WG - kernelconfig.
May 7 2023, 7:17 PM

May 4 2023

carlavilla updated the diff for D39836: Handbook WG - kernelconfig.
May 4 2023, 6:38 PM
carlavilla added inline comments to D39836: Handbook WG - kernelconfig.
May 4 2023, 6:38 PM

May 3 2023

carlavilla closed D39666: Handbook WG - linuxemu.
May 3 2023, 6:42 PM
carlavilla committed R9:fa6d03936edf: Handbook - linuxemu: Chapter upgrade (authored by carlavilla).
Handbook - linuxemu: Chapter upgrade
May 3 2023, 6:42 PM
carlavilla accepted D39944: fdp-primer/working-copy: Improve git installation instructions.
May 3 2023, 7:39 AM

May 2 2023

carlavilla updated the diff for D39836: Handbook WG - kernelconfig.

Fix almost all the comments :)

May 2 2023, 7:57 PM
carlavilla added inline comments to D39836: Handbook WG - kernelconfig.
May 2 2023, 7:56 PM
carlavilla accepted D39703: vale/style: Utilize vales vocabulary engine.

Works for me, approved.
Thanks for your work on this.

May 2 2023, 6:39 PM
carlavilla accepted D39800: fdp-primer/writing-style: Refactor after adding new Vale rules.

Sorry for the delay, if this happens again, ping me by email

May 2 2023, 6:38 PM
carlavilla accepted D39847: fdp-primer: Add trademarks.

Sorry for the delay, if this happens again, ping me by email

May 2 2023, 6:37 PM
carlavilla added inline comments to D39666: Handbook WG - linuxemu.
May 2 2023, 6:32 PM
carlavilla updated the diff for D39666: Handbook WG - linuxemu.
May 2 2023, 6:30 PM

May 1 2023

carlavilla added inline comments to D39666: Handbook WG - linuxemu.
May 1 2023, 4:56 PM
carlavilla added inline comments to D39666: Handbook WG - linuxemu.
May 1 2023, 4:39 PM
carlavilla updated the diff for D39666: Handbook WG - linuxemu.
May 1 2023, 2:40 PM
carlavilla added inline comments to D39666: Handbook WG - linuxemu.
May 1 2023, 2:40 PM

Apr 26 2023

carlavilla requested review of D39836: Handbook WG - kernelconfig.
Apr 26 2023, 7:46 PM
carlavilla accepted D39801: documentation/themes/beastie/i18n/it.toml: Various improvements.
Apr 26 2023, 7:16 PM
carlavilla committed R9:c7bab51fa4fa: Handbook - Multimedia: Fix cmd for loading cuse kmod in rc.conf (authored by lme).
Handbook - Multimedia: Fix cmd for loading cuse kmod in rc.conf
Apr 26 2023, 6:54 PM
carlavilla committed R9:4af55c4705ae: Handbook - Desktop: Remove Gnome services instructions (authored by yklaxds_gmail.com).
Handbook - Desktop: Remove Gnome services instructions
Apr 26 2023, 6:45 PM
carlavilla closed D39580: The gnome service does not exist.
Apr 26 2023, 6:44 PM
carlavilla accepted D39580: The gnome service does not exist.
Apr 26 2023, 6:44 PM
carlavilla updated the diff for D39666: Handbook WG - linuxemu.

Everything fixed :)
I'll wait a couple of days and I'll make the commit

Apr 26 2023, 6:10 PM
carlavilla added inline comments to D39666: Handbook WG - linuxemu.
Apr 26 2023, 6:09 PM

Apr 24 2023

carlavilla updated the diff for D39666: Handbook WG - linuxemu.
Apr 24 2023, 6:21 PM
carlavilla added inline comments to D39666: Handbook WG - linuxemu.
Apr 24 2023, 6:20 PM
carlavilla added a comment to D39703: vale/style: Utilize vales vocabulary engine.

ACK, I'll take a look this night

Apr 24 2023, 3:42 PM
carlavilla accepted D39704: vale/styles: Remove Repitition rule.
Apr 24 2023, 3:41 PM
carlavilla added a comment to D39569: Vale: Add rule to avoid redundant link.
In D39569#904486, @bofh wrote:

Macro shipit:

We can always rename the rules as it's just changing the file name and updating the .vale.ini file. It's not too big of a hassle.

Apr 24 2023, 3:41 PM
carlavilla accepted D39569: Vale: Add rule to avoid redundant link.
Apr 24 2023, 3:40 PM

Apr 19 2023

carlavilla accepted D39702: vale/styles: Add BlockIgnore for [.programlisting].

Thanks, yes, this comes from Docbook, a CSS style

Apr 19 2023, 7:17 PM
carlavilla accepted D39701: vale.styles: Enable EOLSpacing Rule for all languages.
Apr 19 2023, 7:17 PM
carlavilla accepted D39700: vale/styles: Disable SemanticLineBreak Rule for non-english languages.

Ok, we can handle it by language, good idea

Apr 19 2023, 6:55 PM
carlavilla accepted D39694: vale/styles: Replace FreeBSD Custom Dictionary with Vales dictionary.

Thanks for taking care of this :)

Apr 19 2023, 6:33 PM
carlavilla accepted D39560: Add Semantic Line Break checking with vale.
Apr 19 2023, 6:32 PM · doceng
carlavilla added a comment to D39569: Vale: Add rule to avoid redundant link.

The link: macro prefix is not required when the target starts with a URL scheme like https:.

The prefix is commonplace in status reports, it should be a rarity elsewhere.

It's not required, but can be used.
This rule is gonna be used in all parts of the documentation.

Actually, the FreeBSD Documentation Primer even recommends using link::

As the AsciiDoctor documentation describes, the link macro is not required when the target starts with a URL scheme like https. However, it is a good practice to do this anyway to ensure that AsciiDoctor renders the link correctly, especially in non-latin languages like Japanese.

https://docs.freebsd.org/en/books/fdp-primer/book/#asciidoctor-links-external

Apr 19 2023, 10:17 AM
carlavilla added a comment to D39569: Vale: Add rule to avoid redundant link.

The link: macro prefix is not required when the target starts with a URL scheme like https:.

The prefix is commonplace in status reports, it should be a rarity elsewhere.

Apr 19 2023, 10:03 AM
carlavilla accepted D39686: Status/2023Q1/_index.adoc: Add missing report.
Apr 19 2023, 9:27 AM
carlavilla accepted D39569: Vale: Add rule to avoid redundant link.
Apr 19 2023, 7:55 AM
carlavilla added a comment to D39569: Vale: Add rule to avoid redundant link.
In D39569#903020, @bofh wrote:

… what do you suggest? …

If I understand correctly, this rule is oriented to the current workflow for status reports, so maybe:

RedundantLinks-status.yml

– or:

RedundantURIs-status.yml

@salvadore your thoughts?


In parallel, I'll aim to learn more about vale in general.

Apr 19 2023, 7:55 AM

Apr 18 2023

carlavilla added a comment to D39569: Vale: Add rule to avoid redundant link.

Works for me, but please, about making the changes in the 3339 files, please contact first doceng@

Apr 18 2023, 6:24 PM
carlavilla accepted D39569: Vale: Add rule to avoid redundant link.

Works for me, but please, about making the changes in the 3339 files, please contact first doceng@

Apr 18 2023, 6:24 PM
carlavilla added a comment to D37404: wg.8: Rewrite the manual page.

@gbe do you need some help to move this forward :)?

Apr 18 2023, 6:20 PM
carlavilla requested review of D39666: Handbook WG - linuxemu.
Apr 18 2023, 6:18 PM
carlavilla accepted D39560: Add Semantic Line Break checking with vale.
Apr 18 2023, 6:12 PM · doceng
carlavilla committed R9:3276b4816130: Safekeep eadler's src bit per his request (authored by carlavilla).
Safekeep eadler's src bit per his request
Apr 18 2023, 4:07 PM
carlavilla committed R9:077503599e76: Safekeep n_hibma's src bit per his request (authored by carlavilla).
Safekeep n_hibma's src bit per his request
Apr 18 2023, 3:55 PM
carlavilla added a comment to D39632: misc/freebsd-doc-*: Enable HTML in all languages and Simplify ports.

until hugo doesn't allow disabling the default language, yes

Apr 18 2023, 2:25 PM
carlavilla accepted D39651: Status/2023Q1/cloud-init.adoc: Remove duplicate `the`.
Apr 18 2023, 11:55 AM
carlavilla added a reviewer for D37404: wg.8: Rewrite the manual page: carlavilla.
Apr 18 2023, 9:45 AM
carlavilla accepted D39642: Status/2023Q1: Improvements.
Apr 18 2023, 9:38 AM

Apr 17 2023

carlavilla added a comment to D39569: Vale: Add rule to avoid redundant link.

I'll try to take a look to this tomorrow.
Also to the other review related to vale

Apr 17 2023, 4:30 PM
carlavilla accepted D39618: website/content/en/security/: Add releng/13.2.
Apr 17 2023, 2:35 PM
carlavilla accepted D39602: 2023Q1/Status: Add intro.adoc.
Apr 17 2023, 2:27 PM
carlavilla accepted D39616: Status/2023Q1: Add it to the status reports list.
Apr 17 2023, 2:26 PM
carlavilla accepted D39617: News: Announce 2023Q1 Status Report.
Apr 17 2023, 2:26 PM
carlavilla accepted D39618: website/content/en/security/: Add releng/13.2.
Apr 17 2023, 2:26 PM

Apr 16 2023

carlavilla added a comment to D39602: 2023Q1/Status: Add intro.adoc.

LGTM, only two minor things, the first is a total personal thing

Apr 16 2023, 2:13 PM
carlavilla accepted D39401: Status/2023Q1: Sort reports.
Apr 16 2023, 1:57 PM

Apr 12 2023

carlavilla committed R9:720405b52b53: Welcome Fernando as a new Doceng member (authored by carlavilla).
Welcome Fernando as a new Doceng member
Apr 12 2023, 6:29 PM
carlavilla committed R9:a781a51ba934: Remove ryusuke as a Doceng member (authored by carlavilla).
Remove ryusuke as a Doceng member
Apr 12 2023, 6:25 PM
carlavilla committed R9:81741c620708: Safekeep ryusuke's doc bit per his request (authored by carlavilla).
Safekeep ryusuke's doc bit per his request
Apr 12 2023, 6:24 PM
carlavilla accepted D39474: FreeBSD Handbook: OS upgrades: kernel modules.

LGTM.

Let's think about where to reintroduce the PORTS_MODULES information and point there from this warning in a future change.

Apr 12 2023, 4:57 PM
carlavilla added a comment to D39474: FreeBSD Handbook: OS upgrades: kernel modules.

Related to this, I think the best advice would be to use PORTS_MODULES in /etc/make.conf.
Unfortunately this piece of information has gone away in the last revamp of the X11 chapter of the handbook.
I think we should get it back.

What part? No problem to get it back, let me know the part and I'll add it again

It would be this.
However, although it talks about a graphic driver, it is more general and it is related to updating from sources. So maybe that piece should go near here.
I don't know if pkg(8) has a similar system that would trigger the rebuild of a module if the system is binary updated (as with freebsd-update).

Apr 12 2023, 4:51 PM
carlavilla added a comment to D39474: FreeBSD Handbook: OS upgrades: kernel modules.

Related to this, I think the best advice would be to use PORTS_MODULES in /etc/make.conf.
Unfortunately this piece of information has gone away in the last revamp of the X11 chapter of the handbook.
I think we should get it back.

Apr 12 2023, 4:34 PM

Apr 11 2023

carlavilla committed R9:813a55dbd5ce: Handbook - Introduction: Upgrade main page to show FreeBSD 13.2 rel (authored by carlavilla).
Handbook - Introduction: Upgrade main page to show FreeBSD 13.2 rel
Apr 11 2023, 7:37 PM
carlavilla accepted D39506: shared/contrib-additional.adoc: Add Chih-Hsin Chang.
Apr 11 2023, 4:05 PM
carlavilla accepted D39401: Status/2023Q1: Sort reports.

If you make more changes tl the document, don't wait for my approval.

Apr 11 2023, 3:35 PM

Apr 10 2023

carlavilla committed R9:1350d809a151: Porters handbook - Quick porting: Fix typo, avoid repetition (authored by carlavilla).
Porters handbook - Quick porting: Fix typo, avoid repetition
Apr 10 2023, 1:09 PM
carlavilla committed R9:ab02cc01081f: Clean consulting vendors (authored by carlavilla).
Clean consulting vendors
Apr 10 2023, 1:01 PM
carlavilla committed R9:93b778f98de5: Website: Fix warning related to Hugo's Lookup Order (authored by carlavilla).
Website: Fix warning related to Hugo's Lookup Order
Apr 10 2023, 12:44 PM
carlavilla added inline comments to D39479: FDP: Add section about Text formatting.
Apr 10 2023, 12:14 PM
carlavilla added a comment to D39479: FDP: Add section about Text formatting.

For what it's worth, I'd refer to https://docs.asciidoctor.org/asciidoc/latest/syntax-quick-reference/#text-formatting instead of enlarging a primer that is already, to my eye, way too large to be thought of as a primer


Please, don't take this personally. Wherever I see the opposite of concise: I always think of extensive pruning, but I rarely share the thought …

Apr 10 2023, 12:14 PM
carlavilla updated the summary of D39479: FDP: Add section about Text formatting.
Apr 10 2023, 10:39 AM
carlavilla requested review of D39479: FDP: Add section about Text formatting.
Apr 10 2023, 10:39 AM
carlavilla committed R9:d8b25aa8583d: Design - Improve 'code' tag render (authored by carlavilla).
Design - Improve 'code' tag render
Apr 10 2023, 8:58 AM
carlavilla committed R9:a6a08d99bf12: Increase Hugo timeout for offline build (authored by carlavilla).
Increase Hugo timeout for offline build
Apr 10 2023, 8:52 AM
carlavilla committed R9:b31c144ef2ad: Porters handbook - flavors: Fix italic render (authored by carlavilla).
Porters handbook - flavors: Fix italic render
Apr 10 2023, 8:51 AM
carlavilla updated subscribers of D34747: ls(1): Add -g, -n, and -o options for POSIX standard.

@emaste @jhb can you please take a look and give the approval from src?

Apr 10 2023, 8:28 AM
carlavilla closed D39475: Remove "Intel(R) based Mac" description in virtualization chapter..
Apr 10 2023, 8:25 AM · docs
carlavilla committed R9:cbd76fe50cda: Handbook - Virtualization: Remove "Intel(R) based Mac" (authored by fel1x.mintchoco.development_gmail.com).
Handbook - Virtualization: Remove "Intel(R) based Mac"
Apr 10 2023, 8:25 AM

Apr 9 2023

carlavilla committed R9:7ed8b009a6b3: Design - tables align text to top (authored by carlavilla).
Design - tables align text to top
Apr 9 2023, 6:14 PM
carlavilla closed D39468: Handbook: Apple Silicon virtualization on VMware Fusion and Parallels Desktop.
Apr 9 2023, 5:58 PM · docs
carlavilla committed R9:14c7f1d5e39e: Handbook - Virtualization: Remove 'Intel-based' from Apple (authored by fel1x.mintchoco.development_gmail.com).
Handbook - Virtualization: Remove 'Intel-based' from Apple
Apr 9 2023, 5:58 PM
carlavilla committed R9:f8639b9b29c8: Porters - Quick Porting: Upgrade FTP url to a working one (authored by carlavilla).
Porters - Quick Porting: Upgrade FTP url to a working one
Apr 9 2023, 5:52 PM
carlavilla added a comment to D39470: Handbook: Update virtualization chapter for Parallels Desktop.

Thanks, I made some little tweaks to your patch.
Btw, thanks for it!

Apr 9 2023, 5:46 PM · docs