Sorry, forgot about that, I'll take a look tomorrow. But looks good

Sorry, forgot about that, I'll take a look tomorrow. But looks good.

Np :)

LGTM

Guau, I'll send an email to developers@ with that...

In D40026#911545, @bofh wrote:

Don't use "you", I know is used across the documentation, but the idea is to remove the use of it

@carlavilla The idea of removing doesn't look too promising. :/

❯ find . -type f -name "*.adoc" -exec grep -i -E '\syou\s' {} \+ | wc -l
   15453

Do you want me to writ a vale rule? 3:)

Fix almost all the comments :)

Works for me, approved.
Thanks for your work on this.

Sorry for the delay, if this happens again, ping me by email

Sorry for the delay, if this happens again, ping me by email

Everything fixed :)
I'll wait a couple of days and I'll make the commit

ACK, I'll take a look this night

In D39569#904486, @bofh wrote:

We can always rename the rules as it's just changing the file name and updating the .vale.ini file. It's not too big of a hassle.

Thanks, yes, this comes from Docbook, a CSS style

Ok, we can handle it by language, good idea

Thanks for taking care of this :)

In D39569#903119, @salvadore wrote:

In D39569#903116, @carlavilla wrote:

In D39569#903115, @grahamperrin wrote:

The link: macro prefix is not required when the target starts with a URL scheme like https:.

The prefix is commonplace in status reports, it should be a rarity elsewhere.

It's not required, but can be used.
This rule is gonna be used in all parts of the documentation.

Actually, the FreeBSD Documentation Primer even recommends using link::

As the AsciiDoctor documentation describes, the link macro is not required when the target starts with a URL scheme like https. However, it is a good practice to do this anyway to ensure that AsciiDoctor renders the link correctly, especially in non-latin languages like Japanese.

https://docs.freebsd.org/en/books/fdp-primer/book/#asciidoctor-links-external

In D39569#903115, @grahamperrin wrote:

The link: macro prefix is not required when the target starts with a URL scheme like https:.

The prefix is commonplace in status reports, it should be a rarity elsewhere.

In D39569#903032, @grahamperrin wrote:

In D39569#903020, @bofh wrote:

… what do you suggest? …

If I understand correctly, this rule is oriented to the current workflow for status reports, so maybe:

RedundantLinks-status.yml

– or:

RedundantURIs-status.yml

@salvadore your thoughts?

---

In parallel, I'll aim to learn more about vale in general.

In D39569#902654, @carlavilla wrote:

Works for me, but please, about making the changes in the 3339 files, please contact first doceng@

Works for me, but please, about making the changes in the 3339 files, please contact first doceng@

@gbe do you need some help to move this forward :)?

until hugo doesn't allow disabling the default language, yes

I'll try to take a look to this tomorrow.
Also to the other review related to vale

LGTM, only two minor things, the first is a total personal thing

In D39474#899962, @fernape wrote:

LGTM.

Let's think about where to reintroduce the PORTS_MODULES information and point there from this warning in a future change.

In D39474#899951, @fernape wrote:

In D39474#899927, @carlavilla wrote:

In D39474#899925, @fernape wrote:

Related to this, I think the best advice would be to use PORTS_MODULES in /etc/make.conf.
Unfortunately this piece of information has gone away in the last revamp of the X11 chapter of the handbook.
I think we should get it back.

What part? No problem to get it back, let me know the part and I'll add it again

It would be this.
However, although it talks about a graphic driver, it is more general and it is related to updating from sources. So maybe that piece should go near here.
I don't know if pkg(8) has a similar system that would trigger the rebuild of a module if the system is binary updated (as with freebsd-update).

In D39474#899925, @fernape wrote:

Related to this, I think the best advice would be to use PORTS_MODULES in /etc/make.conf.
Unfortunately this piece of information has gone away in the last revamp of the X11 chapter of the handbook.
I think we should get it back.

If you make more changes tl the document, don't wait for my approval.

In D39479#898749, @grahamperrin wrote:

For what it's worth, I'd refer to https://docs.asciidoctor.org/asciidoc/latest/syntax-quick-reference/#text-formatting instead of enlarging a primer that is already, to my eye, way too large to be thought of as a primer …

---

Please, don't take this personally. Wherever I see the opposite of concise: I always think of extensive pruning, but I rarely share the thought …

@emaste @jhb can you please take a look and give the approval from src?

Thanks, I made some little tweaks to your patch.
Btw, thanks for it!