Go ahead with the revert

In D35112#796835, @pauamma_gundo.com wrote:

In D35112#796818, @carlavilla wrote:

The committer’s guide is right. You need an approval from a doc committer.
Another history is if you can make a commit with the approval of Pau Amma. For me there’s no problem. But this is an exception, not a rule that should be added to the committer’s guide.
PS: The Pau Amma’s approval is a personal opinion. Not from the Doceng.

Just to be clear: docs gives the author more reviewers. That's where (and how) I come in. Per discussion with... I think it was @kevans in an earlier review, I'm allowed to approve on docs' and manpages' behalf in addition to my own, and that indeed doesn't mean a doc committer approved anything, or even knows of the review. So perhaps, in addition to the Committer's guide procedures, which I'm actually not talking about, listing both docs and the Doc committers group in Group Reviewers may make it clearer who does what?

The committer’s guide is right. You need an approval from a doc committer.
Another history is if you can make a commit with the approval of Pau Amma. For me there’s no problem. But this is an exception, not a rule that should be added to the committer’s guide.
PS: The Pau Amma’s approval is a personal opinion. Not from the Doceng.

Approved from docs

Approved from docs

@salvadore Just fixed the issue with the daemon-news trademark. Thanks for this!

In D34942#793314, @salvadore wrote:

I have removed the spaces that I added by mistakes.

As for the non translated sentences, I checked the Spanish translation but I think that, consistently with the Italian translation conventions that we established with madpilot, we prefer to leave them as they are: I am going to wait for his review and see if he confirms.

Apart from the inline comments. Thanks for this!
And don't worry with this change. You're not gonna break anything. It's ok :)

Committed

Committed

Since I based my patch in your patch, I'll make the commit with the attribution to you :)

I just created another revision to handle the macOS addition.
It's here: https://reviews.freebsd.org/D34752
@fel1x.mintchoco.development_gmail.com if your ok with this new revision I'll commit it.
Are the instructions ok? I removed the brew installation command since the idea of this documentation it's to help the user to build the documentation in macOS not to install brew.

I like this addition. Thanks :)
I'm gonna merge it.

No, only for MacOS.
Thanks!

If @pauamma_gundo.com it's ok, I'll commit the changes.
Thanks for taking care of this :)

I'll take this. Thanks for this upgrade :)

@fel1x.mintchoco.development_gmail.com can you please prepare a section like this Add instructions to build the website using GNU/Linux ?

This night I'll commit this change.
I think it's a good addition to the FDP.
We can improve in the future.

Done @pauamma_gundo.com

In D34099#773228, @pauamma_gundo.com wrote:

In D34099#773197, @carlavilla wrote:

What do you mean with "s/the //"?
I don't know why but the link does not work :s

I meant: remove "the " on that line. The link doesn't work because you didn't upload full context, as @debdrup already mentioned. Are you using the web interface to Phabricator to submit diffs?

In D34099#773180, @pauamma_gundo.com wrote:

Still can't suggest edits.

Fixed!

In D34004#770828, @trasz wrote:

In D34004#770417, @debdrup wrote:

In D34004#770198, @trasz wrote:

Yeah, I'll submit the other changes for separate reviews.

Regarding "Installer images" - problem is, not all of those are installer images. I wonder if I should perhaps split off SD card images like it was before...

Also: is there a way to make cells vertically aligned up, as opposed to vertically centered, as it is now? The example from AsciiDoc didn't seem to work for some reason.

I'm a bit confused about what you mean by installer image vs cd images - if I look at https://www.freebsd.org/where/#download-rel130 the SD card images are separate from the installer images.

Right - and in the table this patch introduces they are no longer separate. I've tried with additional column, but that looks weird - it becomes both overcrowded and sparse at the same time.

I think we're gonna have to ask @carlavilla - I spent some time trying to figure out why the AsciiDoc example (I assume that's the one you're talking about) isn't working, but don't really have a clue except that it might be in doc/website/themes/beastie/layouts?

Yeah. I've tried to inspect the resulting web page, but I have no idea where the vertical centering comes from; I also have no idea why the top margin within the table cell looks somewhat larger than I'd like it to be.

Generally speaking, at this time, my main problem with this layout is that it's _huge_. Even a single table like this looks big, and we'd need six of those.

A little note. The "tip" will be removed in a couple of months. When hugo 0.90 version will be older.
I know the website/documentation also works well on MacOS, but right now I don't have access to a MacOS machine.
If someone can test it again it would be great :)

In D30176#769702, @ygy wrote:

I will run some tests on macOS as well and report here.

With the new documentation portal we can build it in MacOS and GNU/Linux.

Sorry for the looooooooong delay.
The file is: https://cgit.freebsd.org/doc/tree/website/themes/beastie/layouts/shortcodes/form-search-mail.html

Personally, I like this approach. Wait until more please share their thoughts :)

Thanks for this.
But before making the commit. Why the freebsdmall should be removed? The service it’s active.

Thanks for the update :)

In D33750#763305, @debdrup wrote:

Maybe it's worth mentioning that (R) gets rendered by AsciiDoctor as ® as is both outlined here and can be spotted on the rendered output of the existing page.