Page MenuHomeFreeBSD

Website: Fix heading order in the footer
ClosedPublic

Authored by vladlen on Sat, Sep 19, 3:29 PM.
Tags
Referenced Files
F173713645: D59843.id187236.diff
Sun, Sep 27, 9:49 PM
Unknown Object (File)
Sun, Sep 27, 1:12 AM
Unknown Object (File)
Sat, Sep 26, 9:20 PM
Unknown Object (File)
Sat, Sep 26, 3:31 PM
Unknown Object (File)
Sat, Sep 26, 5:25 AM
Unknown Object (File)
Fri, Sep 25, 11:08 AM
Unknown Object (File)
Fri, Sep 25, 8:27 AM
Unknown Object (File)
Fri, Sep 25, 6:58 AM
Subscribers
None

Details

Summary

The HTML validator reports the "h3 follows h1" error on nearly
every page because of the footer. This noise makes it harder to
spot real and potentially dangerous issues in the output, so it
is worth fixing at the source.

I propose to replace h3 with p in footer.html. Column titles in
the footer are not part of the document outline, so h3 was
semantically wrong there anyway. Styles were adjusted so
the footer looks the same as before, and aria-labelledby on
each section keeps the column names announced by screen
readers.

Details:

  • footer.html: h3 -> p for the column titles; add aria-labelledby on each <section> pointing to its title.
  • main.css: move the styles that h3 previously inherited from the browser defaults (font-weight, line-height, padding) onto .column-title so the rendering is unchanged.

PR:297509

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vladlen created this revision.
This revision is now accepted and ready to land.Sat, Sep 19, 3:30 PM
This revision was automatically updated to reflect the committed changes.