LGTM

In D38811#883669, @bapt wrote:

In D38811#883667, @tijl wrote:

In D38811#883565, @tcberner wrote:

I would simply fix the creator to remove the hyphens before writing them to the machine-id file. Then we'll still have UUID v4.
The point of the whole thing is to have the compliant interface that modern software expects.

Systemd only generates v4 as a last resort, so software cannot assume it is v4. It can't even assume it follows RFC 4122 because dbus-uuidgen and old versions of systemd just produce a random number.

I think one UUID per machine is easier to manage and generating /etc/machine-id from rc.d/hostid_save removes some redundancy. If v4 is preferred then rc.d/hostid can be patched to run "uuidgen -r" or "uuidgen ${uuidgen_flags}" with uuidgen_flags set to -r by default. I could include that in this patch but I think it is a separate issue.

This is not a last resort, this is the default if no previous machine-id do exist. some program may expect RFC 4122 at some point (some already talk about it iirc) that is why we directly went to it for new. imho this ship has sailed.

In D38811#883565, @tcberner wrote:

I would simply fix the creator to remove the hyphens before writing them to the machine-id file. Then we'll still have UUID v4.
The point of the whole thing is to have the compliant interface that modern software expects.

In D38811#883365, @bapt wrote:

no hostid is not generating the same uuid, machine-id is based on uuidgen -r which generate version 4 UUID (RFC422), but you are right, about the hyphen.

Is this port really necessary? The dbus port already generates a machine-id and glib already uses it.

LGTM.

Maybe create a MANPAGES option and put %%MANPAGES%% in front of all the man pages in pkg-plist.*.