Page MenuHomeFreeBSD

Mk/Uses: autoreconf.mk: Add AUTORECONF_ARGS
ClosedPublic

Authored by otis on Feb 10 2023, 9:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 9, 11:07 PM
Unknown Object (File)
Feb 16 2024, 4:52 AM
Unknown Object (File)
Feb 10 2024, 6:18 PM
Unknown Object (File)
Jan 31 2024, 5:10 AM
Unknown Object (File)
Jan 18 2024, 1:45 PM
Unknown Object (File)
Dec 24 2023, 8:28 PM
Unknown Object (File)
Nov 18 2023, 2:11 PM
Unknown Object (File)
Nov 18 2023, 11:53 AM

Details

Summary

Add AUTORECONF_ARGS variable for situations where the default of -f -i is not sufficient.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

otis requested review of this revision.Feb 10 2023, 9:19 PM
Mk/Uses/autoreconf.mk
81

Why not AUTORECONF_FLAGS+= -f -i

We keep forcing -f -i because we always want that, but we allow the user to define its own flags before inclusion of the USES
at worst we will end up with duplicating -f and -i which I think is fine.

Mk/Uses/autoreconf.mk
130

I would name the variable AUTORECONF_ARGS and put it after the -f -i here. Then document it above as "Extra arguments to autoreconf. Default: none". Then port maintainers can still pass --no-force or --no-install if needed and pass arguments other than flags such as a list of directories.

otis marked 2 inline comments as done.Sep 13 2023, 8:49 AM
otis retitled this revision from Mk/Uses: autoreconf.mk: Add AUTORECONF_FLAGS to Mk/Uses: autoreconf.mk: Add AUTORECONF_ARGS.Sep 13 2023, 8:52 AM
otis edited the summary of this revision. (Show Details)
otis edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 14 2023, 11:49 AM
This revision was automatically updated to reflect the committed changes.