♟ rakuco

Hi, is there anything still blocking this review?

Fix gexiv dependencies in the port.

Remove yet another unneeded patch.

Remove another unnecessary patch.

Remove unnecessary patch.

Use lcms2 from ports rather than Chromium's bundled copy.

Remove unused "enable_hidpi" GN argument.

Backport a few changes to enable exceptions in all files that use libexiv.

Make sure the port links against libthr.so

In D18757#422029, @kai wrote:

File a bug for tracking the KDE-inotify bug.

If I'm not mistaken the Chromium Bug-Tracker is the right platform for that bug?

Thank you very much for this patch. I think we're good to go, and the KDE inotify thing can be tracked separately. I haven't test-built the latest version of this patch in older releases like 11.2 though, it'd be good to do the following:

Damn, I forgot to mention this review in the commit message :( Landed in rP496820.

Simplify pthread + libtool workaround.

Thanks a lot for working on this. I've left some inline comments in some of the patches, but there isn't a lot that I think needs changing \o/

In D18757#420567, @kai wrote:

Add missing debug files in pkg-plist.

print/lyx: Fix a bad MFH done in r496238.

Reland r496041 and r496054.

kde.mk, qt.mk: Prefix component variables to avoid clashes.

Depend on qt5-linguisttools at runtime too.

In D19629#420289, @tcberner wrote:

We should look into only build depending on ecm now for the desktop ports.

Uses/qt.mk: Remove _USE_QT4_ONLY and the components it defines.

Uses/qt.mk: Drop comment QT4_OPTIONS description.

Uses/qt.mk: Clean-up checks for Qt4

Remove comment that is no longer relevant after KDE4's removal.

Add a TEST option and set TEST_TARGET.

In D19575#419906, @rakuco wrote:

In D19575#419887, @fluffy wrote:

Please add pkgconfig to dependencies for gnomekeyring

I'll do that separately since it's also a build-time dependency.

Add USES=pkgconfig when GNOMEKEYRING is on.

Add USES=gnome when GNOMEKEYRING is on.

Point to Qt's current website in WWW.

Bump PORTREVISION in other ports that depend optionally on x11/kf5-kwayland.

Revert r496041 and r496054.

Remove linguist_build from USE_QT.

In D19575#419887, @fluffy wrote:

In D19575#419878, @rakuco wrote:

Do not bump PORTREVISION

Please add pkgconfig to dependencies for gnomekeyring

Drop conditional assignment now that this is a simple port after r495956.

Do not bump PORTREVISION

Remove patch that was only supposed to fix the build on FreeBSD <= 10.3.

Backport patch to fix creation of .tar archives when ZTD support is enabled.

Add USES=shared-mime-info

Replace OpenSSL 1.1.0 with upstream ones

Quick update on LibreSSL: apparently it's already broken

Update my email address in the first patch.

Thanks, I think I've addressed both of your points in this update.

Include bsd.port.options.mk, simplify plist substitutions

Bump my key's expiration date.

Add USES=compiler:c++11-lang for GCC builds to work

Fix plist after r483271 (most likely culprit).

Looks fine to me; I haven't tested it myself but I trust the work being done here.

Copy devel/cmake patch from r473149.

Add a patch to unbreak `make configure' with libuv 1.21.0.

Yeah. It's something good to have, but I don't have time to pursue this one.

Looks OK to me. It'd be good to clean this up and submit the patch upstream later.

Fix plist after r471139

Update the Qt5 ports to 5.10.1.

Add a patch to fix the build on FreeBSD 10.4.

Import yet another patch from upstream to fix the build with Qt 5.10.

Update Krusader to 2.7.0.

Simplify CONFLICTS_INSTALL.

Add CONFLICTS_INSTALL.

Replace bogus plist substitutions.

rakuco (Raphael Kubo da Costa)User

Projects

User Details

Recent ActivityView All

Jul 7 2019

Jun 2 2019

Apr 14 2019

Apr 1 2019

Mar 31 2019

Mar 30 2019

Mar 29 2019

Mar 27 2019

Mar 25 2019

Mar 24 2019

Mar 21 2019

Mar 19 2019

Mar 18 2019

Mar 17 2019

Mar 16 2019

Mar 13 2019

Mar 10 2019

Mar 9 2019

Mar 2 2019

Feb 28 2019

Feb 27 2019

Feb 25 2019

Feb 20 2019

Feb 16 2019

Feb 11 2019

Jan 4 2019

Dec 24 2018

Dec 7 2018

Dec 3 2018

Nov 21 2018

Nov 5 2018

Jul 31 2018

Jul 15 2018

Jul 14 2018

Jun 24 2018

Jun 23 2018

Jun 17 2018

Jun 14 2018

Jun 11 2018

Jun 7 2018

May 31 2018

May 18 2018

May 16 2018

rakuco (Raphael Kubo da Costa)
User

Recent Activity
View All