Page MenuHomeFreeBSD

devel/qjson: Improve clang 16 workaround for usage of the 'register' keyword
ClosedPublic

Authored by rakuco on Jul 8 2023, 9:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 12:04 AM
Unknown Object (File)
Wed, Oct 8, 5:36 PM
Unknown Object (File)
Fri, Oct 3, 9:26 AM
Unknown Object (File)
Fri, Oct 3, 3:26 AM
Unknown Object (File)
Wed, Oct 1, 3:28 PM
Unknown Object (File)
Tue, Sep 30, 6:52 AM
Unknown Object (File)
Tue, Sep 23, 8:33 AM
Unknown Object (File)
Tue, Sep 16, 11:16 PM
Subscribers

Details

Summary

Commit 3237ce1557467a3f89a3d1fa7a9308161665bf0c fixed the build on CURRENT with a heavy hammer that made register a macro. This change passes -Wno-register to the compiler instead, which is cleaner.

For the record: the current change restricts the change to __FreeBSD_version while this one checks for a compiler version instead -- the former could work if one's building the ports tree with GCC even though the FreeBSD release matters less than the GCC version.

Test Plan

The port built fine on amd64-CURRENT.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rakuco requested review of this revision.Jul 8 2023, 9:16 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 8 2023, 9:51 AM
This revision was automatically updated to reflect the committed changes.