Instead of forcing the port to build with -std=c++11 in all FreeBSD versions, just pass -Wno-register when the port is being built with a Clang release that defaults to C++17 mode (which does not have the register keyword by default).
Details
Details
The port built fine on amd64-CURRENT.
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| net-p2p/amule/Makefile | ||
|---|---|---|
| 17 | With this fix, can compiler:c++11-lang be removed from USES? | |
| net-p2p/amule/Makefile | ||
|---|---|---|
| 17 | Good question. For tier 1 architectures this USES entry does not do anything, and it was added years ago for powerpc support with GCC based on the commits. I'm not sure what the guidance is about these USES=compiler entries, but you can double check with @pkubaj if GCC is still needed and whether this can be removed. | |
| net-p2p/amule/Makefile | ||
|---|---|---|
| 17 | For 13 and 14, it doesn't matter whether it's tier 1 or tier 2. All the architectures use LLVM. What matters is just the FreeBSD 12.4-RELEASE, where powerpc and powerpc64 use GCC 4.2 and it certainly supports neither C++11 nor C++17 so if the port requires C++11 or C++17, this entry is certainly necessary to build on 12.4. | |
| net-p2p/amule/Makefile | ||
|---|---|---|
| 17 | Got it, thanks Piotr! Glad to know that we'll be able to remove a bunch of those USES=compiler entries next year. | |
| net-p2p/amule/Makefile | ||
|---|---|---|
| 17 | Yep, it will be nice! I love removals and cleanups :) | |