Page MenuHomeFreeBSD

graphics/zathura: Update to 0.4.9
ClosedPublic

Authored by kfv_kfv.io on Apr 8 2022, 9:12 PM.

Details

Summary
graphics/zathura: Update to 0.4.9

 - Add SYNCTEX port option.
 - Enable meson build option for SyncTeX support (fixes
   non-working feature configuration).
 - Improve clarity and remove ambiguity from pkg-descr and pkg-message.
 - Removed PATCHFILES: no longer required.

Reviewd_by: koobs (port), Quentin Stiévenart <quentin.stievenart AT gmail DOT com> (maintainer)
Differential_Revision: D34851
MFH: 2022Q2 (broken use of a library dependency)

This patch was previously reviewed and accepted by the
maintainer in D32266 for 0.4.8 and was requested by koobs@
to improve.

Since we had a minor change in the port and I
wanted to update it to 0.4.9, I abandoned the older request
to continue with this one.

Test Plan
  • portlint: passed
  • testport: passed
  • runtime: Using it on my daily driver running 13.0-RELEASE

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

graphics/zathura/Makefile
24–25

@koobs: I renamed the option TEX to SYNCTEX (from the previous differential) as I think this is more descriptive and avoids ambiguity.

graphics/zathura/Makefile
9

No longer required and applicable to the source.

kfv_kfv.io edited the summary of this revision. (Show Details)
jlduran_gmail.com added inline comments.
graphics/zathura/Makefile
31

SYNCTEX_BUILD_DEPENDS?

kfv_kfv.io edited the summary of this revision. (Show Details)
graphics/zathura/Makefile
9

You describe the removal reason in the diff, but not the commit log message, add it there.

24

Add Add SYNTEX option for foobar support in commit log message

kfv_kfv.io edited the summary of this revision. (Show Details)
graphics/zathura/Makefile
29

'with SyncTeX' is slightly redundant, since the string matches the OPTION name.

`Direct and reverse synchronization support' is enough

graphics/zathura/Makefile
31

It checks for the availability of the dependency at compile-time, but yeah, it's only required at run-time.

kfv_kfv.io edited the summary of this revision. (Show Details)
kfv_kfv.io edited the summary of this revision. (Show Details)
kfv_kfv.io edited the summary of this revision. (Show Details)
kfv_kfv.io edited the summary of this revision. (Show Details)
graphics/zathura/Makefile
31

I meant shouldn't it be:

SYNCTEX_RUN_DEPENDS=	${SYNCTEX_BUILD_DEPENDS}

instead?

graphics/zathura/Makefile
31

LIB_DEPENDS is a build and run time dependency type.

If this requires the library at run time, use LIB_DEPENDS, not BUILD and/or RUN separately.

koobs requested changes to this revision.Apr 9 2022, 12:17 AM

After *_DEPENDS change, re-QA via poudriere to confirm dependency availability at build and run time.

This revision now requires changes to proceed.Apr 9 2022, 12:17 AM
graphics/zathura/Makefile
31

Whoops! Yes, you're right. I'll update. Thank you so much ;-D

graphics/zathura/Makefile
31

Perfect, I didn't know, thank you. All right, I'll update and will request for review again after testport.

  • graphics/zathura: Fix typo in SYNCTEX_RUN_DEPENDS

@koobs: I tried it with LIB_DEPENDS, and it passed the tests. So yes, it works fine that way, but it wasn't impossible to specify the version. Therefore I just fixed the typo in SYNCTEX_RUN_DEPENDS.

koobs edited the summary of this revision. (Show Details)

LGTM

This revision is now accepted and ready to land.Apr 9 2022, 11:23 PM
This revision was automatically updated to reflect the committed changes.