graphics/zathura: Update to 0.4.9

[kfv]

Summary

graphics/zathura: Update to 0.4.9

 - Add SYNCTEX port option.
 - Enable meson build option for SyncTeX support (fixes
   non-working feature configuration).
 - Improve clarity and remove ambiguity from pkg-descr and pkg-message.
 - Removed PATCHFILES: no longer required.

Reviewd_by: koobs (port), Quentin Stiévenart <quentin.stievenart AT gmail DOT com> (maintainer)
Differential_Revision: D34851
MFH: 2022Q2 (broken use of a library dependency)

This patch was previously reviewed and accepted by the
maintainer in D32266 for 0.4.8 and was requested by koobs@
to improve.

Since we had a minor change in the port and I
wanted to update it to 0.4.9, I abandoned the older request
to continue with this one.

Test Plan

• portlint: passed
• testport: passed
• runtime: Using it on my daily driver running 13.0-RELEASE

[kfv]

graphics/zathura/Makefile

24–25

@koobs: I renamed the option TEX to SYNCTEX (from the previous differential) as I think this is more descriptive and avoids ambiguity.

[kfv]

graphics/zathura/Makefile

9

No longer required and applicable to the source.

[jlduran]

graphics/zathura/Makefile

32

SYNCTEX_BUILD_DEPENDS?

[koobs]

graphics/zathura/Makefile

9

You describe the removal reason in the diff, but not the commit log message, add it there.

25

Add Add SYNTEX option for foobar support in commit log message

[koobs]

graphics/zathura/Makefile

30

'with SyncTeX' is slightly redundant, since the string matches the OPTION name.

`Direct and reverse synchronization support' is enough

[kfv]

graphics/zathura/Makefile

32

It checks for the availability of the dependency at compile-time, but yeah, it's only required at run-time.

[jlduran]

graphics/zathura/Makefile

32

I meant shouldn't it be:

SYNCTEX_RUN_DEPENDS=	${SYNCTEX_BUILD_DEPENDS}

instead?

[koobs]

graphics/zathura/Makefile

32

LIB_DEPENDS is a build and run time dependency type.

If this requires the library at run time, use LIB_DEPENDS, not BUILD and/or RUN separately.

[koobs]

After *_DEPENDS change, re-QA via poudriere to confirm dependency availability at build and run time.

[kfv]

graphics/zathura/Makefile

32

Whoops! Yes, you're right. I'll update. Thank you so much ;-D

[kfv]

graphics/zathura/Makefile

32

Perfect, I didn't know, thank you. All right, I'll update and will request for review again after testport.

[kfv]

• graphics/zathura: Fix typo in SYNCTEX_RUN_DEPENDS

[kfv]

@koobs: I tried it with LIB_DEPENDS, and it passed the tests. So yes, it works fine that way, but it wasn't impossible to specify the version. Therefore I just fixed the typo in SYNCTEX_RUN_DEPENDS.

[koobs]

LGTM

[fernape]

Committed,

Thanks!