Paths

Table of Contentst

graphics/zathura: Update to 0.4.9
ClosedPublic
Actions

Authored by kfv_kfv.io on Apr 8 2022, 9:12 PM.

Details

Reviewers

koobs
quentin.stievenart_gmail.com

Commits

R11:9abc70478bd9: graphics/zathura: Update to 0.4.9
R11:58f14041a79e: graphics/zathura: Update to 0.4.9

Summary

graphics/zathura: Update to 0.4.9

 - Add SYNCTEX port option.
 - Enable meson build option for SyncTeX support (fixes
   non-working feature configuration).
 - Improve clarity and remove ambiguity from pkg-descr and pkg-message.
 - Removed PATCHFILES: no longer required.

Reviewd_by: koobs (port), Quentin Stiévenart <quentin.stievenart AT gmail DOT com> (maintainer)
Differential_Revision: D34851
MFH: 2022Q2 (broken use of a library dependency)

This patch was previously reviewed and accepted by the
maintainer in D32266 for 0.4.8 and was requested by koobs@
to improve.

Since we had a minor change in the port and I
wanted to update it to 0.4.9, I abandoned the older request
to continue with this one.

Test Plan

portlint: passed
testport: passed
runtime: Using it on my daily driver running 13.0-RELEASE

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 45095
Build 41983: arc lint + arc unit

Event Timeline

kfv_kfv.io created this revision.Apr 8 2022, 9:12 PM

Herald added a subscriber: mat. · View Herald TranscriptApr 8 2022, 9:12 PM

kfv_kfv.io requested review of this revision.Apr 8 2022, 9:12 PM

Harbormaster completed remote builds in B45085: Diff 104788.Apr 8 2022, 9:12 PM

kfv_kfv.io mentioned this in D32266: graphics/zathura: Update to 0.4.8, Add SyncTeX support.Apr 8 2022, 9:13 PM

kfv_kfv.io added inline comments.Apr 8 2022, 9:20 PM

graphics/zathura/Makefile
24–25	@koobs: I renamed the option TEX to SYNCTEX (from the previous differential) as I think this is more descriptive and avoids ambiguity.

kfv_kfv.io added inline comments.Apr 8 2022, 9:22 PM

graphics/zathura/Makefile
9	No longer required and applicable to the source.

kfv_kfv.io edited the summary of this revision. (Show Details)Apr 8 2022, 9:23 PM

kfv_kfv.io edited the summary of this revision. (Show Details)

jlduran_gmail.com added a subscriber: jlduran_gmail.com.Apr 8 2022, 10:39 PM

jlduran_gmail.com added inline comments.

graphics/zathura/Makefile
32	`SYNCTEX_BUILD_DEPENDS`?

kfv_kfv.io edited the summary of this revision. (Show Details)Apr 8 2022, 11:57 PM

koobs edited the test plan for this revision. (Show Details)Apr 8 2022, 11:58 PM

kfv_kfv.io edited the summary of this revision. (Show Details)Apr 8 2022, 11:58 PM

kfv_kfv.io edited the summary of this revision. (Show Details)

koobs added inline comments.Apr 9 2022, 12:00 AM

graphics/zathura/Makefile
9	You describe the removal reason in the diff, but not the commit log message, add it there.
25	Add `Add SYNTEX option for foobar support` in commit log message

kfv_kfv.io edited the summary of this revision. (Show Details)Apr 9 2022, 12:01 AM

kfv_kfv.io edited the summary of this revision. (Show Details)

koobs added inline comments.Apr 9 2022, 12:02 AM

graphics/zathura/Makefile
30	'with SyncTeX' is slightly redundant, since the string matches the OPTION name. `Direct and reverse synchronization support' is enough

kfv_kfv.io added inline comments.Apr 9 2022, 12:04 AM

graphics/zathura/Makefile
32	It checks for the availability of the dependency at compile-time, but yeah, it's only required at run-time.

kfv_kfv.io edited the summary of this revision. (Show Details)Apr 9 2022, 12:05 AM

kfv_kfv.io edited the summary of this revision. (Show Details)

kfv_kfv.io edited the summary of this revision. (Show Details)Apr 9 2022, 12:09 AM

kfv_kfv.io edited the summary of this revision. (Show Details)

kfv_kfv.io edited the summary of this revision. (Show Details)Apr 9 2022, 12:13 AM

kfv_kfv.io edited the summary of this revision. (Show Details)

jlduran_gmail.com added inline comments.Apr 9 2022, 12:14 AM

graphics/zathura/Makefile
32	I meant shouldn't it be: SYNCTEX_RUN_DEPENDS= ${SYNCTEX_BUILD_DEPENDS} instead?

kfv_kfv.io edited the summary of this revision. (Show Details)Apr 9 2022, 12:14 AM

koobs added inline comments.Apr 9 2022, 12:16 AM

graphics/zathura/Makefile
32	LIB_DEPENDS is a build and run time dependency type. If this requires the library at run time, use LIB_DEPENDS, not BUILD and/or RUN separately.

After *_DEPENDS change, re-QA via poudriere to confirm dependency availability at build and run time.

This revision now requires changes to proceed.Apr 9 2022, 12:17 AM

kfv_kfv.io added inline comments.Apr 9 2022, 12:17 AM

graphics/zathura/Makefile
32	Whoops! Yes, you're right. I'll update. Thank you so much ;-D

kfv_kfv.io added inline comments.Apr 9 2022, 12:23 AM

graphics/zathura/Makefile
32	Perfect, I didn't know, thank you. All right, I'll update and will request for review again after `testport`.

graphics/zathura: Fix typo in SYNCTEX_RUN_DEPENDS

Harbormaster completed remote builds in B45095: Diff 104809.Apr 9 2022, 4:20 PM

@koobs: I tried it with LIB_DEPENDS, and it passed the tests. So yes, it works fine that way, but it wasn't impossible to specify the version. Therefore I just fixed the typo in SYNCTEX_RUN_DEPENDS.

kfv_kfv.io marked 5 inline comments as done.Apr 9 2022, 4:26 PM