Page MenuHomeFreeBSD

Switch from FD_SETSIZE to getdtablesize().
ClosedPublic

Authored by araujo on Jan 18 2016, 2:20 AM.

Details

Summary

@rodrigc requested to switch to getdtablesize() as it will be more close with
what was implemented on OpenBSD. I have no objection with it as it has a good
side and the FD can be tunable.

However, it will be slower than FD_SETSIZE as it needs to calloc more than 1024.
Not a big deal to be honest.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

araujo retitled this revision from to Switch from FD_SETSIZE to getdtablesize()..Jan 18 2016, 2:20 AM
araujo updated this object.
araujo edited the test plan for this revision. (Show Details)
araujo added reviewers: rodrigc, bapt.
araujo added a subscriber: rodrigc.
araujo updated this revision to Diff 12396.
rodrigc edited edge metadata.Jan 22 2016, 2:33 AM
rodrigc accepted this revision.
This revision is now accepted and ready to land.Jan 22 2016, 2:33 AM
This revision was automatically updated to reflect the committed changes.