Page MenuHomeFreeBSD

me_cameronkatri.com (Cameron Katri)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 20 2021, 7:39 PM (85 w, 3 d)

Recent Activity

Aug 28 2022

me_cameronkatri.com added inline comments to D31119: games/lwjgl3: Lightweight Java Game Library 3.
Aug 28 2022, 2:08 AM

Feb 26 2022

me_cameronkatri.com added a comment to D30350: acpiconf(8): Add libxo(3) support.

Sorry to bother, but was just wondering if someone could review this as it's been stale for a while.

Feb 26 2022, 11:23 PM
me_cameronkatri.com added a comment to D32297: mandoc: Don't brand Volume titles.

Rationale: https://marc.info/?l=mandoc-discuss&m=163333478800796

Feb 26 2022, 11:21 PM

Feb 23 2022

me_cameronkatri.com added a comment to D30012: cp(1): Make -P work without -R as per POSIX.

I will commit this tomorrow afternoon-ish. Thanks!

Thank you.

Can you confirm that this is your preferred name + email, please? --author="Cameron Katri <me@cameronkatri.com>"

Yes, that's correct.

Feb 23 2022, 4:26 AM
me_cameronkatri.com updated the diff for D30012: cp(1): Make -P work without -R as per POSIX.

Update manpage date

Feb 23 2022, 3:30 AM
me_cameronkatri.com updated the diff for D30012: cp(1): Make -P work without -R as per POSIX.

Rebase after 33ad990

Feb 23 2022, 3:27 AM

Jan 28 2022

me_cameronkatri.com updated the diff for D30012: cp(1): Make -P work without -R as per POSIX.

Update manpage date.

Jan 28 2022, 4:15 AM
me_cameronkatri.com updated the diff for D30012: cp(1): Make -P work without -R as per POSIX.

Rebase after 848263aad129c8f9de75b58a5ab9a010611b75ac
Make SYNOPSIS more clear

Jan 28 2022, 4:14 AM

Jan 27 2022

me_cameronkatri.com added a comment to D30012: cp(1): Make -P work without -R as per POSIX.
In D30012#761215, @pauamma_gundo.com wrote:
In D30012#760630, @pauamma_gundo.com wrote:

cp [-R [-H | -L | -P]] in the synopsis needs to be changed if -P can be used without -R.

How is that supposed to look? Just move the -P out of the []? But -P still can't be used with -H or -L.

Can -H or -L also be used without -P, or do they require it? What happens it you use 2 (or all 3) of -H, -L, and -P? Latest wins silently? Error? Something else?

Jan 27 2022, 12:37 AM

Dec 27 2021

me_cameronkatri.com added a comment to D30012: cp(1): Make -P work without -R as per POSIX.
In D30012#760630, @pauamma_gundo.com wrote:

cp [-R [-H | -L | -P]] in the synopsis needs to be changed if -P can be used without -R.

How is that supposed to look? Just move the -P out of the []? But -P still can't be used with -H or -L.

Dec 27 2021, 1:56 AM
me_cameronkatri.com added a comment to D33620: Regenerate ReStructuredText based manpages for llvm-project tools:.

This diff was a mistake because I misread the git log.

Dec 27 2021, 1:54 AM

Dec 23 2021

me_cameronkatri.com updated the diff for D32061: llvm-strip: Add manpage.

Fix MLINKS

Dec 23 2021, 12:49 AM
me_cameronkatri.com changed the repository for D32061: llvm-strip: Add manpage from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
Dec 23 2021, 12:05 AM
me_cameronkatri.com updated the diff for D32061: llvm-strip: Add manpage.

Regenerate manpage from llvm 13

Dec 23 2021, 12:04 AM

Dec 22 2021

me_cameronkatri.com abandoned D33620: Regenerate ReStructuredText based manpages for llvm-project tools:.
Dec 22 2021, 11:56 PM
me_cameronkatri.com requested review of D33620: Regenerate ReStructuredText based manpages for llvm-project tools:.
Dec 22 2021, 11:32 PM
me_cameronkatri.com updated the diff for D30012: cp(1): Make -P work without -R as per POSIX.

Update manpage date.

Dec 22 2021, 10:59 PM
me_cameronkatri.com updated the diff for D30350: acpiconf(8): Add libxo(3) support.

Update manpage date.

Dec 22 2021, 10:57 PM
me_cameronkatri.com retitled D30350: acpiconf(8): Add libxo(3) support from Add libxo(3) support to acpiconf(8) to acpiconf(8): Add libxo(3) support.
Dec 22 2021, 10:56 PM

Nov 15 2021

me_cameronkatri.com added a reviewer for D32297: mandoc: Don't brand Volume titles: bapt.
Nov 15 2021, 4:28 PM

Nov 13 2021

me_cameronkatri.com updated the diff for D32065: llvm-strings(1): Install as strings when WITH_LLVM_BINUTILS=YES.

Rebase

Nov 13 2021, 9:02 PM

Nov 10 2021

me_cameronkatri.com updated the diff for D30012: cp(1): Make -P work without -R as per POSIX.

Update .Dd

Nov 10 2021, 11:48 PM
me_cameronkatri.com updated the diff for D30012: cp(1): Make -P work without -R as per POSIX.

Add a test case.

Nov 10 2021, 10:40 PM

Oct 18 2021

me_cameronkatri.com added a comment to D32065: llvm-strings(1): Install as strings when WITH_LLVM_BINUTILS=YES.

I updated this so it will install ELF Tool Chain strings, unless WITH_LLVM_BINUTILS is set, in which case llvm-strings will be installed as strings. It shouldn't change the current behavior of installing strings regardless of whether the toolchain was built (which I completely understand).

Oct 18 2021, 9:09 PM
me_cameronkatri.com updated the diff for D32065: llvm-strings(1): Install as strings when WITH_LLVM_BINUTILS=YES.

Install strings if despite WITHOUT_TOOLCHAIN

Oct 18 2021, 8:34 PM

Oct 14 2021

me_cameronkatri.com added a comment to D32058: llvm-readobj: Attach to buildsystem.

Thank you!

Oct 14 2021, 4:30 PM

Oct 11 2021

me_cameronkatri.com updated the diff for D32058: llvm-readobj: Attach to buildsystem.

Rebase after 88c027338f18

Oct 11 2021, 11:30 PM
me_cameronkatri.com updated the diff for D32058: llvm-readobj: Attach to buildsystem.

Rebase after 88c027338f18

Oct 11 2021, 11:29 PM

Oct 4 2021

me_cameronkatri.com added a comment to D32297: mandoc: Don't brand Volume titles.

mandoc 1.14.6 was just released on September 23 (https://mandoc.bsd.lv/NEWS), but Phabricator isn't really suited to submit patches for vendor updates, so a committer will have to do that.

Oct 4 2021, 6:56 PM
me_cameronkatri.com changed the repository for D32297: mandoc: Don't brand Volume titles from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
Oct 4 2021, 6:54 PM
me_cameronkatri.com requested review of D32297: mandoc: Don't brand Volume titles.
Oct 4 2021, 6:53 PM
me_cameronkatri.com updated the diff for D32296: man(1): Support zstd compressed manpages using zstdcat.

Add context.

Oct 4 2021, 6:02 PM
me_cameronkatri.com added a reviewer for D32296: man(1): Support zstd compressed manpages using zstdcat: Contributor Reviews (base).
Oct 4 2021, 6:01 PM
me_cameronkatri.com requested review of D32296: man(1): Support zstd compressed manpages using zstdcat.
Oct 4 2021, 6:01 PM

Sep 29 2021

me_cameronkatri.com added a comment to D30341: mount(8): Add libxo(3) support.
In D30341#727179, @phil wrote:

Also looks like you've lost the space in "write: sync". Use "{Lwc:writes}{P: }{Lw:sync}".

Sep 29 2021, 7:44 PM

Sep 25 2021

me_cameronkatri.com edited reviewers for D32061: llvm-strip: Add manpage, added: dim; removed: manpages.
Sep 25 2021, 3:10 PM

Sep 24 2021

me_cameronkatri.com updated the diff for D30341: mount(8): Add libxo(3) support.

Change fsid allocation. Thanks pstef.

Sep 24 2021, 7:59 PM
me_cameronkatri.com retitled D30341: mount(8): Add libxo(3) support from Add libxo(3) support to mount(8) to mount(8): Add libxo(3) support.
Sep 24 2021, 7:59 PM

Sep 23 2021

me_cameronkatri.com added inline comments to D30341: mount(8): Add libxo(3) support.
Sep 23 2021, 10:49 PM
me_cameronkatri.com updated the diff for D30341: mount(8): Add libxo(3) support.

Check the return value of asprintf.

Sep 23 2021, 10:47 PM
me_cameronkatri.com added a reviewer for D32065: llvm-strings(1): Install as strings when WITH_LLVM_BINUTILS=YES: arichardson.
Sep 23 2021, 12:26 AM
me_cameronkatri.com added a reviewer for D32065: llvm-strings(1): Install as strings when WITH_LLVM_BINUTILS=YES: emaste.
Sep 23 2021, 12:26 AM
me_cameronkatri.com requested review of D32065: llvm-strings(1): Install as strings when WITH_LLVM_BINUTILS=YES.
Sep 23 2021, 12:25 AM

Sep 22 2021

me_cameronkatri.com added a comment to D32058: llvm-readobj: Attach to buildsystem.
In D32058#723551, @dim wrote:

readelf is just a symlink to readobj, so in order to have a full llvm binutils instead of elftoolchain with WITH_LLVM_BINUTILS we need llvm-readelf.

Ah, I wasn't aware that we were replacing elftoolchain's readelf here. But in that case, it should be OK, I guess. For now, WITH_LLVM_BINUTILS isn't defaulted on, right?

Sep 22 2021, 7:31 PM
me_cameronkatri.com added a comment to D32058: llvm-readobj: Attach to buildsystem.
In D32058#723538, @dim wrote:

Hm, one thing is missing: why do we need this tool? :) Last time I looked it was a tool specifically for llvm's regression tests. Do we really want to build this unconditionally?

Sep 22 2021, 7:14 PM
me_cameronkatri.com changed the repository for D32061: llvm-strip: Add manpage from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
Sep 22 2021, 7:07 PM
me_cameronkatri.com updated the summary of D32058: llvm-readobj: Attach to buildsystem.
Sep 22 2021, 7:06 PM
me_cameronkatri.com updated the diff for D32058: llvm-readobj: Attach to buildsystem.

Move llvm-strip manpage to D32061

Sep 22 2021, 7:04 PM
me_cameronkatri.com requested review of D32061: llvm-strip: Add manpage.
Sep 22 2021, 7:04 PM
me_cameronkatri.com removed a reviewer for D32058: llvm-readobj: Attach to buildsystem: manpages.
Sep 22 2021, 6:11 PM
me_cameronkatri.com requested review of D32058: llvm-readobj: Attach to buildsystem.
Sep 22 2021, 6:10 PM

Sep 20 2021

me_cameronkatri.com updated the summary of D30012: cp(1): Make -P work without -R as per POSIX.
Sep 20 2021, 12:13 AM

Sep 18 2021

me_cameronkatri.com changed the repository for D30547: ls(1): Allow LSCOLORS to specify an underline from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
Sep 18 2021, 12:28 PM
me_cameronkatri.com added a comment to D30547: ls(1): Allow LSCOLORS to specify an underline.

I just noticed that when I use git arc it changed the the repository to the subversion one instead of the git. I looks like the /usr/src/.arcconfig is still set to the subversion repo.

Sep 18 2021, 12:28 PM
me_cameronkatri.com updated the diff for D30547: ls(1): Allow LSCOLORS to specify an underline.

Use bool for underline and bold.

Sep 18 2021, 12:24 PM

Sep 17 2021

me_cameronkatri.com added inline comments to D30547: ls(1): Allow LSCOLORS to specify an underline.
Sep 17 2021, 7:25 PM

Sep 5 2021

me_cameronkatri.com added a comment to D30545: diff(1): Add --color support.

I made some stylistic changes and rebased this patch on top of it. I also modified it to clear color (especially background color) before newlines.
Are you OK with me committing your change like this?

Sep 5 2021, 11:16 AM

Sep 4 2021

me_cameronkatri.com updated the diff for D30545: diff(1): Add --color support.

Remove init_code()
Don't use ret variable.

Sep 4 2021, 8:09 PM

Sep 2 2021

me_cameronkatri.com added inline comments to D30545: diff(1): Add --color support.
Sep 2 2021, 7:09 PM
me_cameronkatri.com updated the diff for D30545: diff(1): Add --color support.

Fix return styling.
Default to never
auto only applies when COLORTERM or CLICOLOR is set (the same as ls(1)).

Sep 2 2021, 7:07 PM

Aug 25 2021

me_cameronkatri.com updated the diff for D30545: diff(1): Add --color support.

Describe DIFFCOLORS in the manpage.

Aug 25 2021, 5:39 PM

Aug 24 2021

me_cameronkatri.com added inline comments to D30545: diff(1): Add --color support.
Aug 24 2021, 8:28 PM
me_cameronkatri.com updated the diff for D30545: diff(1): Add --color support.

Fix COLORFLAG_* values.
Fix init_code() to return proper value.

Aug 24 2021, 8:28 PM
me_cameronkatri.com updated the diff for D30545: diff(1): Add --color support.
Aug 24 2021, 6:41 PM
me_cameronkatri.com added inline comments to D30545: diff(1): Add --color support.
Aug 24 2021, 6:41 PM
me_cameronkatri.com added a comment to D30350: acpiconf(8): Add libxo(3) support.
In D30350#714235, @phil wrote:

Cameron,

You said "it seems that most check"; did you find ones that didn't?

Thanks,
Phil

Aug 24 2021, 6:32 PM
me_cameronkatri.com updated the diff for D30547: ls(1): Allow LSCOLORS to specify an underline.
Aug 24 2021, 6:28 PM
me_cameronkatri.com added inline comments to D30012: cp(1): Make -P work without -R as per POSIX.
Aug 24 2021, 6:19 PM
me_cameronkatri.com updated the diff for D30012: cp(1): Make -P work without -R as per POSIX.

Make manpage be more clear.

Aug 24 2021, 6:19 PM
me_cameronkatri.com added inline comments to D30341: mount(8): Add libxo(3) support.
Aug 24 2021, 6:10 PM
me_cameronkatri.com updated the diff for D30341: mount(8): Add libxo(3) support.

Fix some styling.

Aug 24 2021, 6:09 PM

Aug 23 2021

me_cameronkatri.com added inline comments to D30350: acpiconf(8): Add libxo(3) support.
Aug 23 2021, 11:07 PM
me_cameronkatri.com updated the diff for D30350: acpiconf(8): Add libxo(3) support.

Check argc after xo_parse_args().

Aug 23 2021, 11:06 PM
me_cameronkatri.com updated the diff for D30341: mount(8): Add libxo(3) support.

Revert last diff (uploaded to wrong differential)

Aug 23 2021, 11:05 PM
me_cameronkatri.com updated the diff for D30341: mount(8): Add libxo(3) support.

Check argc after xo_parse_args().

Aug 23 2021, 11:03 PM
me_cameronkatri.com updated the diff for D30547: ls(1): Allow LSCOLORS to specify an underline.

Use operator in if statement.

Aug 23 2021, 10:49 PM
me_cameronkatri.com updated the diff for D30545: diff(1): Add --color support.

Add spaces around binary operators.
Test color using operator.

Aug 23 2021, 10:43 PM

Jul 28 2021

me_cameronkatri.com updated the diff for D30545: diff(1): Add --color support.

Remove leftover printf from testing.

Jul 28 2021, 5:54 PM
me_cameronkatri.com updated the diff for D30545: diff(1): Add --color support.

Respect CLICOLOR and COLORTERM variables.

Jul 28 2021, 5:50 PM

Jul 18 2021

me_cameronkatri.com updated the test plan for D31119: games/lwjgl3: Lightweight Java Game Library 3.
Jul 18 2021, 1:33 AM
me_cameronkatri.com added a comment to D31119: games/lwjgl3: Lightweight Java Game Library 3.

The build fails for me on 140-amd64 [1]

Jul 18 2021, 1:32 AM
me_cameronkatri.com updated the diff for D31119: games/lwjgl3: Lightweight Java Game Library 3.

Fix building in pourdriere on amd64, i386 fails to build.

Jul 18 2021, 1:31 AM

Jul 12 2021

me_cameronkatri.com updated the diff for D31119: games/lwjgl3: Lightweight Java Game Library 3.

USES=pkgconfig not pkgconf

Jul 12 2021, 5:34 PM
me_cameronkatri.com updated the diff for D31119: games/lwjgl3: Lightweight Java Game Library 3.

Fix devel/pkgconf dependency (USE=pkgconf)

Jul 12 2021, 2:18 PM

Jul 11 2021

me_cameronkatri.com updated the diff for D31119: games/lwjgl3: Lightweight Java Game Library 3.

Add devel/pkgconf dependency
Remove amd64 limit, although I couldn't get it to compile for i386 it may work for other archs.

Jul 11 2021, 10:10 PM
me_cameronkatri.com updated the diff for D31119: games/lwjgl3: Lightweight Java Game Library 3.

Regenerate patch with make makepatch
Don't unnecessarily define DISTNAME.

Jul 11 2021, 1:04 PM
me_cameronkatri.com updated the diff for D31119: games/lwjgl3: Lightweight Java Game Library 3.
Jul 11 2021, 12:44 PM
me_cameronkatri.com added a comment to D31119: games/lwjgl3: Lightweight Java Game Library 3.

@me_cameronkatri.com Could you provide this change (new port) as a diff against the existing games/lwjgl port and add a comment regarding patch-build.xml and why its necessary.

patch-build.xml stops the building of the *-sources.jar and *-javadoc.jar files that I was deleting before, because they don’t get installed, it very much improves the build time.

Also, while talking with someone on IRC about updating and level'ing up all our minecraft ports, I investigated MultiMC as the second consumer of lwgl and couldn't identify it as a dependency in their upstream build docs [1]

Well lwjgl isn’t a dep of multimc, but of Minecraft, on other platforms multiMC will download the lwjgl classes from minecraft.net, but lwjgl doesn’t work in the linuxulator, hence minecraft-client to replace the downloaded with the installed libs.

If lwgl isn't an actual dependency or MultiMC (our port version 0.6.11 is now .1 behind the latest release) can use lwgl3, then we should update the existing port.

Minecraft 1.12 and below use lwjgl but Minecraft 1.13 and up use lwjgl3, I know that I and many others still regularly play 1.12.2 and below because of the fact they are very popular with mod makers and modpack makers. So I want them to be separated so that I can install both.

See also the following bug https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255349 which provided LWGL3 as well

[1] https://github.com/MultiMC/MultiMC5/blob/develop/BUILD.md

Jul 11 2021, 11:48 AM

Jul 10 2021

me_cameronkatri.com updated the diff for D31119: games/lwjgl3: Lightweight Java Game Library 3.

Don't include bsd.port.pre.mk

Jul 10 2021, 1:11 PM
me_cameronkatri.com updated the diff for D31119: games/lwjgl3: Lightweight Java Game Library 3.

Add link to website in pkg-descr
Patch out javadoc and sources targets from build.xml
Run portclippy

Jul 10 2021, 1:10 PM

Jul 9 2021

me_cameronkatri.com added inline comments to D31119: games/lwjgl3: Lightweight Java Game Library 3.
Jul 9 2021, 10:17 PM
me_cameronkatri.com added a comment to D31119: games/lwjgl3: Lightweight Java Game Library 3.

I hope you are planing to get your fork merged upstream? :)

The lwjgl devs don’t want to support targets that they do not have CI for, although many people have offered CI runners for then running FreeBSD they still seem to have no interest.

Jul 9 2021, 10:14 PM
me_cameronkatri.com updated the diff for D31119: games/lwjgl3: Lightweight Java Game Library 3.

Add audio/opus, and devel/ocl-icd to LIB_DEPENDS which are all dlopen()d
Use USE_GNOME instead of LIB_DEPENDS
Add USE_XORG with x11, which is dlopen()d
Add egl and glesv2 to USE_GL which are also dlopen()d
Remove duplicate BUILD_DEPENDS on devel/dyncall

Jul 9 2021, 7:12 PM
me_cameronkatri.com added inline comments to D31119: games/lwjgl3: Lightweight Java Game Library 3.
Jul 9 2021, 6:58 PM
me_cameronkatri.com updated the summary of D31119: games/lwjgl3: Lightweight Java Game Library 3.
Jul 9 2021, 2:54 PM
me_cameronkatri.com requested review of D31119: games/lwjgl3: Lightweight Java Game Library 3.
Jul 9 2021, 2:53 PM

Jun 2 2021

me_cameronkatri.com added a reviewer for D30547: ls(1): Allow LSCOLORS to specify an underline: Contributor Reviews (base).
Jun 2 2021, 11:45 PM
me_cameronkatri.com edited reviewers for D30545: diff(1): Add --color support, added: Contributor Reviews (base); removed: manpages.
Jun 2 2021, 11:45 PM
me_cameronkatri.com added a comment to D30350: acpiconf(8): Add libxo(3) support.
In D30350#687753, @phil wrote:

I could swear I tried this, I’ll update the patch shortly.

Well, retest to ensure I'm not lying, but I just verified it as working in libxo/develop and even added an explicit test case for it, as well as docs.

Thanks,
Phil

Jun 2 2021, 8:40 PM
me_cameronkatri.com updated the diff for D30350: acpiconf(8): Add libxo(3) support.

Correct escaping of slashes

Jun 2 2021, 5:46 PM