• Check xo_parse_args(3) for error.
• Reference xo_options(7) in manpage.

Thank you!

Good morning, what's the status on getting this landed?

Good morning,
Whats the status on getting this committed?

Sorry to bother, but was just wondering if someone could review this as it's been stale for a while.

Rationale: https://marc.info/?l=mandoc-discuss&m=163333478800796

In D30012#777995, @kevans wrote:

I will commit this tomorrow afternoon-ish. Thanks!

Thank you.

Can you confirm that this is your preferred name + email, please? --author="Cameron Katri <me@cameronkatri.com>"

Yes, that's correct.

Update manpage date

Rebase after 33ad990

Update manpage date.

Rebase after 848263aad129c8f9de75b58a5ab9a010611b75ac
Make SYNOPSIS more clear

In D30012#761215, @pauamma_gundo.com wrote:

In D30012#760665, @me_cameronkatri.com wrote:

In D30012#760630, @pauamma_gundo.com wrote:

cp [-R [-H | -L | -P]] in the synopsis needs to be changed if -P can be used without -R.

How is that supposed to look? Just move the -P out of the []? But -P still can't be used with -H or -L.

Can -H or -L also be used without -P, or do they require it? What happens it you use 2 (or all 3) of -H, -L, and -P? Latest wins silently? Error? Something else?

In D30012#760630, @pauamma_gundo.com wrote:

cp [-R [-H | -L | -P]] in the synopsis needs to be changed if -P can be used without -R.

How is that supposed to look? Just move the -P out of the []? But -P still can't be used with -H or -L.

This diff was a mistake because I misread the git log.

Fix MLINKS

Regenerate manpage from llvm 13

Update manpage date.

Update manpage date.

Rebase

Update .Dd

Add a test case.

I updated this so it will install ELF Tool Chain strings, unless WITH_LLVM_BINUTILS is set, in which case llvm-strings will be installed as strings. It shouldn't change the current behavior of installing strings regardless of whether the toolchain was built (which I completely understand).

Install strings if despite WITHOUT_TOOLCHAIN

Thank you!

Rebase after 88c027338f18

Rebase after 88c027338f18

mandoc 1.14.6 was just released on September 23 (https://mandoc.bsd.lv/NEWS), but Phabricator isn't really suited to submit patches for vendor updates, so a committer will have to do that.

Add context.

In D30341#727179, @phil wrote:

Also looks like you've lost the space in "write: sync". Use "{Lwc:writes}{P: }{Lw:sync}".

Change fsid allocation. Thanks pstef.

Check the return value of asprintf.

In D32058#723551, @dim wrote:

In D32058#723540, @me_cameronkatri.com wrote:

readelf is just a symlink to readobj, so in order to have a full llvm binutils instead of elftoolchain with WITH_LLVM_BINUTILS we need llvm-readelf.

Ah, I wasn't aware that we were replacing elftoolchain's readelf here. But in that case, it should be OK, I guess. For now, WITH_LLVM_BINUTILS isn't defaulted on, right?

In D32058#723538, @dim wrote:

Hm, one thing is missing: why do we need this tool? :) Last time I looked it was a tool specifically for llvm's regression tests. Do we really want to build this unconditionally?

Move llvm-strip manpage to D32061

I just noticed that when I use git arc it changed the the repository to the subversion one instead of the git. I looks like the /usr/src/.arcconfig is still set to the subversion repo.

Use bool for underline and bold.

In D30545#718242, @pstef wrote:

I made some stylistic changes and rebased this patch on top of it. I also modified it to clear color (especially background color) before newlines.
Are you OK with me committing your change like this?

diff-color.patch8 KBDownload

Remove init_code()
Don't use ret variable.

Fix return styling.
Default to never
auto only applies when COLORTERM or CLICOLOR is set (the same as ls(1)).

Describe DIFFCOLORS in the manpage.

Fix COLORFLAG_* values.
Fix init_code() to return proper value.

In D30350#714235, @phil wrote:

Cameron,

You said "it seems that most check"; did you find ones that didn't?

Thanks,
Phil

Make manpage be more clear.

Fix some styling.

Check argc after xo_parse_args().

Revert last diff (uploaded to wrong differential)

Check argc after xo_parse_args().

Use operator in if statement.

Add spaces around binary operators.
Test color using operator.

Remove leftover printf from testing.

Respect CLICOLOR and COLORTERM variables.

In D31119#701067, @tcberner wrote:

The build fails for me on 140-amd64 [1]

Fix building in pourdriere on amd64, i386 fails to build.

USES=pkgconfig not pkgconf

Fix devel/pkgconf dependency (USE=pkgconf)

Add devel/pkgconf dependency
Remove amd64 limit, although I couldn't get it to compile for i386 it may work for other archs.

Regenerate patch with make makepatch
Don't unnecessarily define DISTNAME.

In D31119#700822, @koobs wrote:

@me_cameronkatri.com Could you provide this change (new port) as a diff against the existing games/lwjgl port and add a comment regarding patch-build.xml and why its necessary.

patch-build.xml stops the building of the *-sources.jar and *-javadoc.jar files that I was deleting before, because they don’t get installed, it very much improves the build time.

Also, while talking with someone on IRC about updating and level'ing up all our minecraft ports, I investigated MultiMC as the second consumer of lwgl and couldn't identify it as a dependency in their upstream build docs [1]

Well lwjgl isn’t a dep of multimc, but of Minecraft, on other platforms multiMC will download the lwjgl classes from minecraft.net, but lwjgl doesn’t work in the linuxulator, hence minecraft-client to replace the downloaded with the installed libs.

If lwgl isn't an actual dependency or MultiMC (our port version 0.6.11 is now .1 behind the latest release) can use lwgl3, then we should update the existing port.

Minecraft 1.12 and below use lwjgl but Minecraft 1.13 and up use lwjgl3, I know that I and many others still regularly play 1.12.2 and below because of the fact they are very popular with mod makers and modpack makers. So I want them to be separated so that I can install both.

See also the following bug https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255349 which provided LWGL3 as well

[1] https://github.com/MultiMC/MultiMC5/blob/develop/BUILD.md

Don't include bsd.port.pre.mk

Add link to website in pkg-descr
Patch out javadoc and sources targets from build.xml
Run portclippy

In D31119#700361, @tcberner wrote:

I hope you are planing to get your fork merged upstream? :)

The lwjgl devs don’t want to support targets that they do not have CI for, although many people have offered CI runners for then running FreeBSD they still seem to have no interest.

Add audio/opus, and devel/ocl-icd to LIB_DEPENDS which are all dlopen()d
Use USE_GNOME instead of LIB_DEPENDS
Add USE_XORG with x11, which is dlopen()d
Add egl and glesv2 to USE_GL which are also dlopen()d
Remove duplicate BUILD_DEPENDS on devel/dyncall