Page MenuHomeFreeBSD

PR241491: bin/ps: use locale-based string specifiers
ClosedPublic

Authored by yuripv on Oct 26 2019, 4:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 16, 7:41 PM
Unknown Object (File)
Mon, Sep 15, 10:47 AM
Unknown Object (File)
Aug 16 2025, 2:03 PM
Unknown Object (File)
Aug 12 2025, 4:58 PM
Unknown Object (File)
Aug 3 2025, 5:44 AM
Unknown Object (File)
Jul 23 2025, 7:39 AM
Unknown Object (File)
Jul 22 2025, 10:53 AM
Unknown Object (File)
Jul 19 2025, 9:31 AM
Subscribers

Details

Summary

Use %hs instead of %s in bin/ps for it to correctly output locale specific date/time (at least).

Test Plan

Compare output of LC_ALL=uk_UA.UTF-8 ps -o lstart and LC_ALL=uk_UA.KOI8-U ps -o lstart | iconv -f koi8-u. Also reproducer from the PR.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks great! Thanks....

This revision is now accepted and ready to land.Oct 29 2019, 12:12 AM
This revision was automatically updated to reflect the committed changes.

The "%hs" bits look good, but why do you add the call to xo_no_setlocale()?

Thanks,
Phil

In D22160#555029, @phil wrote:

The "%hs" bits look good, but why do you add the call to xo_no_setlocale()?

Thanks,
Phil

Oh, I didn't notice it's already fixed in libxo, will remove.

In D22160#555029, @phil wrote:

The "%hs" bits look good, but why do you add the call to xo_no_setlocale()?

Thanks,
Phil

Removed in followup commit.