Page MenuHomeFreeBSD
Differential D46893

libkldelf: use warnx instead of printf
ClosedPublic
Actions

Authored by khng on Oct 4 2024, 1:11 AM.
Tags
None
Referenced Files
F146985951: D46893.id144183.diff
Sat, Mar 7, 9:01 AM
F146902120: D46893.id144183.diff
Fri, Mar 6, 3:10 PM
Unknown Object (File)
Wed, Mar 4, 10:00 AM
Unknown Object (File)
Tue, Mar 3, 10:28 PM
Unknown Object (File)
Tue, Feb 24, 3:47 AM
Unknown Object (File)
Sun, Feb 8, 10:59 PM
Unknown Object (File)
Sun, Feb 8, 1:42 PM
Unknown Object (File)
Sun, Feb 8, 1:03 PM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
jhb
Commits
rG599c4399e9b8: libkldelf: use warnx instead of printf
rG550ee2d03c5b: libkldelf: use warnx instead of printf
Summary

Sponsored by: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

khng created this revision.Oct 4 2024, 1:11 AM
Herald added a subscriber: imp. · View Herald TranscriptOct 4 2024, 1:11 AM
khng requested review of this revision.Oct 4 2024, 1:11 AM
Harbormaster completed remote builds in B59702: Diff 144183.Oct 4 2024, 1:11 AM
khng added a parent revision: D46891: libkldelf: returns EOPNOTSUPP for unrecognizable relocations.Oct 4 2024, 1:11 AM
emaste accepted this revision.Oct 4 2024, 12:04 PM
This revision is now accepted and ready to land.Oct 4 2024, 12:04 PM
markj added a comment.Oct 4 2024, 12:33 PM

warnx() appends a newline, so this isn't going to give the same output.

emaste requested changes to this revision.Oct 4 2024, 12:37 PM
This revision now requires changes to proceed.Oct 4 2024, 12:37 PM
emaste added a comment.Oct 4 2024, 12:39 PM

Oh, yeah. The ones in ef_obj.c should be fine with the \ns removed.
ef_print_phdr is probably intended to go to stdout?

khng updated this revision to Diff 144274.Oct 4 2024, 9:23 PM

Fix per markj@'s comment. ef_print_phdr related part now is left unchanged for now.

Harbormaster completed remote builds in B59764: Diff 144274.Oct 4 2024, 9:23 PM
khng updated this revision to Diff 144275.Oct 4 2024, 9:24 PM

Oops.

Harbormaster completed remote builds in B59765: Diff 144275.Oct 4 2024, 9:24 PM
markj accepted this revision.Oct 4 2024, 11:43 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 8 2024, 4:29 AM
Closed by commit rG550ee2d03c5b: libkldelf: use warnx instead of printf (authored by khng). · Explain Why
This revision was automatically updated to reflect the committed changes.
khng added a commit: rG550ee2d03c5b: libkldelf: use warnx instead of printf.
khng added a reverting change: rG6df3a2d1bfed: Revert "libkldelf: use warnx instead of printf".Oct 8 2024, 7:48 PM
khng added a commit: rG599c4399e9b8: libkldelf: use warnx instead of printf.Oct 18 2024, 8:22 PM

Revision Contents
Changeset List

PathSize
lib/
libkldelf/
12 lines

Diff 144448

View Options

lib/libkldelf/ef_obj.c

Loading...