Page MenuHomeFreeBSD

contrib/libxo: fix API header files inclusions in C++ source files
ClosedPublic

Authored by khng on Dec 5 2024, 2:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 2:41 AM
Unknown Object (File)
Wed, Oct 8, 8:31 AM
Unknown Object (File)
Fri, Oct 3, 2:33 PM
Unknown Object (File)
Wed, Oct 1, 11:02 AM
Unknown Object (File)
Wed, Oct 1, 3:13 AM
Unknown Object (File)
Wed, Oct 1, 2:01 AM
Unknown Object (File)
Tue, Sep 30, 8:22 AM
Unknown Object (File)
Fri, Sep 26, 7:33 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

khng added a subscriber: khng.

@phil for a confirmation as well.

This revision is now accepted and ready to land.Dec 5 2024, 9:56 PM

Patch looks fine. I'll add to the main libxo repo.

Thanks,
Phil

Patch looks fine. I'll add to the main libxo repo.

Thanks,
Phil

FYI @aokblast also submitted as https://github.com/Juniper/libxo/pull/100

This revision now requires review to proceed.Jan 16 2025, 6:09 PM

Looks good, not surprised upstream accepted it :).

This revision is now accepted and ready to land.Jan 16 2025, 6:25 PM
khng edited reviewers, added: aokblast; removed: khng.
phil requested changes to this revision.Aug 25 2025, 5:10 PM

Why do you need this on xo_buf.h, an internal file?

In the FWIW department: It always seems odd that C++ needs decoration in non-C++ files, rather that have this knowledge in compiler command line arguments (e.g. "--c-include /usr/include").

Thanks,
Phil

This revision now requires changes to proceed.Aug 25 2025, 5:10 PM

Why do you need this on xo_buf.h, an internal file?

In the FWIW department: It always seems odd that C++ needs decoration in non-C++ files, rather that have this knowledge in compiler command line arguments (e.g. "--c-include /usr/include").

Thanks,
Phil

Oops sorry. @khng tells me that he will figure it out before merging it.

khng retitled this revision from contrib/libxo/libxo/*.h fix libxo header include when the source is C++ to contrib/libxo: fix API header files inclusions in C++ source files.Sep 1 2025, 2:47 AM
khng edited the summary of this revision. (Show Details)

Looks good. Thanks..

This revision is now accepted and ready to land.Sep 2 2025, 1:36 PM