Page MenuHomeFreeBSD
Differential D47930

contrib/libxo/libxo/*.h fix libxo header include when the source is C++
AcceptedPublic
Actions

Authored by aokblast on Dec 5 2024, 2:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 10 2024, 8:14 AM
Unknown Object (File)
Dec 6 2024, 7:50 PM
Subscribers
imp
khng

Details

Reviewers
lwhsu
phil
khng
Summary

C++ needs extern C to disable C++ name mangling.
To use libxo in C++ it is better to include extern "C" guardian

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 60967
Build 57851: arc lint + arc unit

Event Timeline

aokblast created this revision.Dec 5 2024, 2:09 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 5 2024, 2:09 PM
aokblast requested review of this revision.Dec 5 2024, 2:09 PM
Harbormaster completed remote builds in B60967: Diff 147529.Dec 5 2024, 2:09 PM
aokblast added reviewers: lwhsu, phil.Dec 5 2024, 2:11 PM
khng accepted this revision.Dec 5 2024, 9:56 PM
khng added a subscriber: khng.

@phil for a confirmation as well.

This revision is now accepted and ready to land.Dec 5 2024, 9:56 PM
phil added a comment.Dec 6 2024, 7:35 PM

Patch looks fine. I'll add to the main libxo repo.

Thanks,
Phil

lwhsu added a comment.Dec 7 2024, 5:44 PM
In D47930#1093223, @phil wrote:

Patch looks fine. I'll add to the main libxo repo.

Thanks,
Phil

FYI @aokblast also submitted as https://github.com/Juniper/libxo/pull/100

Revision Contents
Changeset List

PathSize
contrib/
libxo/
libxo/
8 lines
8 lines
8 lines
7 lines

Diff 147529

View Options

contrib/libxo/libxo/xo.h

Loading...
View Options

contrib/libxo/libxo/xo_buf.h

Loading...
View Options

contrib/libxo/libxo/xo_encoder.h

Loading...
View Options

contrib/libxo/libxo/xo_explicit.h

Loading...