*.h fix libxo header include when the source is C++
AcceptedPublic
Actions

Authored by aokblast on Dec 5 2024, 2:09 PM.

Details

Reviewers

lwhsu
phil
khng
imp

Summary

C++ needs extern C to disable C++ name mangling.
To use libxo in C++ it is better to include extern "C" guardian

Diff Detail

Repository

rG FreeBSD src repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 61775
Build 58659: arc lint + arc unit

Event Timeline

aokblast created this revision.Dec 5 2024, 2:09 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 5 2024, 2:09 PM

aokblast requested review of this revision.Dec 5 2024, 2:09 PM

Harbormaster completed remote builds in B60967: Diff 147529.Dec 5 2024, 2:09 PM

aokblast added reviewers: lwhsu, phil.Dec 5 2024, 2:11 PM

@phil for a confirmation as well.

This revision is now accepted and ready to land.Dec 5 2024, 9:56 PM

Patch looks fine. I'll add to the main libxo repo.

Thanks,
Phil

In D47930#1093223, @phil wrote:

Patch looks fine. I'll add to the main libxo repo.

Thanks,
Phil

FYI @aokblast also submitted as https://github.com/Juniper/libxo/pull/100

Update with github version

This revision now requires review to proceed.Jan 16 2025, 6:09 PM

Harbormaster completed remote builds in B61775: Diff 149398.Jan 16 2025, 6:10 PM

Looks good, not surprised upstream accepted it :).

This revision is now accepted and ready to land.Jan 16 2025, 6:25 PM

Revision Contents
Changeset List

Path

Size

contrib/

libxo/

xo.h

8 lines

xo_buf.h

8 lines

Diff 149398

View Options

contrib/libxo/libxo/xo.h