Page MenuHomeFreeBSD
Feed Advanced Search

Fri, Dec 6

vmaffione updated the diff for D22657: bhyve: add wrapper for debug printf statements.

Removed "all rights reserved" line.
Fix multi-line debug logs in pci_xhci.c, splitting them into multiple PRINTLN() statements.

Fri, Dec 6, 9:27 PM

Tue, Dec 3

vmaffione created D22657: bhyve: add wrapper for debug printf statements.
Tue, Dec 3, 10:26 PM

Fri, Nov 29

vmaffione updated the diff for D22552: bhyve: uniform printf format string newlines.

Fixed all the print statements.

Fri, Nov 29, 6:37 PM

Mon, Nov 25

vmaffione created D22552: bhyve: uniform printf format string newlines.
Mon, Nov 25, 9:21 PM

Tue, Nov 19

vmaffione added a comment to D22440: bhyve: virtio-net: disable receive until features are negotiated.

Il giorno mar 19 nov 2019 alle ore 19:21 aleksandr.fedorov_itglobal.com
(Aleksandr Fedorov) <phabric-noreply@freebsd.org> ha scritto:

Tue, Nov 19, 9:12 PM
vmaffione added inline comments to D22440: bhyve: virtio-net: disable receive until features are negotiated.
Tue, Nov 19, 5:44 PM
vmaffione updated the diff for D22440: bhyve: virtio-net: disable receive until features are negotiated.

Init rx_merge to 0

Tue, Nov 19, 5:43 PM
vmaffione added a comment to D22390: netmap: Check if we already ran mmap before we attempt it.

I'll do it tonight.

Tue, Nov 19, 7:07 AM

Mon, Nov 18

vmaffione updated the diff for D22440: bhyve: virtio-net: disable receive until features are negotiated.

Addressed comment.

Mon, Nov 18, 9:57 PM
vmaffione created D22440: bhyve: virtio-net: disable receive until features are negotiated.
Mon, Nov 18, 9:39 PM
vmaffione accepted D22390: netmap: Check if we already ran mmap before we attempt it.

Just one question: did this change come from some usage scenario? In theory you should not call nm_mmap() more than once.

Mon, Nov 18, 8:32 PM

Sun, Nov 17

vmaffione added a reviewer for D22390: netmap: Check if we already ran mmap before we attempt it: g.lettieri_iet.unipi.it.
Sun, Nov 17, 2:59 PM
vmaffione added inline comments to D22390: netmap: Check if we already ran mmap before we attempt it.
Sun, Nov 17, 2:58 PM

Mon, Nov 11

vmaffione updated the diff for D22286: bhyve: rework mevent processing to fix a race condition.

Addressed more comments.

Mon, Nov 11, 9:23 PM
vmaffione added inline comments to D22286: bhyve: rework mevent processing to fix a race condition.
Mon, Nov 11, 6:51 PM
vmaffione added a comment to D22286: bhyve: rework mevent processing to fix a race condition.

Addressed more comments.

Mon, Nov 11, 6:49 PM
vmaffione updated the diff for D22286: bhyve: rework mevent processing to fix a race condition.

Move check under the lock.
Minor refactor.

Mon, Nov 11, 6:49 PM

Sun, Nov 10

vmaffione added a comment to D22286: bhyve: rework mevent processing to fix a race condition.

Comments addressed.

Sun, Nov 10, 7:05 PM
vmaffione updated the diff for D22286: bhyve: rework mevent processing to fix a race condition.

Addressed two comments.

Sun, Nov 10, 7:05 PM

Sat, Nov 9

vmaffione updated subscribers of D21315: bhyve: tap: add support for offloads.
Sat, Nov 9, 5:56 PM
vmaffione planned changes to D21315: bhyve: tap: add support for offloads.

Unfortunately there is a blocker for this change.

Sat, Nov 9, 5:56 PM
vmaffione added a comment to D22286: bhyve: rework mevent processing to fix a race condition.

Thanks for testing.

Sat, Nov 9, 3:14 PM
vmaffione added a reviewer for D22286: bhyve: rework mevent processing to fix a race condition: markj.
Sat, Nov 9, 9:48 AM

Fri, Nov 8

vmaffione updated the summary of D22286: bhyve: rework mevent processing to fix a race condition.
Fri, Nov 8, 9:49 PM
vmaffione created D22286: bhyve: rework mevent processing to fix a race condition.
Fri, Nov 8, 9:43 PM

Nov 7 2019

vmaffione added inline comments to D21315: bhyve: tap: add support for offloads.
Nov 7 2019, 9:56 PM
vmaffione updated the diff for D21315: bhyve: tap: add support for offloads.

Addressed reviewer comments.

Nov 7 2019, 9:50 PM
vmaffione added a comment to D21007: bhyve: add support for virtio-net mergeable rx buffers.

Thanks for looking at this.
No, the patch is ready as is (I just retested everything again).

Nov 7 2019, 8:55 PM

Oct 31 2019

vmaffione added a comment to D20987: bhyve: add backend rx backpressure to virtio-net.

ping

Oct 31 2019, 9:03 PM

Oct 29 2019

vmaffione added a comment to D22146: add valectl to the system commands.

No problems and thanks for the in-depth review.

Oct 29 2019, 5:41 PM
vmaffione updated the diff for D22146: add valectl to the system commands.

Addressed more comments.
valectl.4 renamed to valectl.8

Oct 29 2019, 5:40 PM

Oct 28 2019

vmaffione added inline comments to D22146: add valectl to the system commands.
Oct 28 2019, 9:31 PM
vmaffione updated the diff for D22146: add valectl to the system commands.

(removed Makefile.depend again)

Oct 28 2019, 9:05 PM
vmaffione updated the diff for D22146: add valectl to the system commands.

Addressed reviewer comments.

Oct 28 2019, 9:03 PM

Oct 27 2019

vmaffione added a comment to D22146: add valectl to the system commands.

Sounds good to me.
The valectl program already fails if netmap is not present, so no build-time check for MK_NETMAP or DEV_NETMAP is really needed. I was just thinking of people that want to shrink the image size as much as possible (and save a few KB in this case).

Oct 27 2019, 11:51 AM
vmaffione updated the diff for D22146: add valectl to the system commands.

Removed Makefile.depend

Oct 27 2019, 11:39 AM

Oct 26 2019

vmaffione retitled D22146: add valectl to the system commands from add vale-ctl to the system commands to add valectl to the system commands.
Oct 26 2019, 12:10 PM
vmaffione added a comment to D22146: add valectl to the system commands.

Thanks for the review (and sorry for the trivial flaws).
Yes, I agree to stick to the existing convention for *ctl names.

Oct 26 2019, 12:10 PM
vmaffione updated the diff for D22146: add valectl to the system commands.

Addressed reviewers' comments

Oct 26 2019, 12:07 PM

Oct 24 2019

vmaffione added reviewers for D22146: add valectl to the system commands: kevans, lwhsu.
Oct 24 2019, 8:23 PM
vmaffione created D22146: add valectl to the system commands.
Oct 24 2019, 8:19 PM

Oct 20 2019

vmaffione added inline comments to D21315: bhyve: tap: add support for offloads.
Oct 20 2019, 10:09 AM

Oct 18 2019

vmaffione added a comment to D21263: tap: add support for virtio-net offloads.

Il giorno ven 18 ott 2019 alle ore 23:47 kevans (Kyle Evans) <
phabric-noreply@freebsd.org> ha scritto:

Oct 18 2019, 10:12 PM
vmaffione added a comment to D21263: tap: add support for virtio-net offloads.

Thanks. Yes, I don't see either any reason why we want to reset device configuration (vnet hdr, mtu, etc.) on close.

Oct 18 2019, 9:43 PM

Oct 11 2019

vmaffione added a comment to D20987: bhyve: add backend rx backpressure to virtio-net.

Any reviews?
Thanks

Oct 11 2019, 4:48 PM

Oct 8 2019

vmaffione added inline comments to D21263: tap: add support for virtio-net offloads.
Oct 8 2019, 8:04 PM
vmaffione updated the diff for D21263: tap: add support for virtio-net offloads.

Don't call tun_vnethdr_set() on pid change.

Oct 8 2019, 8:00 PM
vmaffione added inline comments to D21263: tap: add support for virtio-net offloads.
Oct 8 2019, 6:03 PM
vmaffione updated the diff for D21263: tap: add support for virtio-net offloads.

Addressed comments from kevans:

  • style fixes
  • reset vhdrlen to 0 when PID changes; this required the introduction of a new helper function (tun_vnethdr_set)
Oct 8 2019, 6:02 PM

Sep 29 2019

vmaffione added a comment to D20987: bhyve: add backend rx backpressure to virtio-net.

Note: this is the next patch to be reviewed. Thanks.

Sep 29 2019, 7:55 PM

Sep 22 2019

vmaffione added a comment to D20973: bhyve: support for enabling/disabling the net backend.

Does it look good now?

Sep 22 2019, 8:54 AM

Sep 15 2019

vmaffione updated the diff for D20987: bhyve: add backend rx backpressure to virtio-net.

Follow-up change after updating D20973.
Define mevent_add_disabled here.

Sep 15 2019, 2:35 PM
vmaffione added a comment to D20973: bhyve: support for enabling/disabling the net backend.

Regarding mevent_add_disabled, I can defer that to the next patch.

Sep 15 2019, 2:10 PM
vmaffione added inline comments to D20973: bhyve: support for enabling/disabling the net backend.
Sep 15 2019, 2:10 PM
vmaffione updated the diff for D20973: bhyve: support for enabling/disabling the net backend.

Addressed jhb's comments.

Sep 15 2019, 2:08 PM

Sep 4 2019

vmaffione added a comment to D20973: bhyve: support for enabling/disabling the net backend.

Thanks a lot!

Sep 4 2019, 8:38 PM

Sep 3 2019

vmaffione added a comment to D20973: bhyve: support for enabling/disabling the net backend.

ping

Sep 3 2019, 6:48 PM

Aug 19 2019

vmaffione added a reviewer for D21263: tap: add support for virtio-net offloads: markj.
Aug 19 2019, 6:05 PM
vmaffione added inline comments to D21302: if_tuntap: minor improvements.
Aug 19 2019, 5:14 PM

Aug 18 2019

vmaffione created D21315: bhyve: tap: add support for offloads.
Aug 18 2019, 10:49 AM
vmaffione added a comment to D21263: tap: add support for virtio-net offloads.

Minor changes.

Aug 18 2019, 10:45 AM
vmaffione added a reviewer for D21312: link ptnet(4) man page to the build system: bcr.
Aug 18 2019, 9:27 AM
vmaffione created D21312: link ptnet(4) man page to the build system.
Aug 18 2019, 9:26 AM

Aug 17 2019

vmaffione updated the test plan for D21302: if_tuntap: minor improvements.
Aug 17 2019, 1:19 PM
vmaffione created D21302: if_tuntap: minor improvements.
Aug 17 2019, 1:12 PM

Aug 16 2019

vmaffione added a comment to D21263: tap: add support for virtio-net offloads.

The ptnet(4) case is a bit different, since the driver knows at attach time which if_capabilities are supported, and those are not going to change.
On the other hand, with these changes to tap(4) the user can change if_capabilities dynamically.

Aug 16 2019, 10:14 PM
vmaffione added a comment to D21263: tap: add support for virtio-net offloads.

Added SIOCSIFCAP support. Addressed more comments.

Aug 16 2019, 10:08 PM
vmaffione added a comment to D21263: tap: add support for virtio-net offloads.

The inline functions added to virtio_net.h were simply copy-pasted from if_vtnet.c to if_ptnet.c in the first place. And yes, I plan to make also if_vtnet.c use the same code in future. I haven't done it yet because if_vtnet.c increments device specific statistic counters.

Aug 16 2019, 7:45 PM
vmaffione added a comment to D21263: tap: add support for virtio-net offloads.

Addressed suggestions.

Aug 16 2019, 7:37 PM

Aug 14 2019

vmaffione updated the summary of D21263: tap: add support for virtio-net offloads.
Aug 14 2019, 6:32 PM
vmaffione created D21263: tap: add support for virtio-net offloads.
Aug 14 2019, 2:32 PM

Aug 10 2019

vmaffione added a comment to D21007: bhyve: add support for virtio-net mergeable rx buffers.

Any opinions on this change?

Aug 10 2019, 6:40 PM
vmaffione added a comment to D20987: bhyve: add backend rx backpressure to virtio-net.

Any additional opinions on this patch?

Aug 10 2019, 6:39 PM
vmaffione added a comment to D20973: bhyve: support for enabling/disabling the net backend.

Any opinions on this patch?

Aug 10 2019, 6:39 PM

Jul 24 2019

vmaffione added a comment to D21007: bhyve: add support for virtio-net mergeable rx buffers.

Thanks a lot for your effort!
To be honest I'm not sure why the throughput increases so much, since TSO (64KB unchecksummed packets) is being used in both cases.
The main difference is that with mergeable rx buffers there is less pressure on the guest memory allocators, since the driver can allocate 2K clusters, rather than bigger packets.
Also, with mergeable rx buffer bhyve may do a little more work, because it needs to call vq_gechain() 33 times in order to receive each packet.
In any case, your results look very good to me, and they also agree with mine (taken with a smaller and less powerful machine).

Jul 24 2019, 7:59 PM

Jul 23 2019

vmaffione added a comment to D21007: bhyve: add support for virtio-net mergeable rx buffers.

Thanks. Did you notice any change in terms of performance?

Jul 23 2019, 4:27 PM

Jul 22 2019

vmaffione added inline comments to D21007: bhyve: add support for virtio-net mergeable rx buffers.
Jul 22 2019, 7:30 PM
vmaffione added a comment to D21007: bhyve: add support for virtio-net mergeable rx buffers.

Fix issue identified by @aleksandr.fedorov_itglobal.com

Jul 22 2019, 7:27 PM

Jul 20 2019

vmaffione retitled D21007: bhyve: add support for virtio-net mergeable rx buffers from bhyve: add support virtio-net mergeable rx buffers to bhyve: add support for virtio-net mergeable rx buffers.
Jul 20 2019, 9:29 AM
vmaffione created D21007: bhyve: add support for virtio-net mergeable rx buffers.
Jul 20 2019, 9:29 AM

Jul 19 2019

vmaffione updated subscribers of D20987: bhyve: add backend rx backpressure to virtio-net.
Jul 19 2019, 7:07 PM
vmaffione updated the test plan for D20987: bhyve: add backend rx backpressure to virtio-net.
Jul 19 2019, 4:42 PM
vmaffione updated the test plan for D20987: bhyve: add backend rx backpressure to virtio-net.
Jul 19 2019, 4:41 PM

Jul 18 2019

vmaffione updated the summary of D20987: bhyve: add backend rx backpressure to virtio-net.
Jul 18 2019, 9:19 PM
vmaffione created D20987: bhyve: add backend rx backpressure to virtio-net.
Jul 18 2019, 9:18 PM
vmaffione added a comment to D20973: bhyve: support for enabling/disabling the net backend.

Removed traling space.

Jul 18 2019, 8:22 PM

Jul 16 2019

vmaffione added a comment to D20973: bhyve: support for enabling/disabling the net backend.

Upload the right patch

Jul 16 2019, 7:31 PM
vmaffione added a comment to D20973: bhyve: support for enabling/disabling the net backend.

minimize patch by adding mevent_add_disabled().

Jul 16 2019, 7:28 PM
vmaffione updated the summary of D20973: bhyve: support for enabling/disabling the net backend.

Start the backends with receive enabled for the moment being.

Jul 16 2019, 7:17 PM
vmaffione added inline comments to D20973: bhyve: support for enabling/disabling the net backend.
Jul 16 2019, 5:32 PM
vmaffione updated the summary of D20973: bhyve: support for enabling/disabling the net backend.
Jul 16 2019, 5:01 PM
vmaffione created D20973: bhyve: support for enabling/disabling the net backend.
Jul 16 2019, 4:58 PM

Jul 8 2019

vmaffione created D20883: bhyve: net_backends.c: add missing __FBSDID.
Jul 8 2019, 9:23 PM
vmaffione added a comment to D20874: bhyve: add missing license identifiers in net_utils and net_backend.

Changed the patch to update the license identifiers only.

Jul 8 2019, 9:13 PM

Jul 7 2019

vmaffione created D20874: bhyve: add missing license identifiers in net_utils and net_backend.
Jul 7 2019, 12:27 PM

Jul 4 2019

vmaffione updated vmaffione.
Jul 4 2019, 9:37 PM
vmaffione updated vmaffione.
Jul 4 2019, 6:23 PM

Jul 1 2019

D20824: Fix netmap + vlan panics is now accepted and ready to land.

Looks good, thanks.
The netmap unit tests and integration tests still pass with these changes.

Jul 1 2019, 7:52 PM
vmaffione added a comment to D20659: bhyve: abstraction for network backends.

Thanks. This touches also TAP and setups, so we need tests with TAP.
Also, we would need to check that TAP+e1000 works.

Jul 1 2019, 4:13 PM

Jun 30 2019

vmaffione added a comment to D20659: bhyve: abstraction for network backends.

Thanks for the review. I actually don't have yet a real testbed for this (will get one soon), and I can only do functional tests in a nested KVM VM. Any test is welcome.

Jun 30 2019, 8:05 PM