Page MenuHomeFreeBSD
Feed Advanced Search

Mon, Mar 25

vmaffione accepted D44371: netmap: Address errors on memory free in netmap_generic.

Thanks!

Mon, Mar 25, 6:31 PM
vmaffione requested changes to D44371: netmap: Address errors on memory free in netmap_generic.

Last modification.
Thanks

Mon, Mar 25, 10:04 AM

Wed, Mar 20

vmaffione requested changes to D44371: netmap: Address errors on memory free in netmap_generic.
Wed, Mar 20, 2:11 PM

Tue, Mar 19

vmaffione requested changes to D44371: netmap: Address errors on memory free in netmap_generic.

Any additional tests with pkt-gen in TX or RX mode over iflib interfaces and virtio-net ones?
E.g. two VMs/machines connected back to back with one transmitting and the other receiving, to stress test it?
Setting the sys.dev.netmap.admode sysctl to 2 will force emulated netmap even if the interface has native support.

Tue, Mar 19, 4:46 PM

Mon, Mar 18

vmaffione requested changes to D44371: netmap: Address errors on memory free in netmap_generic.
Mon, Mar 18, 6:57 PM

Feb 4 2024

vmaffione accepted D43702: arm64: Add netmap(4) to default kernel config.

No objections on my side.

Feb 4 2024, 11:41 AM

Jan 20 2024

vmaffione added a comment to D43460: wg: Add netmap support.

Thanks.
I'm still wondering whether anyone would call wg_output(), though...

In addition to the hw TX/RX rings, have you tested that the host RX/TX rings are fully functional?
i.e., if you run bridge between the hw rings and the host rings like this

# bridge -i netmap:wg0 -i netmap:wg0^

with all the offloads disabled on wg0, you should be able to use wg0 as if netmap did not exist.

Indeed, this was my smoke test while developing the patch.

Jan 20 2024, 5:17 PM
vmaffione accepted D43460: wg: Add netmap support.

Thanks.
I'm still wondering whether anyone would call wg_output(), though...

Jan 20 2024, 1:39 PM

Jan 18 2024

vmaffione requested changes to D43460: wg: Add netmap support.

Looks pretty good to me, however I suggest adding some more comments to make easier to understand the four datapaths.
It's very confusing for me that I know the netmap code. I can only imagine for the casual reader...

Jan 18 2024, 3:16 PM

Dec 29 2023

vmaffione committed rGee5804da116f: netmap: fix unit tests (authored by vmaffione).
netmap: fix unit tests
Dec 29 2023, 7:49 AM

Dec 27 2023

vmaffione accepted D43200: netmap: Ignore errors in CSB_WRITE().
Dec 27 2023, 8:11 AM

Dec 21 2023

vmaffione committed rGad874544d9f0: libnetmap: remove interface name validation (authored by vmaffione).
libnetmap: remove interface name validation
Dec 21 2023, 2:47 PM
vmaffione closed D42485: libnetmap: change interface name character exclusion approach.
Dec 21 2023, 2:46 PM

Dec 1 2023

vmaffione accepted D42485: libnetmap: change interface name character exclusion approach.

Do you need me to commit this?

Dec 1 2023, 10:41 AM

Nov 23 2023

vmaffione added a comment to D42689: bhyve: Split backends into separate files.

Ok

Nov 23 2023, 1:42 PM

Nov 8 2023

vmaffione requested changes to D42485: libnetmap: change interface name character exclusion approach.

{ and } are missing.
Makes sense to me in general, but please also open a pull request here https://github.com/luigirizzo/netmap/
where the libnetmap developer can see it.

Nov 8 2023, 8:18 AM

May 9 2023

vmaffione committed rGb4e9bfd51c2d: netmap: pkt-gen: sync with upstream (authored by vmaffione).
netmap: pkt-gen: sync with upstream
May 9 2023, 8:40 PM

Apr 26 2023

vmaffione closed D39760: pkt-gen: Sync with upstream.
Apr 26 2023, 8:36 PM
vmaffione committed rG8c3b8c838674: netmap: pkt-gen: sync with upstream (authored by vmaffione).
netmap: pkt-gen: sync with upstream
Apr 26 2023, 8:36 PM

Apr 25 2023

vmaffione accepted D39760: pkt-gen: Sync with upstream.

I can commit this if needed

Apr 25 2023, 9:20 AM

Apr 9 2023

vmaffione added a comment to D39431: netmap: Add some simple regression tests.

Sorry for the delay. I've little experience with the FreeBSD test suite, so I wouldn't know...

Apr 9 2023, 4:53 PM

Apr 5 2023

vmaffione committed rGd94a88d249b0: netmap: fix build issue in unit test (authored by vmaffione).
netmap: fix build issue in unit test
Apr 5 2023, 10:24 PM
vmaffione added a comment to D39426: netmap: Handle packet batches in generic mode.

Yeah, that makes sense, thanks.

Apr 5 2023, 9:00 PM
vmaffione added a comment to D39426: netmap: Handle packet batches in generic mode.

Interesting, thanks. I wonder why the behaviour is different with AMD Ryzen.
Which setup (machine, NIC) did you use to reproduce the issue?

Apr 5 2023, 8:54 PM
vmaffione added a comment to D39431: netmap: Add some simple regression tests.

If useful, please note that there are already a bunch of integration tests in the github netmap repo, e.g.:
https://github.com/luigirizzo/netmap/blob/master/utils/randomized_tests

Apr 5 2023, 8:47 PM
vmaffione committed rGb74063f03a83: netmap: fix copyin/copyout of nmreq options list (authored by vmaffione).
netmap: fix copyin/copyout of nmreq options list
Apr 5 2023, 8:42 PM
vmaffione added a comment to D39426: netmap: Handle packet batches in generic mode.

Any example other than iflib? (iflib has native support...)

Apr 5 2023, 8:40 PM
vmaffione accepted D39426: netmap: Handle packet batches in generic mode.
Apr 5 2023, 8:40 PM

Mar 29 2023

vmaffione added a comment to D39015: tuntap: Add netmap support for both tap(4) and tun(4) interfaces.

tap mode is supposed to work unmodified... I've not tried on FreeBSD, but on Linux it definitely works.

Mar 29 2023, 8:47 PM

Mar 28 2023

vmaffione committed rG1e01c7ed6281: netmap: get rid of save_if_input for emulated adapters (authored by vmaffione).
netmap: get rid of save_if_input for emulated adapters
Mar 28 2023, 9:59 PM
vmaffione added a comment to D39015: tuntap: Add netmap support for both tap(4) and tun(4) interfaces.

No worries.

Mar 28 2023, 9:51 PM

Mar 22 2023

vmaffione added a comment to D39015: tuntap: Add netmap support for both tap(4) and tun(4) interfaces.

What is the use case for this change?
(Netmap was not originally supposed to work with L3 interfaces)

Mar 22 2023, 10:31 PM
vmaffione accepted D38065: netmap: Fix queue stalls on generic interfaces.

Looks good.
How are the tests going?

Mar 22 2023, 9:41 PM

Mar 21 2023

vmaffione committed rGe2a431a0ffb6: netmap: fix copyin/copyout of nmreq options list (authored by vmaffione).
netmap: fix copyin/copyout of nmreq options list
Mar 21 2023, 11:28 PM

Mar 20 2023

vmaffione added inline comments to D38065: netmap: Fix queue stalls on generic interfaces.
Mar 20 2023, 9:45 PM

Mar 15 2023

vmaffione added inline comments to D38065: netmap: Fix queue stalls on generic interfaces.
Mar 15 2023, 10:47 PM

Mar 14 2023

vmaffione committed rG6c9fe357435d: netmap: get rid of save_if_input for emulated adapters (authored by vmaffione).
netmap: get rid of save_if_input for emulated adapters
Mar 14 2023, 10:05 PM
vmaffione committed rG4e31d33bfe67: netmap: pkt-gen: init all slots of every tx ring (authored by vmaffione).
netmap: pkt-gen: init all slots of every tx ring
Mar 14 2023, 8:53 PM

Mar 13 2023

vmaffione accepted D38066: bridge: Add support for emulated netmap mode.
Mar 13 2023, 5:14 PM

Mar 12 2023

vmaffione added inline comments to D38066: bridge: Add support for emulated netmap mode.
Mar 12 2023, 9:58 AM
vmaffione accepted D38066: bridge: Add support for emulated netmap mode.
Mar 12 2023, 9:55 AM

Mar 11 2023

vmaffione added inline comments to D38066: bridge: Add support for emulated netmap mode.
Mar 11 2023, 6:22 PM
vmaffione committed rG22bf2a479f68: netmap: get rid of WNA() macro (authored by vmaffione).
netmap: get rid of WNA() macro
Mar 11 2023, 5:20 PM
vmaffione requested changes to D38066: bridge: Add support for emulated netmap mode.
Mar 11 2023, 4:11 PM

Mar 9 2023

vmaffione accepted D39001: netmap: Remove obsolete compatibility defines.
Mar 9 2023, 9:41 PM

Mar 6 2023

vmaffione committed rG506336f2cd1f: netmap: pkt-gen: init all slots of every tx ring (authored by vmaffione).
netmap: pkt-gen: init all slots of every tx ring
Mar 6 2023, 5:27 PM

Mar 1 2023

vmaffione added a comment to D38066: bridge: Add support for emulated netmap mode.

ok, so maybe we can go ahead

Mar 1 2023, 11:04 PM
vmaffione added inline comments to D38065: netmap: Fix queue stalls on generic interfaces.
Mar 1 2023, 11:00 PM
vmaffione added a comment to D38065: netmap: Fix queue stalls on generic interfaces.

Thanks for testing.
I think that's not a fatal problem, since (1) one is supposed to use native mode where available, and (2) this patch enables more use cases for emulated adapter, as you are suggesting.
In this regard, I would be curious to have an example where "a driver may reasonably defer freeing a small number of transmitted buffers indefinitely" (quoting your commit message above).

iflib may do this, for example. iflib_if_transmit() enqueues packets in a ring buffer which is drained by iflib_txq_drain(). iflib_encap() is responsible for queuing packets in a hardware TX ring. It asks the driver to raise completion interrupts by setting IPI_TX_INTR, but it doesn't do this for every packet.

Yes, iflib does not set IPI_TX_INTR for each packet in order to moderate TX interrupts and descriptor writeback overhead, but I'm pretty sure it guarantees that all the mbufs submitted to the hardware TX rings are m_free()d in a bounded amount of time.

In iflib, transmitted mbufs are freed only by iflib_completed_tx_reclaim(), which does not do any work in the reclaim <= thresh case. So if the interface is idle, nothing will force the reclamation of a small number of transmitted mbufs.

In theory you are right, although it looks like in practice thresh is always set to 0, so no deferral should happen.

Mar 1 2023, 10:55 PM

Feb 28 2023

vmaffione added a comment to D38065: netmap: Fix queue stalls on generic interfaces.

Thanks for testing.
I think that's not a fatal problem, since (1) one is supposed to use native mode where available, and (2) this patch enables more use cases for emulated adapter, as you are suggesting.
In this regard, I would be curious to have an example where "a driver may reasonably defer freeing a small number of transmitted buffers indefinitely" (quoting your commit message above).

iflib may do this, for example. iflib_if_transmit() enqueues packets in a ring buffer which is drained by iflib_txq_drain(). iflib_encap() is responsible for queuing packets in a hardware TX ring. It asks the driver to raise completion interrupts by setting IPI_TX_INTR, but it doesn't do this for every packet.

Feb 28 2023, 11:14 PM
vmaffione added a comment to D38066: bridge: Add support for emulated netmap mode.

Is the patch ready for review or maybe the man page changes still need to be reworked?

Feb 28 2023, 10:38 PM
vmaffione added a comment to D38066: bridge: Add support for emulated netmap mode.

From an ifnet perspective, if_bridge is already special. There is a unique ifnet hook, if_bridge_input, by which it receives packets. The if_input hook of a bridge interface is not used.

Just out of curiosity: isn't the if_input bridge0 hook used at line 2542 of if_bridge.c (multicast and broadcast)?
I'm trying to understand here... how is it possible that bridge0 if_input is not used? How can local packets reach the protocol stack for bridge0 (e.g. TCP/UDP sockets bound to bridge0) if not by means of if_input?

Yes, it's true that the bridge's if_input is called for that one special case, but that's not part of the regular data path.

Each ifnet which belongs to a bridge has a special hook, if_bridge_input, pointing to bridge_input(). Each ifnet also carries a pointer to the bridge softc. When a bridge member receives a packet, an mbuf chain is passed to ether_input_internal(), which checks to see if the receiving ifnet has if_bridge_input set. If so, the packet is passed to if_bridge_input/bridge_input().

bridge_input() can consume the packet and return NULL, which it does in the forwarding case, and then ether_input_internal() does nothing further. If the packet is local, bridge_input() uses the dst MAC to figure out which bridge port "received" the packet (this may be the bridge interface itself), and then returns the mbuf chain back to ether_input_internal(), which dispatches it to the protocol layers.

Feb 28 2023, 10:33 PM
vmaffione requested changes to D38065: netmap: Fix queue stalls on generic interfaces.
Feb 28 2023, 5:28 PM
vmaffione added a comment to D38065: netmap: Fix queue stalls on generic interfaces.

Thanks for testing.
I think that's not a fatal problem, since (1) one is supposed to use native mode where available, and (2) this patch enables more use cases for emulated adapter, as you are suggesting.
In this regard, I would be curious to have an example where "a driver may reasonably defer freeing a small number of transmitted buffers indefinitely" (quoting your commit message above).
indefinitely"

Feb 28 2023, 5:24 PM

Feb 27 2023

vmaffione accepted D38752: netmap: Fix compiler warnings in tools.

Yeah, if not used since you are here please clean it up.

Feb 27 2023, 5:26 PM

Feb 26 2023

vmaffione requested changes to D38752: netmap: Fix compiler warnings in tools.
Feb 26 2023, 3:41 PM
vmaffione accepted D38065: netmap: Fix queue stalls on generic interfaces.

Yeah, it is very possible that a regression has been introduced with iflib.
Note that it does not make sense to use emulated mode with iflib, since iflib has native support. So it's not surprising that the regression has gone unnoticed.

Feb 26 2023, 3:35 PM

Feb 19 2023

vmaffione added a comment to D38066: bridge: Add support for emulated netmap mode.

Then, in netmap's model, it doesn't really make sense for netmap to see non-local forwarded packets. But this makes netmap+if_bridge less useful. It also just seems like a surprising behaviour to me as a non-expert: above you wrote, 'the meaning of "opening an interface in netmap mode" is to steal and detach that interface from the kernel stack, so that netmap will see all the RX traffic arriving on the interface', and I would consider non-local packets arriving at bridge0 as "RX traffic arriving on the interface", so why shouldn't they be intercepted by netmap?

Non-local packets are not arriving at bridge0, IMHO, because they are meant to be forwarded, rather than be received by the host. That's why they should not be intercepted by netmap.
I don't think this is related to netmap. Netmap is just a different API to access the ifnet (alternative to raw sockets, for example), but it should not change the behaviour of an interface.

Feb 19 2023, 3:17 PM

Feb 14 2023

vmaffione added a comment to D38066: bridge: Add support for emulated netmap mode.

I'm sorry, I don't want to slow down you work, but I do not understand why this complication is needed..

No problem at all, thank you for reviewing.

The purpose of the host stack is to allow for some subset of the traffic (e.g. ssh traffic on interface em0) to keep going to the kernel stack (e.g. the sshd socket), although all the traffic is intercepted by netmap.
So you have a packet ready in your hw RX ring of em0, you look at that and you decide that it should go ahead like netmap never intercepted it; so you write it to the em0 host (sw) TX ring. Netmap will process it by converting it into an mbuf and calling if_input on em0, so that the packet will appear on em0 as if netmap did not exist.

So IMHO the bridge0 should behave the same. On the "hw" RX ring of bridge0 you will receive all the locally destined packets (or all of them in promiscuous mode). If you want some packets to go ahead like netmap never intercepted them, you would write them to the bridge0 host TX ring. Netmap will call the if_input method of bridge0, and I don't see why we should forward the packet across the bridge...

Suppose netmap intercepts a packet that would be forwarded from one bridge port to another, say em0 and em1. The application (a firewall, perhaps) decides it wants to allow the packet through, so it writes the packet to bridge0's host TX ring. netmap will call if_input of bridge0, but now the packet's receiving interface is bridge0, not em0. Thus, bridge_input() does not see the packet again, and the packet is sent to the protocol layers instead of being forwarded.

Feb 14 2023, 10:58 PM

Feb 11 2023

vmaffione added a comment to D38065: netmap: Fix queue stalls on generic interfaces.
Feb 11 2023, 4:53 PM
vmaffione added a comment to D38065: netmap: Fix queue stalls on generic interfaces.

It may be because of bhyve em0 emulation, I'm not sure it's bug free.
QEMU emulation (on a linux KVM box) should be very reliable.

Feb 11 2023, 4:51 PM
vmaffione accepted D37814: Mechanically convert netmap(4) to DrvAPI.
Feb 11 2023, 4:47 PM

Feb 8 2023

vmaffione added a comment to D38066: bridge: Add support for emulated netmap mode.

I implemented this - now only locally destined packets are visible to netmap by default.

To be honest, I'm still not entirely convinced that this makes sense. If if_bridge natively required IFF_PROMISC to be set in order to perform L2 forwarding, then I would certainly agree. But now IFF_PROMISC has a special meaning for netmap mode.

Feb 8 2023, 11:04 PM
vmaffione added a comment to D38066: bridge: Add support for emulated netmap mode.

Fix a problem with forwarding in netmap mode: when the application
writes packets to the host ring, the packets are injected via the
bridge's if_input to ether_input(). But this means that the bridge
interface won't see them again and in particular won't perform L2
forwarding.

Fix the problem by interposing bridge_inject() between if_input and
ether_input(). In netmap mode, bridge_inject() flags the packet
such that ether_input() will bring it back to the bridge, which can
then select a fake source port based on the source L2 addr. This
then allows forwarding to work.

Feb 8 2023, 10:13 PM
vmaffione added inline comments to D37814: Mechanically convert netmap(4) to DrvAPI.
Feb 8 2023, 9:44 PM
vmaffione added a comment to D38065: netmap: Fix queue stalls on generic interfaces.

Can I ask what kind of tests you performed? I guess you have set sysctl dev.netmap.admode=2 (see netmap(4)) and tried on a vtnet0 interface.
If not done yet, could you please perform some tests on an em0 interface (e.g. emulated by qemu or bhyve)?

Feb 8 2023, 9:18 PM
vmaffione requested changes to D37814: Mechanically convert netmap(4) to DrvAPI.

Still some changes to be done.

Feb 8 2023, 9:15 PM
vmaffione committed rGfa3f6655421f: netmap: drop redundant if_mtu assignment (authored by vmaffione).
netmap: drop redundant if_mtu assignment
Feb 8 2023, 9:08 PM

Feb 6 2023

vmaffione added inline comments to D38065: netmap: Fix queue stalls on generic interfaces.
Feb 6 2023, 9:53 PM

Feb 2 2023

vmaffione added a comment to D38066: bridge: Add support for emulated netmap mode.

Yes, I've seen that IFF_PROMISC is not handled by if_bridge right now...
This could allow us to ignore the problem for the moment being, and pass them all to netmap. But handling IFF_PROMISC properly would be the more reasonable approach.

Feb 2 2023, 5:42 PM

Jan 31 2023

vmaffione requested changes to D38065: netmap: Fix queue stalls on generic interfaces.

Ok with dropping the zerocopy, but I think we should try to reuse the mbufs.

Jan 31 2023, 10:21 PM

Jan 26 2023

vmaffione added a comment to D38066: bridge: Add support for emulated netmap mode.

Sure, I didn't mean to imply that any IP processing happens within the bridge code. I'll try to reformulate my question starting from your response. As you say there are two cases: depending on the dst ether address, the packet may (1) belong to the bridge or (2) belong to something else (reachable through some member port). In the first case, you have ether_demux() and maybe ip_input() on the bridge0 interface. In the second case, you forward to one (or more member ports). What I was trying to express (and failed to do so far), is that maybe when opening the netmap port in bridge0 you should only see the packets that match case (1) and not those that match case (2), assuming bridge0 is not in promisc mode (in promisc mode, you should also see packets of case (2)). This would match the behaviour of any other physical interface that you happen to open in netmap mode (again assuming no promisc mode), since you would only see packets with dst ether matching the MAC address of the physical interface.
I hope I managed to explain myself now...
What do you think?

Jan 26 2023, 9:42 PM

Jan 24 2023

vmaffione added a comment to D38066: bridge: Add support for emulated netmap mode.

Yes, but a member interface is something different from the bridge0 interface.
If I run netmap on a member interface I expect to see any packets that comes across that interface (irrespective of src or dst addresses), but I do not expect to see packets that come across other member functions (unless those packets also happen to pass through the member ifnet open in netmap mode).
Similary, if I run netmap on bridge0, I expect to see any packets that would be received on that interface if that interface would not be in netmap mode. If I am not mistaken, bridge0 only gets packets with IP destination matching the IP address of bridge0 (plus broadcasts).
In other words, I do not expect an interface to behave functionally different when open in netmap mode. I just want to use a different API. Would bridge0 in this case work differently when open in netmap mode?

Jan 24 2023, 10:21 PM

Jan 23 2023

vmaffione abandoned D29697: remove IFNET_RLOCK() that collides CTX_LOCK() in iflib_netmap_register.

Already merged.

Jan 23 2023, 9:36 PM
vmaffione resigned from D26161: valectl(8) patch to use the new netmap API.

Not relevant anymore.

Jan 23 2023, 9:33 PM
vmaffione added a comment to D38066: bridge: Add support for emulated netmap mode.

Doesn't bpf receive a copy of the packets, and the packets keep going their normal rule? Netmap steals the packets instead, so that's a completely different use case.

Jan 23 2023, 9:32 PM
vmaffione resigned from D26366: Add netmap support for lagg devices.

Support already merged in a different DR.

Jan 23 2023, 9:26 PM

Jan 18 2023

vmaffione accepted D38061: netmap: Tell the compiler to avoid reloading ring indices.
Jan 18 2023, 10:17 PM
vmaffione added a comment to D38061: netmap: Tell the compiler to avoid reloading ring indices.

I'm not sure on what you mean about the generic atomic_load...
Anyway, the original meaning of the comment is "Load the variable(s) only once, in order to avoid TOCTOU issues". We may update it to make it more clear.

Jan 18 2023, 9:56 PM
vmaffione added a comment to D38066: bridge: Add support for emulated netmap mode.

I'm sorry, what are we going to achieve here, exactly?

Jan 18 2023, 9:20 PM
vmaffione added a comment to D38061: netmap: Tell the compiler to avoid reloading ring indices.

Keep in mind that if the user writes to cur and head while the syscall is executing, then the user is breaking the ABI and the result is undefined (but no harm can happen because of the checks of the prologue).

Jan 18 2023, 9:09 PM
vmaffione added a comment to D38064: netmap: Try to count packet drops in emulated mode.

Yes, indeed, this is definitely fine! That was just a note on the historical approach.
We could later even increment the counters to emulated rxsync and txsync methods, since those increments would apply once per batch (like in iflib).

Jan 18 2023, 8:59 PM

Jan 16 2023

vmaffione accepted D38064: netmap: Try to count packet drops in emulated mode.

No objections for emulated mode, but keep in mind that patched drivers do not have the counters incremented to avoid the performance hit.
(Although we may revisit this with some proper overahd measurements in place).

Jan 16 2023, 8:55 PM
vmaffione accepted D38063: netmap: Correct a comment.
Jan 16 2023, 8:50 PM
vmaffione accepted D38062: netmap: Fix a queue length check in the generic port rx path.
Jan 16 2023, 8:50 PM

Jan 11 2023

vmaffione requested changes to D37814: Mechanically convert netmap(4) to DrvAPI.

A first pass.

Jan 11 2023, 5:45 PM

Dec 31 2022

vmaffione committed rGe81ecab4b18f: netmap: bridge: fix -Wdate-time compilation issue (authored by vmaffione).
netmap: bridge: fix -Wdate-time compilation issue
Dec 31 2022, 2:57 PM
vmaffione committed rG03c82ccba083: netmap: several typo fixes (authored by vmaffione).
netmap: several typo fixes
Dec 31 2022, 2:47 PM
vmaffione committed rG651dd086bf73: pkt-gen: Allow limiting received packets (authored by allanjude).
pkt-gen: Allow limiting received packets
Dec 31 2022, 2:36 PM
vmaffione committed rGb4f8bd4de92b: libnetmap: reset errno in nmreq_register_decode() (authored by vmaffione).
libnetmap: reset errno in nmreq_register_decode()
Dec 31 2022, 12:44 PM
vmaffione committed rGa95578c87cd0: nemtap: lb app: Validate ihl field when hashing packet (authored by vmaffione).
nemtap: lb app: Validate ihl field when hashing packet
Dec 31 2022, 12:44 PM
vmaffione committed rGe93766bcd4e1: netmap: don't use linux type struct device * (authored by vmaffione).
netmap: don't use linux type struct device *
Dec 31 2022, 12:40 PM
vmaffione committed rGf7691b18b76e: netmap: vale: fix disabled logs (authored by vmaffione).
netmap: vale: fix disabled logs
Dec 31 2022, 12:39 PM
vmaffione committed rG87c145309ecd: netmap: monitor: add a flag to distinguish packet direction (authored by vmaffione).
netmap: monitor: add a flag to distinguish packet direction
Dec 31 2022, 12:31 PM
vmaffione committed rG7a1e0af7d0df: netmap: pkt-gen: fix ifname before cmp in source_hwaddr (authored by vmaffione).
netmap: pkt-gen: fix ifname before cmp in source_hwaddr
Dec 31 2022, 12:31 PM
vmaffione committed rG79a1edf21e83: netmap: monitor: add missing netmap_adapter_put() (authored by vmaffione).
netmap: monitor: add missing netmap_adapter_put()
Dec 31 2022, 12:31 PM
vmaffione committed rG6e23ef9c5784: debug_put_get: don't crash on null pointers (authored by vmaffione).
debug_put_get: don't crash on null pointers
Dec 31 2022, 12:30 PM
vmaffione committed rGa74ed1442347: monitor: fix cb restore when monitored adapter unregisters (authored by vmaffione).
monitor: fix cb restore when monitored adapter unregisters
Dec 31 2022, 12:30 PM
vmaffione committed rG82e3b96039bd: netmap: drop compatibility FreeBSD code (authored by vmaffione).
netmap: drop compatibility FreeBSD code
Dec 31 2022, 12:30 PM
vmaffione committed rGb0491d5a73d1: netmap_update_config: update na->name to cope with reconfigurations (authored by vmaffione).
netmap_update_config: update na->name to cope with reconfigurations
Dec 31 2022, 12:30 PM