Page MenuHomeFreeBSD

netmap: Fix compiler warnings in tools
ClosedPublic

Authored by markj on Feb 23 2023, 11:43 PM.
Tags
None
Referenced Files
F163082939: D38752.id118009.diff
Sun, Jul 19, 10:27 PM
Unknown Object (File)
Sat, Jul 18, 10:43 PM
Unknown Object (File)
Sat, Jul 18, 8:22 PM
Unknown Object (File)
Sat, Jul 18, 4:59 PM
Unknown Object (File)
Thu, Jul 16, 5:55 PM
Unknown Object (File)
Thu, Jul 16, 1:31 AM
Unknown Object (File)
Sat, Jul 4, 8:24 PM
Unknown Object (File)
Thu, Jul 2, 4:30 PM
Subscribers

Details

Summary
  • Remove write-only variables, or hide them in cases where their use is conditional or commented out.
  • Check for errors from cmd_apply() in nmreplay.
  • Use ANSI C definitions.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tools/tools/netmap/lb.c
392

This one gives a compile error with clang 15.

vmaffione added inline comments.
tools/tools/netmap/pkt-gen.c
1524

why not dropping this?

1550–1551

why not dropping this? It looks like leftover code

This revision now requires changes to proceed.Feb 26 2023, 3:41 PM
tools/tools/netmap/pkt-gen.c
1550–1551

There are some commented-out prints that reference rx. Should I remove those as well?

Drop commented-out lines in pkt-gen.

Yeah, if not used since you are here please clean it up.

This revision is now accepted and ready to land.Feb 27 2023, 5:26 PM
This revision was automatically updated to reflect the committed changes.