netmap: Add some simple regression tests
Needs ReviewPublic
Actions

Authored by markj on Apr 5 2023, 3:52 PM.

Details

Reviewers

Summary

These test functionality of netmap's generic mode combined with several
types of software interfaces: currently just bridges, vlans and epairs.
To be added are tests for lagg and tap.

The test code includes a copy of bridge.c which has some functionality
removed and prints the number of packets forwarded in each direction.
This can be used to check that userspace indeed receives an expected
number of packets.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50772
Build 47663: arc lint + arc unit

Event Timeline

markj created this revision.Apr 5 2023, 3:52 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptApr 5 2023, 3:52 PM

markj requested review of this revision.Apr 5 2023, 3:52 PM

Harbormaster completed remote builds in B50772: Diff 119899.Apr 5 2023, 3:52 PM

markj mentioned this in D38065: netmap: Fix queue stalls on generic interfaces.Apr 5 2023, 4:01 PM

If useful, please note that there are already a bunch of integration tests in the github netmap repo, e.g.:
https://github.com/luigirizzo/netmap/blob/master/utils/randomized_tests

A short description here https://github.com/luigirizzo/netmap/blob/master/utils/README

In D39431#897747, @vmaffione wrote:

If useful, please note that there are already a bunch of integration tests in the github netmap repo, e.g.:
https://github.com/luigirizzo/netmap/blob/master/utils/randomized_tests

A short description here https://github.com/luigirizzo/netmap/blob/master/utils/README

Oh, interesting. Do you think this could be integrated into FreeBSD's test suite without too much pain?

Sorry for the delay. I've little experience with the FreeBSD test suite, so I wouldn't know...

franco_opnsense.org added a subscriber: franco_opnsense.org.Apr 11 2023, 2:26 PM