netmap: Ignore errors in CSB_WRITE()
ClosedPublic
Actions

Authored by markj on Dec 26 2023, 11:56 PM.

Details

Reviewers

Commits

rGaa545f18d384: netmap: Ignore errors in CSB_WRITE()
rG99efa2c88d93: netmap: Ignore errors in CSB_WRITE()

Summary

The CSB_WRITE() and _READ() macros respectively write to and read from
userspace memory and so can in principle fault. However, we do not
check for errors and will proceed blindly if they fail. Add assertions
to verify that they do not.

This is in preparation for annotating copyin() and related functions
with __result_use_check.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Dec 26 2023, 11:56 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 26 2023, 11:56 PM

markj requested review of this revision.Dec 26 2023, 11:56 PM

Harbormaster completed remote builds in B55128: Diff 131885.Dec 26 2023, 11:57 PM

vmaffione accepted this revision.Dec 27 2023, 8:11 AM

This revision is now accepted and ready to land.Dec 27 2023, 8:11 AM

Closed by commit rG99efa2c88d93: netmap: Ignore errors in CSB_WRITE() (authored by markj). · Explain WhyDec 27 2023, 3:16 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG99efa2c88d93: netmap: Ignore errors in CSB_WRITE().

markj added a commit: rGaa545f18d384: netmap: Ignore errors in CSB_WRITE().Jan 4 2024, 1:49 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

netmap/

netmap_kern.h

15 lines

Diff 131909

View Options

sys/dev/netmap/netmap_kern.h

netmap: Ignore errors in CSB_WRITE()ClosedPublicActions