Page MenuHomeFreeBSD

cam: fix UB behavior
ClosedPublic

Authored by imp on Jun 21 2021, 6:01 PM.
Tags
None
Referenced Files
F137294574: D30847.id.diff
Sat, Nov 22, 3:57 AM
Unknown Object (File)
Fri, Nov 14, 12:59 PM
Unknown Object (File)
Fri, Nov 14, 10:52 AM
Unknown Object (File)
Mon, Nov 3, 4:00 PM
Unknown Object (File)
Thu, Oct 30, 12:43 AM
Unknown Object (File)
Oct 17 2025, 2:58 AM
Unknown Object (File)
Oct 16 2025, 1:53 AM
Unknown Object (File)
Sep 27 2025, 10:06 PM
Subscribers
None

Details

Reviewers
ken
mav
scottl
Group Reviewers
cam
Commits
rG56e1161b09c3: cam: fix UB behavior
Summary

The trick of subtracting one from the poitner returned from malloc
results in undefined behavior:

C89: 3.3.6 Unless both the pointer operand and the result point to a
member of the same array object, or one past the last member of the
array object, the behavior is undefined.

Instead, allocate 1 extra element and stop adjusting the pointer. While
a little wasteful, the extra is in the noise on today's systems.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jun 21 2021, 6:01 PM

Thank you. This stuff always broke my brain.

This revision is now accepted and ready to land.Jun 24 2021, 3:11 AM
This revision was automatically updated to reflect the committed changes.