Differential D30879

cam: Remove CAM_TRUE and CAM_FALSE, they are unused and duplicate bool
ClosedPublic
Actions

Authored by imp on Jun 23 2021, 8:37 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 15, 11:19 AM

	Unknown Object (File)
	Fri, May 15, 7:35 AM

	Unknown Object (File)
	Thu, May 14, 6:20 PM

	Unknown Object (File)
	Tue, May 12, 10:59 AM

	Unknown Object (File)
	Mon, May 11, 7:02 AM

	Unknown Object (File)
	Mon, May 11, 2:36 AM

	Unknown Object (File)
	Mon, May 11, 2:06 AM

	Unknown Object (File)
	Mon, May 11, 2:05 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG2b0987023804: cam: Remove CAM_TRUE and CAM_FALSE, they are unused and duplicate bool

Summary

These were in the original CAM commit in 3.x, but were not used there,
nor have they been used since then that I can tell.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jun 23 2021, 8:37 PM

Herald added a reviewer: cam. · View Herald TranscriptJun 23 2021, 8:37 PM

imp requested review of this revision.Jun 23 2021, 8:37 PM

Harbormaster completed remote builds in B40064: Diff 91277.Jun 23 2021, 8:37 PM

imp edited the summary of this revision. (Show Details)Jun 23 2021, 8:38 PM

imp edited the summary of this revision. (Show Details)Jun 23 2021, 8:42 PM

Part of me feels that abstracted definitions for implementation semantics is good API design, but it sounds like this is a good candidate for garbage collection.

This revision is now accepted and ready to land.Jun 24 2021, 1:31 AM

In D30879#694645, @scottl wrote:

Part of me feels that abstracted definitions for implementation semantics is good API design, but it sounds like this is a good candidate for garbage collection.

Had they been in use, I'd likely not have bothered to try to eliminate them as is the trend elsewhere for other non-standard bools... But since they were unused for 23 years, I rather suspected they weren't in line for use any time soon.

imp added a child revision: D30884: cam: change xpt_clone_path to return int.Jun 24 2021, 10:39 PM

Closed by commit rG2b0987023804: cam: Remove CAM_TRUE and CAM_FALSE, they are unused and duplicate bool (authored by imp). · Explain WhyJun 28 2021, 10:26 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG2b0987023804: cam: Remove CAM_TRUE and CAM_FALSE, they are unused and duplicate bool.

Revision Contents
Changeset List

Path

Size

sys/

cam/

3 lines

Diff 91475

sys/cam/cam_ccb.h

Loading...