Page MenuHomeFreeBSD

cam: Remove CAM_TRUE and CAM_FALSE, they are unused and duplicate bool
ClosedPublic

Authored by imp on Jun 23 2021, 8:37 PM.

Details

Summary

These were in the original CAM commit in 3.x, but were not used there,
nor have they been used since then that I can tell.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp requested review of this revision.Jun 23 2021, 8:37 PM
scottl added a subscriber: scottl.

Part of me feels that abstracted definitions for implementation semantics is good API design, but it sounds like this is a good candidate for garbage collection.

This revision is now accepted and ready to land.Jun 24 2021, 1:31 AM

Part of me feels that abstracted definitions for implementation semantics is good API design, but it sounds like this is a good candidate for garbage collection.

Had they been in use, I'd likely not have bothered to try to eliminate them as is the trend elsewhere for other non-standard bools... But since they were unused for 23 years, I rather suspected they weren't in line for use any time soon.